From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751834AbcDONOV (ORCPT ); Fri, 15 Apr 2016 09:14:21 -0400 Received: from conssluserg-01.nifty.com ([210.131.2.80]:39182 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbcDONOU (ORCPT ); Fri, 15 Apr 2016 09:14:20 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com u3FDDt4Q007400 X-Nifty-SrcIP: [209.85.161.173] MIME-Version: 1.0 In-Reply-To: <20160415130549.GB8021@leverpostej> References: <1460716247-28049-1-git-send-email-yamada.masahiro@socionext.com> <1460716247-28049-3-git-send-email-yamada.masahiro@socionext.com> <20160415130549.GB8021@leverpostej> Date: Fri, 15 Apr 2016 22:13:55 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] arm64: dts: uniphier: change release address of spin-table From: Masahiro Yamada To: Mark Rutland Cc: arm@kernel.org, devicetree@vger.kernel.org, Kumar Gala , Linux Kernel Mailing List , Ian Campbell , Rob Herring , Pawel Moll , Will Deacon , Catalin Marinas , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark. 2016-04-15 22:05 GMT+09:00 Mark Rutland : > On Fri, Apr 15, 2016 at 07:30:47PM +0900, Masahiro Yamada wrote: >> The 8-byte register located at 0x59801200 on this SoC is dedicated >> for waking up secondary CPUs. We can use it and save normal memory. > > Generally, it is not safe to use MMIO registers to back spin-table. The > kernel maps the spin table location with cacheable attributes, so there > may be speculative accesses to any registes in the same (64K) page, and > a writeback may be larger than the 8-byte register width (which the > device might not accept, triggering an SError). > > Given that, I do not think this is a good idea. I did not know this. Thanks for your advice! Arnd, Olof Please drop this patch. (I think 1/2 is still OK.) -- Best Regards Masahiro Yamada