mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
	Nathan Chancellor <nathan@kernel.org>,
	 Kris Van Hees <kris.van.hees@oracle.com>,
	rostedt@goodmis.org,  kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] gitignore: Don't ignore 'tags' directory
Date: Mon, 25 Nov 2024 17:21:26 +0900	[thread overview]
Message-ID: <CAK7LNASAfvb4Z59QF8cBgFJPLhi-dfOGYwB_J5+1GGanYTe-Aw@mail.gmail.com> (raw)
In-Reply-To: <20241125072308.421686-1-lizhijian@fujitsu.com>

On Mon, Nov 25, 2024 at 4:23 PM Li Zhijian <lizhijian@fujitsu.com> wrote:
>
> LKP reported warnings [1] regarding files being ignored:
>    tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files
>    tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files
>    tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files
>
> These warnings were generated by ./scripts/misc-check. Although these files
> are tracked by Git and the warnings are false positives, adjusting the
> .gitignore entries will prevent these warnings and ensure a smoother script
> execution.

You do not need to mention a special tool because you can see them
when building the kernel with W=1.

You can say "Building the kernel with W=1 shows ..."



>
> [1] https://lore.kernel.org/linux-kselftest/202411251308.Vjm5MzVC-lkp@intel.com/
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>  .gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 56972adb5031..e63dbba823cd 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -130,6 +130,9 @@ series
>  tags
>  TAGS

Unfortunately, GIT does not support "only match to regular files",
but you can make the intention clearer:


# ctags files
tags
!tags/
TAGS



You can add "!tags/" right below "tags".
Then, your comment is unnecessary.


-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2024-11-25  8:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25  7:23 Li Zhijian
2024-11-25  8:21 ` Masahiro Yamada [this message]
2024-11-25  8:30   ` Zhijian Li (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNASAfvb4Z59QF8cBgFJPLhi-dfOGYwB_J5+1GGanYTe-Aw@mail.gmail.com \
    --to=masahiroy@kernel.org \
    --cc=kris.van.hees@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=lkp@intel.com \
    --cc=nathan@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®