From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DED5E95A91 for ; Mon, 9 Oct 2023 12:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376448AbjJIMey (ORCPT ); Mon, 9 Oct 2023 08:34:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346630AbjJIMet (ORCPT ); Mon, 9 Oct 2023 08:34:49 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5663DB7; Mon, 9 Oct 2023 05:34:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E682EC433CB; Mon, 9 Oct 2023 12:34:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696854887; bh=1k6rM4lCLYpCX7xu2JGVxkuiNxryABdz8CHGqmNOj/U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=vDcEaXl9niuNNqo067jjIO6MMpwKln23++Wm9pOabCws7E3hr5AIWzEFJlCZ9aToo t0b3KY2LRdgWtvBVgnxJC2ixXR00E9T+lTYfAWiKF1FyHYWv4enhFQbfzIkOqaD7fW oN8SQBkK3ZHhos/5QrsPoOSKJWM3wNculCFS62bjPwugJrK142pUuXffm5GCRHn3eq LtI6qiI90GRxvQMB6Y7huX7L8gPAZ8KIYl3eeJN51+3TVgCDod6YDgCnyEdyx6NWAV g/2GI/3tqwDWWPUskI+61MgVlLe552Trk1fnHD9Xhzp5QEqrp97iXZEScLHqcGdCqe ApIYm0cmb4ktA== Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-6c49f781855so3040053a34.3; Mon, 09 Oct 2023 05:34:47 -0700 (PDT) X-Gm-Message-State: AOJu0YzERQ6pbqFvy6DfjKmcvAYSoDFrPtQoHMJqVKZvGnZBHQ/4ANfc Bx86BIeUlVI58Tix7+ZSs1AgqTif/rcybz1RT5U= X-Google-Smtp-Source: AGHT+IFIbTz5t8VY6Ya5IBjf6SaeC2Hdeqj8i7oFiUWiND7dZgmlnVzVpWdR/Ce+OQTdLzfG7B4rbmkZQ5DeLtjK5EU= X-Received: by 2002:a05:6870:a688:b0:1c8:b715:6c81 with SMTP id i8-20020a056870a68800b001c8b7156c81mr17805871oam.55.1696854887278; Mon, 09 Oct 2023 05:34:47 -0700 (PDT) MIME-Version: 1.0 References: <20231005150728.3429-1-msuchanek@suse.de> <20231009085208.GT6241@kitsune.suse.cz> In-Reply-To: <20231009085208.GT6241@kitsune.suse.cz> From: Masahiro Yamada Date: Mon, 9 Oct 2023 21:34:10 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB To: =?UTF-8?Q?Michal_Such=C3=A1nek?= Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Schier , linux-modules@vger.kernel.org, Takashi Iwai , Lucas De Marchi , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Jiri Slaby , Jan Engelhardt , Nathan Chancellor , Nick Desaulniers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 9, 2023 at 5:52=E2=80=AFPM Michal Such=C3=A1nek wrote: > > Hello, > > On Mon, Oct 09, 2023 at 05:31:02PM +0900, Masahiro Yamada wrote: > > On Fri, Oct 6, 2023 at 12:49=E2=80=AFAM Michal Suchanek wrote: > > > > > > The default MODLIB value is composed of two variables and the hardcod= ed > > > string '/lib/modules/'. > > > > > > MODLIB =3D $(INSTALL_MOD_PATH)/lib/modules/$(KERNELRELEASE) > > > > > > Defining this middle part as a variable was rejected on the basis tha= t > > > users can pass the whole MODLIB to make, such as > > > > > > In other words, do you want to say > > > > "If defining this middle part as a variable had been accepted, > > this patch would have been unneeded." ? > > If it were accepted I would not have to guess what the middle part is, > and could use the variable that unambiguosly defines it instead. How? scripts/package/kernel.spec hardcodes 'lib/modules' in a couple of places. I am asking how to derive the module path. --=20 Best Regards Masahiro Yamada