From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] kbuild: $(CHECK) doesnt need NOSTDINC_FLAGS twice
Date: Tue, 29 May 2018 22:07:46 +0900 [thread overview]
Message-ID: <CAK7LNAT+kRLrpLTxxEPO1_O2SUEFJG-R+ZN5rRcc_Cy6yaar7A@mail.gmail.com> (raw)
In-Reply-To: <20180528134722.11358-1-luc.vanoostenryck@gmail.com>
2018-05-28 22:47 GMT+09:00 Luc Van Oostenryck <luc.vanoostenryck@gmail.com>:
> Currently, $(CHECK) receives NOSTDINC_FLAGS twice:
> * first directly in the main Makefile via CHECKFLAGS,
> * then indirectly in scripts/Makefile.build via c_flags.
>
> Since once is enough, leave the occurence via c_flags and
> remove the one via CHECKFLAGS.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
Applied to linux-kbuild. Thanks.
> Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 56ba070df..3140ab1db 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -808,7 +808,6 @@ endif
>
> # arch Makefile may override CC so keep this after arch Makefile is included
> NOSTDINC_FLAGS += -nostdinc -isystem $(call shell-cached,$(CC) -print-file-name=include)
> -CHECKFLAGS += $(NOSTDINC_FLAGS)
>
> # warn about C99 declaration after statement
> KBUILD_CFLAGS += $(call cc-option,-Wdeclaration-after-statement,)
> --
> 2.17.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2018-05-29 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 13:47 Luc Van Oostenryck
2018-05-29 13:07 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAT+kRLrpLTxxEPO1_O2SUEFJG-R+ZN5rRcc_Cy6yaar7A@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome