From: anish singh <anish198519851985@gmail.com>
To: Chanho Min <chanho.min@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nadia Yvette Chambers <nyc@holomorphy.com>,
Jiri Kosina <jkosina@suse.cz>, Joe Perches <joe@perches.com>,
linux-kernel-mail <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND v3] bitmap: speed up bitmap_find_free_region
Date: Tue, 7 May 2013 17:12:52 +0530 [thread overview]
Message-ID: <CAK7N6vopfEZPf1BGi6qWtt37m0e-1PScTm_d8sMED2twADD2PQ@mail.gmail.com> (raw)
In-Reply-To: <1367914553-1999-1-git-send-email-chanho.min@lge.com>
On Tue, May 7, 2013 at 1:45 PM, Chanho Min <chanho.min@lge.com> wrote:
> In bitmap_find_free_region, If we skip the all-ones words and find bits
> in a not-all-ones word, we can improve performance of it.
>
> For example, If bitmap_find_free_region() is called with order=0, First,
> It scans bitmap array by the increment of long type, then find 1 free bit
> within 1 long type value. In 32 bits system and 1024 bits size, in the worst
> case, We need 1024 for-loops to find 1 free bit. But, If this is applied,
> it takes 64 for-loops. Instead, It will be needed additional if-comparison
> of every word and It can take time slightly as 'Test case 3'. But, In many
> cases, It will speed up significantly.
>
> Test cases bellows show the time taken to execute bitmap_find_free_region()
> before and after patch.
>
> Test condition : ARMv7 1GHZ 32 bits system, 1024 bits size, gcc 4.6.2
>
> Test case 1: order is 0. all bits are one except that last one bit is zero.
> before patch: 29727 ns
> after patch: 2349 ns
How did you find out this time?Can you please post your code
for that?
>
> Test case 2: order is 1. all bits are one except that last 2 contiguous bits
> are zero.
> before patch: 15475 ns
> after patch: 2225 ns
>
> Test case 3: order is 1. all words are not-all-ones and don't have 2 contiguous
> bits except that last 2 contiguous are zero.
> before patch: 15475 ns
> after patch: 16131 ns
>
> Changes compared to v1:
> - Modified unnecessarily complicated code.
> - Fixed the buggy code if `bits' is not an multiple of BITS_PER_LONG.
>
> Changes compared to v2:
> - Removed bitmap_find_free_one and merged it to bitmap_find_free_region.
>
> Signed-off-by: Chanho Min <chanho.min@lge.com>
> ---
> lib/bitmap.c | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/lib/bitmap.c b/lib/bitmap.c
> index 06f7e4f..95e8efc 100644
> --- a/lib/bitmap.c
> +++ b/lib/bitmap.c
> @@ -1114,14 +1114,21 @@ done:
> */
> int bitmap_find_free_region(unsigned long *bitmap, int bits, int order)
> {
> - int pos, end; /* scans bitmap by regions of size order */
> -
> - for (pos = 0 ; (end = pos + (1 << order)) <= bits; pos = end) {
> - if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE))
> - continue;
> - __reg_op(bitmap, pos, order, REG_OP_ALLOC);
> - return pos;
> - }
> + int pos, end, nbit, i; /* scans bitmap by regions of size order */
> + int nlongs = BITS_TO_LONGS(bits);
> +
> + for (i = 0; i < nlongs; i++)
> + if (bitmap[i] != ~0UL) {
> + pos = i * BITS_PER_LONG;
> + nbit = min(bits, pos + BITS_PER_LONG);
> + for (; (end = pos + (1 << order)) <= nbit; pos = end) {
> + if (!__reg_op(bitmap, pos, order,
> + REG_OP_ISFREE))
> + continue;
> + __reg_op(bitmap, pos, order, REG_OP_ALLOC);
> + return pos;
> + }
> + }
> return -ENOMEM;
> }
> EXPORT_SYMBOL(bitmap_find_free_region);
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-05-07 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 8:15 Chanho Min
2013-05-07 11:42 ` anish singh [this message]
2013-05-08 0:59 ` Re : " Chanho Min
2013-05-08 20:24 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7N6vopfEZPf1BGi6qWtt37m0e-1PScTm_d8sMED2twADD2PQ@mail.gmail.com \
--to=anish198519851985@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chanho.min@lge.com \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nyc@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®