From: Arnd Bergmann <arnd@arndb.de>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Akinobu Mita <mita@miraclelinux.com>,
Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH] sched: remove sched_find_first_bit()
Date: Mon, 15 May 2017 16:18:49 +0200 [thread overview]
Message-ID: <CAK8P3a18vzO2AigK3FiTHL33SjXcHGL4dxB3qASrLFm7bJN7ww@mail.gmail.com> (raw)
In-Reply-To: <20170513010152.13986-1-ynorov@caviumnetworks.com>
On Sat, May 13, 2017 at 3:01 AM, Yury Norov <ynorov@caviumnetworks.com> wrote:
> include/asm-generic/bitops/sched.h as it declares only this
> function. Alpha has it's own implementation, very similar to
> generic one, so it is also removed.
Nice consolidation, I see that every architecture once had a copy of
this function, and they were all removed at one point long ago,
except for Alpha, and there is no reason to leave that one in the tree.
I'll leave it to you and Ingo to figure out what the two callers should
do, but for removing function from asm-generic:
Acked-by: Arnd Bergmann <arnd@arndb.de>
Maybe you could split the patch into two changesets, and make the
first of them move the function to kernel/sched/rt.c, and the second
one (if we still want it then) can change the implementation to whatever
you conclude is ideal.
Arnd
prev parent reply other threads:[~2017-05-15 14:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 1:01 Yury Norov
2017-05-14 18:09 ` Ingo Molnar
2017-05-15 15:47 ` Yury Norov
2017-05-15 16:06 ` Arnd Bergmann
2017-05-15 16:17 ` Yury Norov
2017-05-15 20:31 ` Arnd Bergmann
2017-05-15 20:58 ` Yury Norov
2017-05-15 21:04 ` Arnd Bergmann
2017-05-16 8:30 ` Ingo Molnar
2017-05-17 12:16 ` Yury Norov
2017-05-18 7:14 ` Ingo Molnar
2017-05-15 14:18 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a18vzO2AigK3FiTHL33SjXcHGL4dxB3qASrLFm7bJN7ww@mail.gmail.com \
--to=arnd@arndb.de \
--cc=efault@gmx.de \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=mita@miraclelinux.com \
--cc=peterz@infradead.org \
--cc=rth@twiddle.net \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®