From: Arnd Bergmann <arnd@arndb.de>
To: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: gregkh <gregkh@linuxfoundation.org>,
Stuart Yoder <stuyoder@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Alexander Graf <agraf@suse.de>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Ruxandra Ioana Radulescu <ruxandra.radulescu@nxp.com>,
Bharat Bhushan <bharat.bhushan@nxp.com>,
Catalin Horghidan <catalin.horghidan@nxp.com>,
Leo Li <leoyang.li@nxp.com>, Roy Pledge <roy.pledge@nxp.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits
Date: Tue, 18 Jul 2017 13:39:48 +0200 [thread overview]
Message-ID: <CAK8P3a1HDSXXsSfSfOrHYSGLhNKOv__JAFVH-RVZAbojq+=AOA@mail.gmail.com> (raw)
In-Reply-To: <596DEC19.6060301@nxp.com>
On Tue, Jul 18, 2017 at 1:08 PM, Laurentiu Tudor
<laurentiu.tudor@nxp.com> wrote:
> On 07/17/2017 06:00 PM, Arnd Bergmann wrote:
>> Strictly speaking the __raw_writel() won't guarantee that the
>> data is written as a single word, the compiler might decide to
>> split it up into byte-sized writes if it believes the destination pointer
>> is unaligned and the CPU has no efficient writes.
>>
>> I think this cannot happen on arm or powerpc, as we go through
>> inline assembly for the store, but it's not completely portable.
>
> Should i worry about portability? Slim changes that this driver
> will ever run on anything else other than ARM & ARM64.
> My current goal was just to make it compile on other arches.
I always recommend writing any driver in the most portable way
out of principle, since you never know who looks at it for reference
when writing another driver.
I wouldn't expect the driver itself to be used on other architectures,
but of course you never know what CPU becomes fashionable
10 years from now.
Arnd
next prev parent reply other threads:[~2017-07-18 11:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 13:26 [PATCH 0/7] staging: fsl-mc: make the driver compile on other architectures laurentiu.tudor
2017-07-17 13:26 ` [PATCH 1/7] staging: fsl-mc: add missing fsl_mc comment in struct msi_desc laurentiu.tudor
2017-07-17 13:26 ` [PATCH 2/7] staging: fsl-mc: use generic memory barriers laurentiu.tudor
2017-07-17 13:38 ` Robin Murphy
2017-07-17 13:46 ` Laurentiu Tudor
2017-07-17 13:26 ` [PATCH 3/7] staging: fsl-mc: drop useless gic v3 related #include laurentiu.tudor
2017-07-17 13:26 ` [PATCH 4/7] staging: fsl-mc: fix compilation with non-generic msi domain ops laurentiu.tudor
2017-07-17 13:26 ` [PATCH 5/7] staging: fsl-mc: fix formating of phys_addr_t on 32 bits laurentiu.tudor
2017-07-17 13:26 ` [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits laurentiu.tudor
2017-07-17 13:43 ` Robin Murphy
2017-07-17 14:53 ` Laurentiu Tudor
2017-07-17 13:45 ` Arnd Bergmann
2017-07-17 14:27 ` Laurentiu Tudor
2017-07-17 15:00 ` Arnd Bergmann
2017-07-18 11:08 ` Laurentiu Tudor
2017-07-18 11:39 ` Arnd Bergmann [this message]
2017-07-17 13:26 ` [PATCH 7/7] staging: fsl-mc: allow the driver compile multi-arch laurentiu.tudor
2017-07-19 16:09 ` kbuild test robot
2017-07-19 17:31 ` kbuild test robot
2017-07-20 13:47 ` Laurentiu Tudor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1HDSXXsSfSfOrHYSGLhNKOv__JAFVH-RVZAbojq+=AOA@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=agraf@suse.de \
--cc=bharat.bhushan@nxp.com \
--cc=catalin.horghidan@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ioana.ciornei@nxp.com \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=roy.pledge@nxp.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®