From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752868AbeADLbs (ORCPT + 1 other); Thu, 4 Jan 2018 06:31:48 -0500 Received: from mail-ot0-f193.google.com ([74.125.82.193]:44764 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbeADLbq (ORCPT ); Thu, 4 Jan 2018 06:31:46 -0500 X-Google-Smtp-Source: ACJfBouNof6IINJO5/tybCRJs8DAiCVNNKJ6cuNEs7ImvQi+oW3r50eiz8rY4tubS2FM7t+rRG/dkRNzvIU/x40WbLU= MIME-Version: 1.0 In-Reply-To: <20180104103215.15591-3-arnd@arndb.de> References: <20180104103215.15591-1-arnd@arndb.de> <20180104103215.15591-3-arnd@arndb.de> From: Arnd Bergmann Date: Thu, 4 Jan 2018 12:31:45 +0100 X-Google-Sender-Auth: mbG3MG8ll1h6mbRvYZNdoYq20Ng Message-ID: Subject: Re: [PATCH 3/3] media: au0828: add VIDEO_V4L2 dependency To: Mauro Carvalho Chehab Cc: Arnd Bergmann , Linux Media Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 4, 2018 at 11:31 AM, Arnd Bergmann wrote: > After the move of videobuf2 into the common directory, selecting the > au0828 driver with CONFIG_V4L2 disabled started causing a link failure, > as we now attempt to build videobuf2 but it still requires v4l2: > > ERROR: "v4l2_event_pending" [drivers/media/common/videobuf/videobuf2-v4l2.ko] undefined! > ERROR: "v4l2_fh_release" [drivers/media/common/videobuf/videobuf2-v4l2.ko] undefined! > ERROR: "video_devdata" [drivers/media/common/videobuf/videobuf2-v4l2.ko] undefined! > ERROR: "__tracepoint_vb2_buf_done" [drivers/media/common/videobuf/videobuf2-core.ko] undefined! > ERROR: "__tracepoint_vb2_dqbuf" [drivers/media/common/videobuf/videobuf2-core.ko] undefined! > ERROR: "v4l_vb2q_enable_media_source" [drivers/media/common/videobuf/videobuf2-core.ko] undefined! > > This adds the same dependency in au0828 that the other users of videobuf2 > have. > > Fixes: 03fbdb2fc2b8 ("media: move videobuf2 to drivers/media/common") > Fixes: 05439b1a3693 ("[media] media: au0828 - convert to use videobuf2") > Signed-off-by: Arnd Bergmann On a further look, this prevents us from building the RC driver without the V4L2 driver, which was the reason this driver is split. I'll send a v2, but it needs more randconfig testing than this version. Arnd