From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEEAB31A572 for ; Wed, 24 Jun 2026 22:41:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.221.42 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782340913; cv=pass; b=WqHWEScIhqRgdjy266e7ejqrRo8c6Gn0AAKhj89Mqs5+liqJlYV9d0HfSUQWUPCaRAjMHzOe3E4ZqGSJMRL0Udp/1YFdhcFaBhTq24TGdtDaYbIuqc1vDgsPKMsPEoPxXT0uMJzltn/Q6OM6auWgICMOgs/FkRtnZukoVe+Sghk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782340913; c=relaxed/simple; bh=44vcFT2zS81zuO/QITHQpzEjB4PfuTchVm77v5ONeL0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=goRkbWSIaLZkQidl7Kv2OVEJv7qsjEpZSVxH1StDZrJi1UcQx7c86XfzM9oOadVZR+/WkAA4teIW+yQ6ExPxMWfMbDwltCqC9b0kN4qeIw1TOQmUCok2CFLbMWz1mp1Bzwn43sJUwdWkOQfJ+5jDNtTijEg1khowBJZpASUsZeo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DEwKlsvC; arc=pass smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DEwKlsvC" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4645995069bso1036197f8f.1 for ; Wed, 24 Jun 2026 15:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782340909; cv=none; d=google.com; s=arc-20240605; b=S85VOJFesKE/KXUffwDwts6zRD3tnaWntDlg3oyUUHbfFgYxywzkUMZmm/YSi9Xi+M Dw/DawVTlKIYVF7WS4jJl8ubX83T1q42DWyQE1dBSEV61n8yF/j2uewcbChqdY6lB4vh TXJX3EaDfQ1W+uI0C4doYr3U60KccLqL0wEG+A4p0cS5B28hsokSNYi5NCA4bnGHjz0t i7K721ZlRmjbo75RUf3z/EYJgKrfq2p4IZ3iUG5VpfYsXj+6VZCyZmz7qkx5M5wVLFzX h29mqOoYWwzaHs0SycWVaVJVoZRgLvfp2CTWmUlDLOmwW3I//8ZXrFAFQh6hi45CGZtI 9Itg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=WJs/bqJV28nRmEFkkVv0HdnYQ72Ru/Q9zWNCjXeVDns=; fh=NRjMNlpi4DEi6w2Ar9wdr71z9RizbKaIfCQLhXwCsQQ=; b=dmCd3S249RaVVWg2BVfLshzwwLUzfjRO+ZbPtkriMtNUWV1M7v3gDAtz/3AAhdiQdH 2zTvAgdsTObGtau+bYlrcS6sboFmbGBcz4On8MmPmSL7ugFt7+mOwpw0c2XOWXeDLhtK CglqSM5O5qLcoPa1Jd9xqjSVczanD/pzNkXXBOzcJcWWYEToI7NSXMFgP+wnP2aJ561G MKD1U+b4cqhksNeSoJGh1La8Hc3f1rCDATr6/s2aJX1hhwxECRn+KxseBcVkN/nr2AXU vX/VNm+BkPWTMkdC/oDeWKaCjtZMJxq+ZIBqvFjj5BNz3uZDxMK6BtLoUVNuQLV7KE52 AQ1g==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782340909; x=1782945709; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WJs/bqJV28nRmEFkkVv0HdnYQ72Ru/Q9zWNCjXeVDns=; b=DEwKlsvCinJuFjIjF+71iBf4LBKFUneOinYk6iPGZZ+3qekkSh6J2bvkc9cqLps/pc 84X0iJMKaRZYngnf7I2ApWUMQknHbuRWTFIJPBqUAXuubcHvniQwuy9IIR8Y3pafDwlN eSZcj7OzuxmLIrgQDNhuvWT2RCDQQFdIb7CY7gpnV/7HfFIkX06vrXWqjGBCky6HLMz5 UndAahnDoUXQKesah6Q/jUqOg0DbnG971Iqyei53DMvmR5jrYLBbKv75BjTDWZZcNw3G GJUo1q2lyfwY8k/dndqdi2spHPY9n0HL6jXGclKdAXG90e5CFuJcDkuiNGvaobVCchIu CKpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782340909; x=1782945709; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WJs/bqJV28nRmEFkkVv0HdnYQ72Ru/Q9zWNCjXeVDns=; b=I6vr9178mrubKwUWKPYNS4mdNsrZWShedar51Uk1pfQsMIZVuowDCcCGpYy/J4w/4M fIUMvYOXdx+/h1tev6MNkIEZKXYNvMe50+yH3ORK0qTNgzLHMcupbt83v8qbH91nc+90 6clyszkISlyytLQ801WhDj4KcWjFPJIJK7tsabExUjehHt4Ywa/aMdy//aJxQL8uWDVi yS/fL6GmcsCMotK1AKdcsJkR8D1+/DUW5dmUa7oK7hG7+VAH2clxVj2qwqz3EvlV7SwC M6d4/ZoOSMgatFCbMlyjJA2f4lpY1Z/fQyGIMubSNyZQsEjo4sM6xY4Xh9B7mDjYhSh2 fyZw== X-Forwarded-Encrypted: i=1; AFNElJ9uns6BZJULVRgNEvcU++fnFPUXBx1YkbkhmnBaeoZt7B1VvxVp4tlzdgno5EGmu1Jhz0u5YzbqkQmyxzw=@vger.kernel.org X-Gm-Message-State: AOJu0YxoEzbIJnoHmqzYjFT1VbFgW3W594h5UHzU0cclXW/qXV1VxD4X 6TZJxzSdWv4GvQJ5xzTFnl7jgT/L736YswAQZojooSVFni9a9S44BdpmLpG89PxawlcV0LZDpos GXYMvWU782lb1Y7uuU83RA5o/5Dhv4IA= X-Gm-Gg: AfdE7cn1uA5DXWoTT4o7eAxTy/KCdmqtz7zGuLjk/zOmAXhXKn4m/KkGDLNaFimENNi oUYvjMGQyWeR29UNzUqgWbMWbE1kaic40DUWIWVZOVVuIuH9AL+YACzEy6OPQSQ8EzUEqj3E9NI 1dIg4RuO04N1QYTw4f/cox/LJ9EEWaK8cIyAqyDq60M+ieaNJBHugGxkxzyKDytuKKWe4k40bwD Itr5EPJFwmyNNzzoVMg20snyneCj1XRZWyGV4X/Lzyey2nToYDzyec442btHzijgP8NX4LrRaFQ hCT7/+Ocu82f5hv5XcDjcfFqC0SV9iQhoh5Nbb2k9AEXG47j9KQF59I= X-Received: by 2002:a05:600c:2256:b0:492:5cb2:aa54 with SMTP id 5b1f17b1804b1-4926087ba9fmr54723185e9.34.1782340909046; Wed, 24 Jun 2026 15:41:49 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260612193738.2183968-1-nphamcs@gmail.com> <20260612193738.2183968-3-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Wed, 24 Jun 2026 15:41:36 -0700 X-Gm-Features: AVVi8CcLr7H4jR5RtejdKP7Hpj9u7s-tS31S_dqbqyaFggMebkaysX3HiNPrzN4 Message-ID: Subject: Re: [RFC PATCH v2 2/7] mm, swap: support zswap and zeroswap as vswap backends To: Yosry Ahmed Cc: akpm@linux-foundation.org, chrisl@kernel.org, kasong@tencent.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, david@kernel.org, muchun.song@linux.dev, shikemeng@huaweicloud.com, baoquan.he@linux.dev, baohua@kernel.org, youngjun.park@lge.com, chengming.zhou@linux.dev, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, qi.zheng@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, riel@surriel.com, gourry@gourry.net, haowenchao22@gmail.com, kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jun 22, 2026 at 5:18=E2=80=AFPM Yosry Ahmed wrot= e: > > [..] > > @@ -1623,16 +1642,14 @@ int zswap_load(struct folio *folio) > > if (entry->objcg) > > count_objcg_events(entry->objcg, ZSWPIN, 1); > > > > - /* > > - * We are reading into the swapcache, invalidate zswap entry. > > - * The swapcache is the authoritative owner of the page and > > - * its mappings, and the pressure that results from having two > > - * in-memory copies outweighs any benefits of caching the > > - * compression work. > > - */ > > Forgot to ask, is dropping this comment intentional? Ooops. Lemme restore it. > > > folio_mark_dirty(folio); > > - xa_erase(tree, offset); > > - zswap_entry_free(entry); > > + > > + if (swap_is_vswap(si)) { > > + folio_release_vswap_backing(folio); > > + } else { > > + xa_erase(swap_zswap_tree(swp), swp_offset(swp)); > > + zswap_entry_free(entry); > > + } > > > > folio_unlock(folio); > > return 0; > > -- > > 2.53.0-Meta > >