From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751590AbdEaQX5 (ORCPT ); Wed, 31 May 2017 12:23:57 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:33788 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbdEaQXr (ORCPT ); Wed, 31 May 2017 12:23:47 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:5640:0:960b:2678:e223:c1c6] In-Reply-To: <20170531.110833.1362264472730468352.davem@davemloft.net> References: <20170531.110833.1362264472730468352.davem@davemloft.net> From: Daniel Vetter Date: Wed, 31 May 2017 18:23:41 +0200 Message-ID: Subject: Re: [PULL] topic/e1000e-fix To: David Miller Cc: "airlied@gmail.com" , intel-gfx , dri-devel , "Nikula, Jani" , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2017 at 5:08 PM, David Miller wrote: > From: Daniel Vetter > Date: Wed, 31 May 2017 08:10:45 +0200 > >> On Wed, May 31, 2017 at 7:54 AM, Daniel Vetter wrote: >>> On Wed, May 31, 2017 at 1:06 AM, Dave Airlie wrote: >>>> On 31 May 2017 at 08:10, David Miller wrote: >>>>> From: Daniel Vetter >>>>> Date: Tue, 30 May 2017 22:15:42 +0200 >>>>> >>>>>> If the e1000e maintainer wants to coalesce or not return statements >>>>>> this simple way, that's imo on him to change the color as needed. >>>>> >>>>> That's not how things work. >>>>> >>>>> If the maintainer wants you to style things a certain way, either you >>>>> do it that way or your patch isn't accepted. >>> >>> Consider this pull a regression report, pls handle it. >> >> And I guess I pile of more cc, to make this regression report >> complete. I mean you got the backtrace, bisect and a proposed fix, and >> the almost-whitespace change demanded is something gcc does in its >> sleep. I'd understand a request to retest if it would be a real >> functional change, but in this situation I have no idea why this >> regression just can't be fixed already. > > And we can't understand why respinning with the requested change is > less work than making several postings such as this one. I guess next time around we should do even less, i.e. report the regression + bisect and then escalate this until the netdev folks fix it on their own? Like Jani said every -rc1 a pile of our CI machines keel over, and unfortunately this patch here isn't the only one which seems to not really move anywhere. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch