From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9273C47404 for ; Mon, 7 Oct 2019 06:28:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB3A92067B for ; Mon, 7 Oct 2019 06:28:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="d5LjPYjP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbfJGG2x (ORCPT ); Mon, 7 Oct 2019 02:28:53 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:36908 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726969AbfJGG2w (ORCPT ); Mon, 7 Oct 2019 02:28:52 -0400 Received: by mail-io1-f65.google.com with SMTP id b19so26111776iob.4 for ; Sun, 06 Oct 2019 23:28:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F+oN7OhnQuDvPSd+hXHX3nHOZPOSv2CcWvqNvOXGack=; b=d5LjPYjP+oNF04YEV5GbXFOT9tv6SH9ye5Tbl6yGeP0zjdpS+DlWNLTBe0M/MDPXqU R0F1KG0AnpPuAqsEq4RR2+ddYspdUw5CZKPJfJEKsF68KIA4nvRK1nEGQz2nmeqlXNBJ 4S2D7ehGpwiiCuqug+J03fCCb1b3fpOvFcSIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F+oN7OhnQuDvPSd+hXHX3nHOZPOSv2CcWvqNvOXGack=; b=RZmQ8Vu1iDoO2HfrFNer4t3EReQbxs5mM3xPWgZY5h0AYiRBunW2D46BROVSfHug2B zV2n9zEsE2J0O0OVFmRC4XJKWAWvSsPzPgZCmarA0rJrMkSYh85Ft1BeGPb0slBC5O03 7icmWsTU5OV+vR0yi2zzwQeM6kaZcp6rnN+rVAj/mT2ufemx4iI92IbD/6Rop7VTCERc lS5ogMXyNpGDAiVTVaVqTeEUGJIdQa3qEcOdEsdgjMNSFPeoQq35r0g1/Igp1RZhq3vc FwvOqsfEWyrQAysgY7XSoPMQ742euJ4/9XGM0FKCeWBv+Tve8gPLp8URM3FblEE+nzVS 67kw== X-Gm-Message-State: APjAAAXKQ2KkTY8h/ramjdsZ4W7hOGABkuMZF+RhGImPH0gD1oRvyyxQ 6gZVzA1Td4fXj4kJ9V/Trh7B3EQBpmBFS5IiPodZjw== X-Google-Smtp-Source: APXvYqyKVIPCD1bpT+A3W2k0M7W9D8lrhhjDLqSK6n+0PrJuZ2ksgWc+AfWhMWKW5xHnyCK35m4ZP3jAL3uh28nm/TQ= X-Received: by 2002:a92:d847:: with SMTP id h7mr10737243ilq.85.1570429731325; Sun, 06 Oct 2019 23:28:51 -0700 (PDT) MIME-Version: 1.0 References: <20191006172016.873463083@linuxfoundation.org> <20191006172018.480360174@linuxfoundation.org> <20191006173202.GA832@sol.localdomain> <20191006182433.GA217738@kroah.com> In-Reply-To: <20191006182433.GA217738@kroah.com> From: Mattias Nissler Date: Sun, 6 Oct 2019 23:28:40 -0700 Message-ID: Subject: Re: [PATCH 4.9 30/47] ANDROID: binder: remove waitqueue when thread exits. To: Greg Kroah-Hartman Cc: Todd Kjos , Martijn Coenen , linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (resend, apologies for accidental HTML reply) On Sun, Oct 6, 2019 at 11:24 AM Greg Kroah-Hartman wrote: > > On Sun, Oct 06, 2019 at 10:32:02AM -0700, Eric Biggers wrote: > > On Sun, Oct 06, 2019 at 07:21:17PM +0200, Greg Kroah-Hartman wrote: > > > From: Martijn Coenen > > > > > > commit f5cb779ba16334b45ba8946d6bfa6d9834d1527f upstream. > > > > > > binder_poll() passes the thread->wait waitqueue that > > > can be slept on for work. When a thread that uses > > > epoll explicitly exits using BINDER_THREAD_EXIT, > > > the waitqueue is freed, but it is never removed > > > from the corresponding epoll data structure. When > > > the process subsequently exits, the epoll cleanup > > > code tries to access the waitlist, which results in > > > a use-after-free. > > > > > > Prevent this by using POLLFREE when the thread exits. > > > > > > Signed-off-by: Martijn Coenen > > > Reported-by: syzbot > > > Cc: stable # 4.14 > > > [backport BINDER_LOOPER_STATE_POLL logic as well] > > > Signed-off-by: Mattias Nissler > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > drivers/android/binder.c | 17 ++++++++++++++++- > > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > > > --- a/drivers/android/binder.c > > > +++ b/drivers/android/binder.c > > > @@ -334,7 +334,8 @@ enum { > > > BINDER_LOOPER_STATE_EXITED = 0x04, > > > BINDER_LOOPER_STATE_INVALID = 0x08, > > > BINDER_LOOPER_STATE_WAITING = 0x10, > > > - BINDER_LOOPER_STATE_NEED_RETURN = 0x20 > > > + BINDER_LOOPER_STATE_NEED_RETURN = 0x20, > > > + BINDER_LOOPER_STATE_POLL = 0x40, > > > }; > > > > > > struct binder_thread { > > > @@ -2628,6 +2629,18 @@ static int binder_free_thread(struct bin > > > } else > > > BUG(); > > > } > > > + > > > + /* > > > + * If this thread used poll, make sure we remove the waitqueue > > > + * from any epoll data structures holding it with POLLFREE. > > > + * waitqueue_active() is safe to use here because we're holding > > > + * the inner lock. > > > + */ > > > + if ((thread->looper & BINDER_LOOPER_STATE_POLL) && > > > + waitqueue_active(&thread->wait)) { > > > + wake_up_poll(&thread->wait, POLLHUP | POLLFREE); > > > + } > > > + > > > if (send_reply) > > > binder_send_failed_reply(send_reply, BR_DEAD_REPLY); > > > binder_release_work(&thread->todo); > > > @@ -2651,6 +2664,8 @@ static unsigned int binder_poll(struct f > > > return POLLERR; > > > } > > > > > > + thread->looper |= BINDER_LOOPER_STATE_POLL; > > > + > > > wait_for_proc_work = thread->transaction_stack == NULL && > > > list_empty(&thread->todo) && thread->return_error == BR_OK; > > > > > > > Are you sure this backport is correct, given that in 4.9, binder_poll() > > sometimes uses proc->wait instead of thread->wait?: Jann's PoC calls the BINDER_THREAD_EXIT ioctl to free the binder_thread which will then cause the UAF, and this is cut off by the patch. IIUC, you are worried about a similar AUF on the proc->wait access. I am not 100% sure, but I think the binder_proc lifetime matches the corresponding struct file instance, so it shouldn't be possible to get the binder_proc deallocated while still being able to access it via filp->private_data. > > > > wait_for_proc_work = thread->transaction_stack == NULL && > > list_empty(&thread->todo) && thread->return_error == BR_OK; > > > > binder_unlock(__func__); > > > > if (wait_for_proc_work) { > > if (binder_has_proc_work(proc, thread)) > > return POLLIN; > > poll_wait(filp, &proc->wait, wait); > > if (binder_has_proc_work(proc, thread)) > > return POLLIN; > > } else { > > if (binder_has_thread_work(thread)) > > return POLLIN; > > poll_wait(filp, &thread->wait, wait); > > if (binder_has_thread_work(thread)) > > return POLLIN; > > } > > return 0; > > I _think_ the backport is correct, and I know someone has verified that > the 4.4.y backport works properly and I don't see much difference here > from that version. > > But I will defer to Todd and Martijn here, as they know this code _WAY_ > better than I do. The codebase has changed a lot from 4.9.y to 4.14.y > so it makes it hard to do equal comparisons simply. > > Todd and Martijn, thoughts? > > thanks, > > greg k-h