mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namjae Jeon <linkinjeon@kernel.org>
To: Daniel Yang <danielyangkang@gmail.com>
Cc: viro@zeniv.linux.org.uk, Sungjong Seo <sj1557.seo@samsung.com>,
	 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	 syzbot+e1c69cadec0f1a078e3d@syzkaller.appspotmail.com
Subject: Re: [PATCH v3] fs/exfat: resolve memory leak from exfat_create_upcase_table()
Date: Tue, 17 Sep 2024 15:40:38 +0900	[thread overview]
Message-ID: <CAKYAXd-__5jnU3znV5qR1SVNaogqAbR-eQW2V_+LsbeVWRb50A@mail.gmail.com> (raw)
In-Reply-To: <20240916230506.232137-1-danielyangkang@gmail.com>

On Tue, Sep 17, 2024 at 8:05 AM Daniel Yang <danielyangkang@gmail.com> wrote:
>
>     If exfat_load_upcase_table reaches end and returns -EINVAL,
>     allocated memory doesn't get freed and while
>     exfat_load_default_upcase_table allocates more memory, leading to a
>     memory leak.
>
>     Here's link to syzkaller crash report illustrating this issue:
>     https://syzkaller.appspot.com/text?tag=CrashReport&x=1406c201980000
>
> Signed-off-by: Daniel Yang <danielyangkang@gmail.com>
> Reported-by: syzbot+e1c69cadec0f1a078e3d@syzkaller.appspotmail.com
> ---
> V2 -> V3: free(NULL) is no-op, removed if() check
> V1 -> V2: Moved the mem free to create_upcase_table
Applied it to #dev now.
Thanks for your work!

      reply	other threads:[~2024-09-17  6:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16 23:05 Daniel Yang
2024-09-17  6:40 ` Namjae Jeon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKYAXd-__5jnU3znV5qR1SVNaogqAbR-eQW2V_+LsbeVWRb50A@mail.gmail.com \
    --to=linkinjeon@kernel.org \
    --cc=danielyangkang@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj1557.seo@samsung.com \
    --cc=syzbot+e1c69cadec0f1a078e3d@syzkaller.appspotmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®