From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933571AbcI1R1q (ORCPT ); Wed, 28 Sep 2016 13:27:46 -0400 Received: from mail-vk0-f66.google.com ([209.85.213.66]:35193 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932977AbcI1R1o (ORCPT ); Wed, 28 Sep 2016 13:27:44 -0400 MIME-Version: 1.0 In-Reply-To: <1475081961-3858-3-git-send-email-moritz.fischer@ettus.com> References: <1475081961-3858-1-git-send-email-moritz.fischer@ettus.com> <1475081961-3858-3-git-send-email-moritz.fischer@ettus.com> From: Dmitry Torokhov Date: Wed, 28 Sep 2016 10:27:43 -0700 Message-ID: Subject: Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi To: Moritz Fischer Cc: lkml , Rob Herring , Mark Rutland , Lee Jones , =?UTF-8?Q?Emilio_L=C3=B3pez?= , Javier Martinez Canillas , Thierry Reding , Shawn Guo , Jarkko Sakkinen , antonynpavlov@gmail.com, "devicetree@vger.kernel.org" , moritz.fischer.private@gmail.com, julia@ni.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2016 at 9:59 AM, Moritz Fischer wrote: > Add compatible string for NI version of cros-ec-spi. > > Signed-off-by: Moritz Fischer > --- > drivers/mfd/cros_ec_spi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c > index ebe9b94..e4504ec 100644 > --- a/drivers/mfd/cros_ec_spi.c > +++ b/drivers/mfd/cros_ec_spi.c > @@ -708,6 +708,7 @@ static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend, > cros_ec_spi_resume); > > static const struct of_device_id cros_ec_spi_of_match[] = { > + { .compatible = "ni,cros-ec-spi", }, I am confused: if the 2 controllers are the same, why do we need the new compat string, at least in the driver? Shouldn't DTS simply use "google,cros-ec-spi", or maybe both (compatible = "ni,cros-ec-spi", "google,cros-ec-spi")? DT folks, is there clear instructions somewhere as to when introduction of new compatible is warranted, along with the rules of how to settle on common fallback (i.e. how to make sure that, let's say, Linux, U-boot and FreeBSD use the same fallback compatible for the same series of devices)? > { .compatible = "google,cros-ec-spi", }, > { /* sentinel */ }, > }; > -- > 2.7.4 > Thanks. -- Dmitry