From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BC8A3612F9 for ; Mon, 23 Feb 2026 10:57:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.218.45 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771844251; cv=pass; b=Hnb2ipTPR6qaj/dADKPJ6kA2AnfmLtiJ8iI0jDY5XNxJc1NGkC6frWz7eXuUxaRBWf/iA6p5atM6KYgZvvnigP93wN0sMt9m1akONInNZiOaHGlhWcUnn233nocDitIxzcWrW1KRL4pBVKbyQLy/fRbI9J+V7Li2Dur/t9qmadY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771844251; c=relaxed/simple; bh=F9E21MB6sec+AffdeS7t/nnRAJnwtH5kBhNkQ8m6Ix4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=pIFMJFFQDSbAzFoNdKz2oR4R4KVecC+SK8JMAxR8nvLBoEhD9VJ2uvnsFy9VVW8VyufjoZqqpedXOepcpN+fRKduJiF13kKvdriXg43/yVb8WtyWjk2gnx2M/gEb6o0oidLEA2eoEHT1mNRZT19rYJJcNbDYLrr3dwY0py7Muvc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Alcnbyws; arc=pass smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Alcnbyws" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b8f96f6956aso571728766b.3 for ; Mon, 23 Feb 2026 02:57:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771844248; cv=none; d=google.com; s=arc-20240605; b=HZXd+n0Klpk6f49lLmDo+1SDi6fuEtYin8nxBDY8Opy4evZy/Red305P+PhR8i+GjT j3/IF4EQomtlZCJVa/J4Jd6owzpEpuTLnaKWJjBHWzvfm2mMogmapV5msGTkKzGcMVDE Ik8BsNID/9b9B5NHzvtYwfC7zjRgRg3kDJcBdNnHLWXkBrIeHM+3jqjZUQsGf+3CGIp6 Hkq0X7VKBLwBsKQAmdGGdi2QGlXePWaOZ4LxJWi3oHe/vV9Q3x4ajn7CxhB9R2/yKf1o DGTMZbDxad13WTGUXF2hfBe0reDyTNL7g1y+cGIPcbSY3q8yB0iLX0dElFARliSi6zBY 9/hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=Dz28Xw2vs9es4H7ypSJUNnvIndgAyYUTlC2He+clxcc=; fh=Le14BW50UbSrKFMuap8dOAxtY/8LmSLiVbui+NvVpXA=; b=X6su5zxT6kqMIwtnoYXg8/6irUyF0YkuqH/BusuMyATDDtG5XSg+3J6bY3F11UzY4u n9o0R/65Cuoo2Seu/S91HPfyJ3cJ+dlJS+5kvmoqMK+1W4eckzamo/GZTs5dA8SO3OlL 4dUpOSzfNhn16vBreyqCxBR+MENdAUXUjm54UVVxCleBla9iZ7cy6ukGhYE8ExkkgDoW vk/E3daRdwknKqS40MwbfS4gCBJLESNvBabcAtMFMYpnskMIGWn6RnrH5WhB73f7dMgV j08vWYZAJppsJCEwpD8PEysN44v+tyFpBUCckLeSICn5Mgy1kW5SY/UC09pavvB6q/Ps Txcg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771844248; x=1772449048; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Dz28Xw2vs9es4H7ypSJUNnvIndgAyYUTlC2He+clxcc=; b=AlcnbywsEklLp/hoNthf2qGCiisVyUkQHAqve8oY1/9SeStmAxa88sZ/8+rnIsymdj OOTJEhwVSlzn5OJsFZJECWn3aKtVj75tqOfykrbxQqj+edRIgDSUG6gBSbfgh3HI7HLP 6sjHSpvdgMFGtuNAA/U04E63YTbUiiv1BtDG8cuZMxSxqfRzcQXY4ueomQ0kdeNYWJkE ivblWWRg6DA+V8Rv+FLEoJ55KOjChGzIhH07HOE5CHsEGiIRFukKmAkw7uvgPIlg4cX7 ihnHcPGz+wDz+KWFHXdnT6RDiUqZCC2d2KFUscOyZ9xaIofgkea2Qh23cKKSs9312M6Y QA1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771844248; x=1772449048; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dz28Xw2vs9es4H7ypSJUNnvIndgAyYUTlC2He+clxcc=; b=nDPAgdJTB2/6CPjGlxe+qaD4HFFVWkCeNw94zdOnMWNofMSpn6TgpPdABbrN6MXPNi Mw3eVaVcMYSYhtpHNZiNQ9gjP58Q1PJhRu7ZJY8JkIgF/IRL7KBrDpIUuVO1KvDfmabM 197oOdFIALxXX8nsg/7nvFFkWXbF9t0XTwdKTs3o3WiBZaZGES2QSS0uagclBhlCz4oN z9K4eEfu/W+35yp826SVpCVidnCA6ejyz2xYAHp8AfUVeTNOgic502jpJkpmRKSr2/fX k8UhmGPlCz4lNUfQJN7mPvY46Z1umzyOef3uypOqIBthaOw2ZIQCsQAEjSVvBjwYc9w8 LXEA== X-Forwarded-Encrypted: i=1; AJvYcCXPNJsNENc1+W9xxUAqO/JcxoudTk63O+3GRYJs/T7JdWjYKljzW1mWwk0uyzrfORsMfq5GZmtBvoB3E5Q=@vger.kernel.org X-Gm-Message-State: AOJu0Ywjqac7OrCx0yjcgR+bLlNwEy5pd5eaZP5rsNYWPuTfXPCO5XgV BdhcKEW7mz928qAd3EfHY/o8r7zk/+qIkpfZg2liwbKKM5It+a+dBDAsXAR1ekPtplNKTP14ubS LEkSA/W4TR6v2trtbV6GQwKmH8tvNrTV3vSqa0z4AMw== X-Gm-Gg: AZuq6aIzKe15WXyrc4yCtiaY+qGkC6u23XiRv+FgltzLtPaDVWeZfDtjuns0Q3QyC+z nRoWh5AxYi46RGXJCn0n/CVrcGm5LE9KIeHFLQDvLJZsQCfjNfr575jUtKhfLr313XjcKvxN2z1 N+Abix4p67w2OTvS2F5lbih76PlbX3BXT216lsM6rjeV9Id9nbkXCVomTfE2BCnnIQfhW6n03VI qfPPTPPjzvj16/7Q4nwreqkcXfX42Qno7/O0Ro1mc3nNKgGMrnGs9UnZSjfIutgcvv+O1w6FBwR dfG7Aw8BffWoQnRITP06d9Tc0us3XrHeZFU3 X-Received: by 2002:a17:907:c12:b0:b88:4c99:bc0e with SMTP id a640c23a62f3a-b9081a01b8bmr436762866b.26.1771844247708; Mon, 23 Feb 2026 02:57:27 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260219075840.162631716@infradead.org> <20260219080625.183283814@infradead.org> In-Reply-To: <20260219080625.183283814@infradead.org> From: Vincent Guittot Date: Mon, 23 Feb 2026 11:57:16 +0100 X-Gm-Features: AaiRm53YoO7eUTmvZaJ8Zc6U7Q0MRY2z8zSAdmGVgxBOgMaeouGhWz8qSvOQL0o Message-ID: Subject: Re: [PATCH v2 7/7] sched/fair: Use full weight to __calc_delta() To: Peter Zijlstra Cc: mingo@kernel.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, wangtao554@huawei.com, quzicheng@huawei.com, kprateek.nayak@amd.com, dsmythies@telus.net, shubhang@os.amperecomputing.com Content-Type: text/plain; charset="UTF-8" On Thu, 19 Feb 2026 at 09:10, Peter Zijlstra wrote: > > Since we now use the full weight for avg_vruntime(), also make > __calc_delta() use the full value. > > Since weight is effectively NICE_0_LOAD, this is 20 bits on 64bit. > This leaves 44 bits for delta_exec, which is ~16k seconds, way longer > than any one tick would ever be, so no worry about overflow. > > Signed-off-by: Peter Zijlstra (Intel) > Tested-by: K Prateek Nayak > Tested-by: Shubhang Kaushik Reviewed-by: Vincent Guittot > --- > kernel/sched/fair.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -225,6 +225,7 @@ void __init sched_init_granularity(void) > update_sysctl(); > } > > +#ifndef CONFIG_64BIT > #define WMULT_CONST (~0U) > #define WMULT_SHIFT 32 > > @@ -283,6 +284,12 @@ static u64 __calc_delta(u64 delta_exec, > > return mul_u64_u32_shr(delta_exec, fact, shift); > } > +#else > +static u64 __calc_delta(u64 delta_exec, unsigned long weight, struct load_weight *lw) > +{ > + return (delta_exec * weight) / lw->weight; > +} > +#endif > > /* > * delta /= w > >