From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751657AbdCAB6m (ORCPT ); Tue, 28 Feb 2017 20:58:42 -0500 Received: from mail-ua0-f175.google.com ([209.85.217.175]:33726 "EHLO mail-ua0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbdCAB6k (ORCPT ); Tue, 28 Feb 2017 20:58:40 -0500 MIME-Version: 1.0 In-Reply-To: <20170228170855.8123-1-alban.bedel@avionic-design.de> References: <20170228170855.8123-1-alban.bedel@avionic-design.de> From: Iyappan Subramanian Date: Tue, 28 Feb 2017 16:58:06 -0800 Message-ID: Subject: Re: [PATCH] drivers: net: xgene: Fix crash on DT systems To: Alban Bedel Cc: netdev , Keyur Chudgar , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 9:08 AM, Alban Bedel wrote: > On DT systems the driver require a clock, but the probe just print a > warning and continue, leading to a crash when resetting the device. > To fix this crash and properly handle probe deferals only ignore the > missing clock if DT isn't used or if the clock doesn't exist. > > Signed-off-by: Alban Bedel > --- > drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > index d0d0d12b531f..68b48edc5921 100644 > --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > @@ -1756,6 +1756,12 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) > > pdata->clk = devm_clk_get(&pdev->dev, NULL); > if (IS_ERR(pdata->clk)) { > + /* Abort if the clock is defined but couldn't be retrived. > + * Always abort if the clock is missing on DT system as > + * the driver can't cope with this case. > + */ > + if (PTR_ERR(pdata->clk) != -ENOENT || dev->of_node) > + return PTR_ERR(pdata->clk); > /* Firmware may have set up the clock already. */ > dev_info(dev, "clocks have been setup already\n"); > } > -- > 2.11.0 > Thanks, Alban. Acked-by: Iyappan Subramanian