mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christopher Griffin <christophergriffin05@gmail.com>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Cc: loic.poulain@oss.qualcomm.com, jjohnson@kernel.org,
	kvalo@kernel.org,  quic_haric@quicinc.com,
	quic_vnaralas@quicinc.com, quic_pradeepc@quicinc.com,
	 linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	 linux-kernel@vger.kernel.org, quic_mkenna@quicinc.com,
	john@phrozen.org,  ath10k@lists.infradead.org
Subject: Re: [PATCH 3/3] wifi: ath10k: don't arm the scan timeout for a scan that did not start
Date: Thu, 19 Nov 2026 09:10:25 -0600	[thread overview]
Message-ID: <CAKobHXCUawNNtyLn-n9-qXV3F_q9drWXeG28bY5ARiiTLzXO2Q@mail.gmail.com> (raw)
In-Reply-To: <b879a6b0-4ca3-4937-8bb0-ee3586d60c1b@oss.qualcomm.com>

On 11/5/2026 5:47 PM, Jeff Johnson wrote:
> Please don't send HTML e-mail.
>
> Note your reply was not archived or sent to the mailing list because it was
> HTML. I only received it since I was directly addressed.

Sorry, Jeff, and sorry for the duplicate: my last resend went out as
HTML again. Plain text this time so it lands on the list.

On Thu, Nov 5, 2026 at 9:53 PM Loic Poulain
<loic.poulain@oss.qualcomm.com> wrote:
> It looks more like a theoretical issue than something that is likely
> to occur in practice, but the fix looks good to me.
>
> Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>

Thanks for the review, Loic.

We did hit it on ath11k, and it did damage: on a QCN9074, a firmware
crash failed a scan start with -110, the timeout was armed anyway, and
it fired after the dead radio had been unbound, ending in "cannot queue
ath11k_scan_timeout_work on wq" with a garbage workqueue, and a panic
(that is patch 2/3).

Whether ath10k ever hits it I don't know, but the code is the same, so
the fix can't hurt.

Christopher Griffin

      reply	other threads:[~2026-11-19 15:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 18:11 [PATCH 0/3] wifi: ath10k/ath11k: firmware recovery deadlock and stale scan timeouts Christopher Griffin via B4 Relay
2026-11-05 18:11 ` [PATCH 1/3] wifi: ath11k: don't hold conf_mutex while waiting for recovery Christopher Griffin via B4 Relay
2026-11-05 18:11 ` [PATCH 2/3] wifi: ath11k: don't arm the scan timeout for a scan that did not start Christopher Griffin via B4 Relay
2026-11-05 18:11 ` [PATCH 3/3] wifi: ath10k: " Christopher Griffin via B4 Relay
2026-11-05 20:53   ` Loic Poulain
     [not found]     ` <CAKobHXCMwjAHJOkibPbpDByLZmAKkszZ3WaG6soSDaCEGRQjgA@mail.gmail.com>
2026-11-06  1:47       ` Jeff Johnson
2026-11-19 15:10         ` Christopher Griffin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKobHXCUawNNtyLn-n9-qXV3F_q9drWXeG28bY5ARiiTLzXO2Q@mail.gmail.com \
    --to=christophergriffin05@gmail.com \
    --cc=ath10k@lists.infradead.org \
    --cc=ath11k@lists.infradead.org \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=jjohnson@kernel.org \
    --cc=john@phrozen.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=quic_haric@quicinc.com \
    --cc=quic_mkenna@quicinc.com \
    --cc=quic_pradeepc@quicinc.com \
    --cc=quic_vnaralas@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®