From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932802AbcASSSW (ORCPT ); Tue, 19 Jan 2016 13:18:22 -0500 Received: from mail-ig0-f178.google.com ([209.85.213.178]:36057 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932371AbcASSSN (ORCPT ); Tue, 19 Jan 2016 13:18:13 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 19 Jan 2016 11:18:12 -0700 Message-ID: Subject: Re: question about samsung/sxgbe/sxgbe_xpcs.c From: Shuah Khan To: Julia Lawall Cc: bh74.an@samsung.com, ks.giri@samsung.com, vipul.pandya@samsung.com, netdev@vger.kernel.org, LKML , shuahkh@osg.samsung.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-01-19 9:26 GMT-07:00 Julia Lawall : > Hello, > > I was windering what is the purpose of the file > drivers/net/ethernet/samsung/sxgbe/sxgbe_xpcs.c >>From git log and comments, it appears this driver is for Samsung SoCs. > > I can't find anything that refers to it, and if I remove it from the > makefile: > > @@ -1,4 +1,4 @@ > obj-$(CONFIG_SXGBE_ETH) += samsung-sxgbe.o > samsung-sxgbe-objs:= sxgbe_platform.o sxgbe_main.o sxgbe_desc.o \ > sxgbe_dma.o sxgbe_core.o sxgbe_mtl.o sxgbe_mdio.o \ > - sxgbe_ethtool.o sxgbe_xpcs.o $(samsung-sxgbe-y) > + sxgbe_ethtool.o $(samsung-sxgbe-y) > > and then make clean and recompile, I see no bad effect. > What is the motivation for the experiment to remove it? This file probably gets used only on Samsung SoCs. thanks, -- Shuah