From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f46.google.com (mail-yx1-f46.google.com [74.125.224.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5803E224D6 for ; Sun, 7 Jun 2026 20:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.224.46 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780865573; cv=pass; b=Gb/XZNdasThvTH497MeS9PxjTTrhfF4bSGIeikbQm3RNg/YRil8fT/3uNn88Ax7gBV8K151rc3DIMsV6MqqtMy9//UdGYXAr2k4Hk3mWIFndprjJlFxFDRPAsHUK3RgcjsFIIDUqfquuWZWKna4nRh8WhftPyElyZuHiRcHtglo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780865573; c=relaxed/simple; bh=vZoC2XCI/DGhd8gJS4Xd5Yi0S1yL043KiJVCF6eOp30=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=EhiocbsRBLiayk9AQ7fFPssVwSWjandl/RqiskZ/28PyGhX4mAMJ14HnZUPhtCexjBLOdI7Fi2cwIWkPZ7I5Q5FZhA2Zw1BQVZ2dmNkwxPyeGQ8YHCo9n1VxIRrl78ZwVXGqW7iSqFuQQzoGnsf1zcP5QIKIagdtvMOeRxQf/OA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ov5Tv5mD; arc=pass smtp.client-ip=74.125.224.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ov5Tv5mD" Received: by mail-yx1-f46.google.com with SMTP id 956f58d0204a3-6607e80a846so3630285d50.2 for ; Sun, 07 Jun 2026 13:52:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780865571; cv=none; d=google.com; s=arc-20240605; b=D7a2gVhylNp1Af6OTM6PxCicKgcFkHYffImG6gjYgavSx4Sf/uWE/lVEnfgERp2lUZ NHMetIQpjQDjlDEaKTwqYMCMq9H9721QVf2OAx1xVsOHp1rS9PLPgnRazFJ3QYfvAMyO Plcjul1nkXGGA20YSBE0PuMOs6WesS9WdCBeuDhiExC9yhu3WkNISQgXrLkMAnZxa/+g 1OPJBvYO2qckToqewoNrjFwNc/gsofQqDOrpmw5wgOZTGhLTy6tJyrv8unPVjB5SEjS4 K8GxIvif0wG5GnLysJPdEW7AEsISTEhmzVSiRjzGnheAdt8vcUMWTMzphaaKMqBH0/3R j4Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=/81AVja23z3xt75X8Nbqrb+cC2JxCzobXTf0PeIKB6Q=; fh=2Tawc0rFOwVFVghDXeTx3r4asVuSrc80gsaPGStEuv8=; b=W62czZL9NmWlKSEvHOy2SXp2HQOKovb0iphrfSQmon3tc3VaLqj8Iwh+ejY2QXQD9Q LoX2VbV+G6PYFPxN5ip4IPD5fLFwp2/8Gpd07TOyw/APD4coFfrTwUSpSgFgzU6ruSd7 iRgy/X7UEVyj24Rx2EMq26IHIjItqE3cj4SsODhzc/6Ef776wHuB3V0nv2mxFV1cMHC/ sxSH9HkuHzGz50se1ITlps7Ky6sfDw0FP35SgKu7b94qnVP+xtc9+3dzSIYfrztgf7NV FG4WPTritlLLGoH9Srz6vSDcvgMGg2LMnA/wUS3NEqeWpXE8pETHBjOqSK+hrFt1qUmw 3tXg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780865571; x=1781470371; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/81AVja23z3xt75X8Nbqrb+cC2JxCzobXTf0PeIKB6Q=; b=ov5Tv5mDltavY3g13DSbbgKSMdBeT+YW9dQlBrCBKd5yLfAnQDhqXci3IFQrP9E87X 6Op9dvkx3Wgm1RiKM+QE2Z1ybTOMTS/gUsubszdxcFcfdxsjNKNKHRcj4YNgofdEOh5z yvDNcAoBnNbyGyFxTI326be3U0Qruk2PPLpalRK8OyHgV//XV+N64D/u9eYFffyG0Jqx 1IL7d+XcLm18PG8vNlEdhMpkxdFSLSjKwmGPWlLOElN6QSsj6AY9GDV/V+y7HP9+inOd 5EYyd4AgMxUHTpfe86YisfZPm5k++78d7a68CZSYEZMLFD4KIUSVbaETnf+yYsv6XZHQ mV/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780865571; x=1781470371; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/81AVja23z3xt75X8Nbqrb+cC2JxCzobXTf0PeIKB6Q=; b=GNHL109H/tOL0vkabLOvmnxsK5O1/VkXz27Q9H6KVfSnmoIWJ+WbL5nSd/AUxcwSFh xonBMhP8YgFTUf12SZkm5gwy9eaDPbrTeqdzfZIM6TbgONqK47oGNEbHWvdQOMhbSwl2 tjCb2Ak4IvILzF6bDYMMxHz+9LSuxGxUvxN0zeQF9s4fKWuOHwqVihhonKDqsJBp3BXJ ERIx1yVSFqZxlnNogDQq66ZwETmrVL/jeDou2T+0BAdSKv8AK4WMrz01xgyG+2Jlr7du vwZ69HaR0EJ1YZ4D+swJq3Rcn0U/I8NyVvEIiBvn0Za3vF/K8q6rS9sVzBh+G+cuGR8a rK4Q== X-Forwarded-Encrypted: i=1; AFNElJ9JMdmzU+Eqgspco23sOWd7exoQ0pTExkgv3Fvl5yO/LStXq5lvLvROo1HFNJCp//kAUFjqQNsor96tDds=@vger.kernel.org X-Gm-Message-State: AOJu0YxhJQQosUF4Rs52yIQPwYNkDhe4VI/65xOrIPMMtvUv91ELJMa+ p5ERVh190VYrWd9HlLDCHucw72tl6pcYCpSL007QcH7//7fkrFWqBezhEYLFjhvkSo1/FzNIVP9 31Ye5F/2TA34EE0k0VTQaqNpFw8pa2Nk= X-Gm-Gg: Acq92OHs/is2iwRZAAmjq5xwK7rtZzrH8qxOVTKyVDIDj+x45Zg4aC/sRFidh16Z+M6 KPLvQTPJPVL4TYtuQM1whoP/cC4OlT9zrSq09AVEQiMBdE3lewn9GzsjiBjNND0olINzEYoz0/R 8y1zHq4uX1IhAejgToNz7P3NNPP12NDixRfsZ1p6G5jqOQGkRW77FqaVIFiYvwh0mluQGSd4XFH xd8UY8wj+UBPw4CPy7erI9UgU6BKmkmFnq/9un0zXvLoXmV8RyIUsBYfWufUQ9KXaVDKhTobFeL IcQLg8Sa0FcNbW+a+zeuhiJrcw== X-Received: by 2002:a05:690e:134b:b0:660:ec14:ef87 with SMTP id 956f58d0204a3-66106f153cemr11077968d50.34.1780865571452; Sun, 07 Jun 2026 13:52:51 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260606-6-june-hid-iio-correct-usage-id-v1-0-dd4a6820b674@gmail.com> <20260606-6-june-hid-iio-correct-usage-id-v1-3-dd4a6820b674@gmail.com> In-Reply-To: <20260606-6-june-hid-iio-correct-usage-id-v1-3-dd4a6820b674@gmail.com> From: Maxwell Doose Date: Sun, 7 Jun 2026 15:50:50 -0500 X-Gm-Features: AVVi8CdYUyEsJBZuEZpF4d9hRqPKQN9LrFimrV9NNTgG4FyAsXCSjpDMM7bbtuc Message-ID: Subject: Re: [PATCH 3/7] iio: light: hid-sensor-als: use u32 instead of unsigned To: Sanjay Chitroda Cc: Jiri Kosina , Jonathan Cameron , Srinivas Pandruvada , David Lechner , =?UTF-8?B?TnVubyBTw6E=?= , Andy Shevchenko , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jun 6, 2026 at 7:19=E2=80=AFAM Sanjay Chitroda wrote: > > From: Sanjay Chitroda > > Prefer 'u32' instead of bare 'unsigned' variable to improve code > clarity and consistency with kernel style. > > Signed-off-by: Sanjay Chitroda > --- > drivers/iio/light/hid-sensor-als.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Do we *need* u32 though? Usually these types are for places where we require specific bit-widths for a reason (e.g., reading a hardware register) but I'm not sure that's the case here. I could be totally wrong, in that case please correct me but otherwise I unfortunately don't see much value in this. That's just my personal opinion though, Jonathan may think otherwise. --=20 best regards, max