From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE5C0C433E1 for ; Tue, 23 Mar 2021 20:29:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9A9D619D6 for ; Tue, 23 Mar 2021 20:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233244AbhCWU3I (ORCPT ); Tue, 23 Mar 2021 16:29:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232711AbhCWU2v (ORCPT ); Tue, 23 Mar 2021 16:28:51 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AAE3C061763 for ; Tue, 23 Mar 2021 13:28:51 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id a198so28579756lfd.7 for ; Tue, 23 Mar 2021 13:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1mJxXlJLpF04ktu0Td/MXe7AhNpm2832ClSG5vRPtkQ=; b=g14x6sHmde8J0uY1U3oJCCjEgEIi4Wfjc4hlvckQ9Y7hMPL3hUA0WflQVlbbc/fD87 2mdAvJNmOCibE4HxV1z+VFo0r1yBv7jpMSRJl24WKPQwaPNsqkmvkqWPhnB13+WP0L8q 0w0J1hOyd7n0Y7RvT0o4KG+hC+FOec0swWO+Mv/jSfPmbGCx2d8ohMXGbjockdbWwyZD HWgBLTPnvvN/4OKur/ilYV8k9nGyNbiPA/OO1Wjj/HVJEzjgPFl0EWYgJ1Jghy7m6zqa ZJLy//zRufxgTJftW9eGq+nM+Tpj+3Nb9CLSJ7ZqEX6MKgwcAUkIRFiwXay7RzPFxcJY yr6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1mJxXlJLpF04ktu0Td/MXe7AhNpm2832ClSG5vRPtkQ=; b=E6Ad7P3+PgACmVx7OYJxD+d/mSEEcDEFrnItVoWLd19vka2aki8voyTkMJJld1d52N 2FIWTO6jJ93Oa0athOpp2ag7RxruTyTkzrADDoCVMUtTFgsEireaMuTX8N9En79VcS3Z KvVgzeHqS+w+xiynaYWApuYXGki5d4nRAiEud6Yvu5hEqRodD5KNuUDKOXBy9mzu7235 yKP2dOy3MvO9L1MKcc2sgotg4JvQ1g4AMbaMV33fK0JgqWdeXfkE7t5P4Zo682znCzxW 1aIPXQekjVwvm5EmgZM1JNrduEVr51ZT5KwI3caqA3OEEmZrtQh/VJR/fdd9HWyCF4j0 iJXQ== X-Gm-Message-State: AOAM531plz1OlrJGwIrD53mJfGBcTxd8qoFBP/ZjWmMcLwNRjMSEeDbM RHhNPXLGsj9T0KGkeFRK5uGDsAykoLcY/ZWYrW3iGZ7sOiRjaQzr X-Google-Smtp-Source: ABdhPJxAIjxZyedPPhNLxAmmnwaQEK1JeosnTw6S70cLKAOWYHjeSxqBaG86+vQnbMjH/mn4kS4ZkIe07b7p2mInPmQ= X-Received: by 2002:ac2:538e:: with SMTP id g14mr3441936lfh.543.1616531329644; Tue, 23 Mar 2021 13:28:49 -0700 (PDT) MIME-Version: 1.0 References: <20210316213136.1866983-1-ndesaulniers@google.com> In-Reply-To: From: Nick Desaulniers Date: Tue, 23 Mar 2021 13:28:38 -0700 Message-ID: Subject: Re: [PATCH] scripts: stable: add script to validate backports To: Greg Kroah-Hartman Cc: Sasha Levin , clang-built-linux , LKML , "# 3.4.x" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 23, 2021 at 12:05 PM Greg Kroah-Hartman wrote: > > The only time git gets involved is when we do a -rc release or when we > do a "real" release, and then we use 'git quiltimport' on the whole > stack. > > Here's a script that I use (much too slow, I know), for checking this > type of thing and I try to remember to run it before every cycle of -rc > releases: > https://github.com/gregkh/commit_tree/blob/master/find_fixes_in_queue > > It's a hack, and picks up more things than is really needed, but I would > rather it error on that side than the other. Yes, my script is similar. Looks like yours also runs on a git tree. I noticed that id_fixed_in runs `git grep -l --threads=3 ` to find fixes; that's neat, I didn't know about `--threads=`. I tried it with ae46578b963f manually: $ git grep -l --threads=3 ae46578b963f $ Should it have found a7889c6320b9 and 773e0c402534? Perhaps `git log --grep=` should be used instead? I thought `git grep` only greps files in the archive, not commit history? -- Thanks, ~Nick Desaulniers