From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F2003C4557 for ; Sun, 16 Aug 2026 21:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.208.44 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786914722; cv=pass; b=pa76hIGwGwnCw98iZo6QVkUjNWAaAl8lZcuOAuy7JVm102sMIRL3gU97/dM8xy0JpPYK47Z2B8EYR2H5FX5gQdkZVJJE4GO4N46RmbcZ18VRHDekrMI28A7PGuk0XVO+8TP6GQv6fJsc7DDgBVnhD1B0xg1D42P9d03eRfvkpbs= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786914722; c=relaxed/simple; bh=tIoWNN4/QvawhYFMjLg4aiQbTxjSdS/iLQfDWoyarAY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=umqCK1lXNPSHV1XzfVfj2nvkus4xh/E3WMPsHZDmF5SUuDfEywyJD+TmlNfuW9EPhtr17pwb+RMRayKRmJc3CD1r7j8M6rsPVT4eUUz9Z1sTsBui8/3TIh9C9iSpctyl81yfBAI/fZRNMCwTKFhPTB9YRmbnbi3pux98DJZzo8g= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J3UC4jf3; arc=pass smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J3UC4jf3" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-6a17211b9ecso6055527a12.2 for ; Sun, 16 Aug 2026 14:12:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1786914719; cv=none; d=google.com; s=arc-20260327; b=VveuZClM+qt4/PFqQpWuej/1CFzmTSWYFfrNZ75WCyMe0Hmg88NNbF/qf1/w4KTTtp XZQK5HNUtQXHH07MPtmOwyvk6tslz++YVx69c5QNMAKbTmdYbGAkQE18U6CfOSedi/x7 4+e4NUd/Cka2CwWNluQYZQNO+ev9TvRG0iq7sNYwv9/wibBi+3Ixt8n5Y9MBgQsg2KN+ fStvnpw76xI/1sHxaC1owhTJqDlLKCoL+DCJ+Iz/HPL/S4O6KQ11nPw9TeKUZP+LXM0J pgZSTo9qBnr8Bsjup47yTzNhEQPmVWB9TBiNFHIFLO9Jr+L7E28Y2CwPY9tLFahuGaBC 8WlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=piGwFWwU9JIYJc8ZqfFGe2WuXLHUeUkmz9gwepBmbbw=; fh=5iNDQ8cKQI00EfmnzN9PXYVMCU/j3042uSe/+AwPuUI=; b=U77c51HuBQBjlMvJ2TcTir0s5O5pS3eduMHTpuZraAPSQK1rpusLYyB17TVqrt3ibd qpDrDpb5qQp6yUurIymqWApw8h1scUyRo9tFapU34sb9OLQrni0pOiwy6czFy0Rarz2h hCwvWoCOx88e7xHxSJZmAa5DZwjUQiSnZ/+sfYIz0kUu26CRuVUyvvS8XVx3rxY9igXq DQ479w3S1VycrHnbJ64cgQEz9Rm+kHnjzfHk11QpnCPGbJpM6GS+gSr3BRu1oJt5iYhs 3KjNUJC2xo4mGUyJlaNQQAHItrzF8Q0pciOdF7MMLefjPnz5XY080YAhR1sK3C3pFv4o h3xA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786914719; x=1787519519; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=piGwFWwU9JIYJc8ZqfFGe2WuXLHUeUkmz9gwepBmbbw=; b=J3UC4jf3dIW7nEICr3NSx8le9mZHcxHv+Urw3t+48RzVHzXjLtdSnyuEVfaR8jAmKt djgJ4o7q+YRA3+X+qp0InplznWiRx1pRP9vMhxESETJ7JEUq+CP7txISG7jVuyE8AXZr bNPfCcmdFji+gOB4Lq7tB9hurqXs2dlVgyGsmW9I/CKKb2+9xbJ48DtwuMioeIizyM59 DGAw84xYBfMbyybKyY98/s33KUjeKXkiu1hUNQnbEvlshDGjFyFzM0Xk1kdEMQPKx5bP keDM+3UYNk/RUAOJmzn3UeC9WbQXrR6cdOuwUPZABD3ZuR+w2Uf2PE7q3LZXdfvcrqe8 WX8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786914719; x=1787519519; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=piGwFWwU9JIYJc8ZqfFGe2WuXLHUeUkmz9gwepBmbbw=; b=hVsznmQ1lYKZOPFKL5fdAN3jf/B5hezsECBS2lgZbSkgLYDICqc90C/UpbLSu2lisX 9ldbSxCU9CmLGT/0dz4YG5rpjx4/Hu58LmSnSS4jhTygrIa7NmTcJuy6xDaS1c+zYGyU vVHdiH4k0Fvwo/nmAUj9dwafCg2Dw6zw4SzTFN1wUH+cbimkf4bhFMxvCgaJAlKcP8EJ G0NBzgjxlbRnkH65rqkoG7VqbnZXCCciYYlyoe7MwaWdm9ATBQ+FFhNfRkdF5EKclIw2 TuWxTgj4lkNQyZemW8BDDWZfjNBAs9s9e9tHk7Hr+Vvg57Rh2zxDxaI7QUDvGwinlZ39 gt6A== X-Forwarded-Encrypted: i=1; AHgh+RqPkSovdlWLQoyYc8nmS2LqdkTaZZbctgUPp29XPPJOujkQpVRsOyni3N+g8gTtjEoWQEeJ2yGIAhVOmT0=@vger.kernel.org X-Gm-Message-State: AOJu0YzCAMsCGiCh78EzhgdcBsay2xn/AtBVfiWg0uC24aEzIi0jaK+x pFATBY0vlPKcV/4fsImQeIvk7ECedQMNLfKkqnrCiiXrUp+fFbSG52/dHUmuTwjFpD9jkSVZzK9 fMJt1Nk8Myr4QLZ7DmP51/4Dis6VgbjY= X-Gm-Gg: AR+sD12JefUfD5oOjZiPWqYtBC8qF3B79TjGQbDXEK858TR9IBxxLbhEAV3vKB7gFHx kdT6piDvj4TZ+t/k3TtnOhalFDglJAEkmWHyk9tf3pfBJuqbcrGRoJDMaFehReusrOIhC+rQ2Z9 XZ7roHibzbAXjBrKMOwKyKvhH8BI83cI6ov6QU1TnGH7RBoH3P5FZdckPuYmFloHl/6j4yw1zfR HkH6ZStuqW76PHUJkg42kZ7HO9nXzgbb3VaMjpW0+bP7Q38Nlq8dqOaZuh3zu6Y/LtltHNtgdXp mH/cIU8ds5cUhyJ70VrrCkVgLSJDRwJCw/NTDXJdQlsW34s7vftiGyYNNIckOcGbPJO0k4B83ED 4k12WzIfB7JQEr/bKzHi1L7Oo0Zt7+iYdeKEix0VzxgZoJbklBIKuk2stEu2y/19mmevR2KCWFr IOF5eeTZcHMynfGY7ixTqZDiHbBLQHBcCITcSh6IGUA3JkuSMYiyERHJs= X-Received: by 2002:a05:6402:4282:b0:6a1:284f:7891 with SMTP id 4fb4d7f45d1cf-6a38a8f4953mr9146604a12.7.1786914718527; Sun, 16 Aug 2026 14:11:58 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260802144855.3596995-1-julianbraha@gmail.com> <999edd39-43d0-4973-96ce-a205283277ff@gmail.com> In-Reply-To: <999edd39-43d0-4973-96ce-a205283277ff@gmail.com> From: Rosen Penev Date: Sun, 16 Aug 2026 14:11:46 -0700 X-Gm-Features: AcwNN1XxqBacDGACTiAaEjorHNh7Xt50dZ2sag4g5i3K_p7BCynQnau5dtCepOU Message-ID: Subject: Re: [PATCH] ASoC: fix unmet dependencies on PPC_BESTCOMM and SND_SOC_AC97_BUS To: Julian Braha Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, arnd@arndb.de, chancel.liu@nxp.com, jonsmirl@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Aug 15, 2026 at 5:01=E2=80=AFPM Julian Braha wrote: > > Hi Rosen, > > On 8/2/26 22:14, Rosen Penev wrote: > > On Sun, Aug 2, 2026 at 7:49=E2=80=AFAM Julian Braha wrote: > >> > >> SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA both select > >> SND_SOC_MPC5200_AC97 without ensuring that its dependency on PPC_BESTC= OMM is > >> met. This causes unmet dependencies such as: > >> > >> WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 > >> Depends on [n]: SOUND [=3Dm] && SND [=3Dm] && SND_SOC [=3Dm] && SND_= POWERPC_SOC [=3Dm] && PPC_BESTCOMM [=3Dn] > >> Selected by [m]: > >> - SND_MPC52xx_SOC_PCM030 [=3Dm] && SOUND [=3Dm] && SND [=3Dm] && SND= _SOC [=3Dm] && SND_POWERPC_SOC [=3Dm] && PPC_MPC5200_SIMPLE [=3Dy] > >> > >> SND_MPC52xx_SOC_EFIKA also selects SND_SOC_STAC9766 without ensuring i= ts > >> dependency on SND_SOC_AC97_BUS is met. > >> > >> Let's resolve all 3 unmet dependencies by adding the dependencies on > >> PPC_BESTCOMM where needed, and selecting SND_SOC_AC97_BUS as other, si= milar > >> options in this subsystem do. > >> > >> These unmet dependency bugs were detected by kconfirm, a static analys= is tool > >> for Kconfig. > >> > >> Fixes: a9262c4fd404 ("ASoC: Support for AC97 on Phytec pmc030 base boa= rd.") > >> Fixes: 6ffee43ecf8b ("ASoC: Fabric bindings for STAC9766 on the Efika"= ) > >> Signed-off-by: Julian Braha > >> --- > >> sound/soc/fsl/Kconfig | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig > >> index 8ae59c094878..a5d7cf534391 100644 > >> --- a/sound/soc/fsl/Kconfig > >> +++ b/sound/soc/fsl/Kconfig > >> @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 > >> > >> config SND_MPC52xx_SOC_PCM030 > >> tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" > >> - depends on PPC_MPC5200_SIMPLE > >> + depends on PPC_BESTCOMM > >> select SND_SOC_MPC5200_AC97 > >> select SND_SOC_WM9712 > >> help > >> @@ -253,6 +253,8 @@ config SND_MPC52xx_SOC_PCM030 > >> config SND_MPC52xx_SOC_EFIKA > >> tristate "SoC AC97 Audio support for bbplan Efika and STAC9766= " > >> depends on PPC_EFIKA > >> + depends on PPC_BESTCOMM > > does this really depend on PPC_BESTCOMM? > > Yes, BestComm is the co-processor found on Freescale MPC5200. Just took a look at this. --- a/sound/soc/fsl/efika-audio-fabric.c +++ b/sound/soc/fsl/efika-audio-fabric.c @@ -22,8 +22,6 @@ #include #include -#include "mpc5200_dma.h" - #define DRV_NAME "efika-audio-fabric" SND_SOC_DAILINK_DEFS(analog, compiles. That header indeed references bestcom stuff, but I don't see the driver doing so. > > - Julian Braha