From: Andy Lutomirski <luto@kernel.org>
To: "Christopherson, Sean J" <sean.j.christopherson@intel.com>
Cc: Andrew Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86/vdso: Remove a stale/misleading comment from the linker script
Date: Tue, 4 Dec 2018 10:59:24 -0800 [thread overview]
Message-ID: <CALCETrXMEdbcq_fXe6CEeU+Mi_G54KexCMasmhz7GKk4iDjerw@mail.gmail.com> (raw)
In-Reply-To: <20181204161741.12292-3-sean.j.christopherson@intel.com>
On Tue, Dec 4, 2018 at 8:17 AM Sean Christopherson
<sean.j.christopherson@intel.com> wrote:
>
> Once upon a time, vdso2c aggressively stripped data from the vDSO
> image when generating the final userspace image. This included
> stripping the .altinstructions and .altinstr_replacement sections.
> Eventually, the stripping process reverted to "objdump -S" and no
> longer removed the aforementioned sections, but the comment remained.
>
> Keeping the .alt* sections at the end of the PT_LOAD segment is no
> longer necessary, but there's no harm in doing so and it's a helpful
> reminder that they don't need to be included in the final vDSO image,
> i.e. someone may want to take another stab at zapping/stripping the
> unneeded sections.
Acked-by: Andy Lutomirski <luto@kernel.org>
prev parent reply other threads:[~2018-12-04 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 16:17 [PATCH 0/2] x86/vdso: Remove remnants of the fake section table Sean Christopherson
2018-12-04 16:17 ` [PATCH 1/2] x86/vdso: Remove obsolete "fake section table" reservation Sean Christopherson
2018-12-04 18:22 ` Sean Christopherson
2018-12-04 18:29 ` Sean Christopherson
2018-12-04 18:58 ` Andy Lutomirski
2018-12-04 19:28 ` Sean Christopherson
2018-12-04 19:46 ` Andy Lutomirski
2018-12-04 16:17 ` [PATCH 2/2] x86/vdso: Remove a stale/misleading comment from the linker script Sean Christopherson
2018-12-04 18:59 ` Andy Lutomirski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrXMEdbcq_fXe6CEeU+Mi_G54KexCMasmhz7GKk4iDjerw@mail.gmail.com \
--to=luto@kernel.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®