From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9AAD42B742 for ; Fri, 10 Jul 2026 15:32:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.216.49 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783697560; cv=pass; b=rnkA6eT5IdUHPrm9Qm4+iMO3zcPi5enEL05ZpkeHEcHzOYVo6UdbVPDNpi2kZel+ojQAsjM3v98br+IK8nBtZ5iRdbm/3tBcdiOprbjeo0J4YpPEaB38XVmqVWJeH+DETfr4teGCu77d9kzYgklMTdoDptILbhOI/H+bhLB77cY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783697560; c=relaxed/simple; bh=LD/HoXawwSiJkE0tqPWy8TxRHVZpMFV44E98okcn0uQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=iRSG/1K5drnfaHjfPvuKDv8XFDnt+GDJE3w1BIx90K4ah6nPQ6HpAcvKzJE75yyFYAJqJ/rQx1bN3AYz70QWNXZL8Nu8/cqnFjurfqrmddH9fYuohhNrYd+YVKbRgxhxg0a4i7ZTI159B4S6NTqo2cMV5/XijuzP99OJeTYlpn0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gBjhuiao; arc=pass smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gBjhuiao" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-383cb94f742so961871a91.3 for ; Fri, 10 Jul 2026 08:32:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783697558; cv=none; d=google.com; s=arc-20260327; b=MDTBIw2+o41vxR4yt8BV14tjbB+Uc+uueVxRd/1Eq511bZ1ffKyd8ApIUes+dQfP5c Awf6GzIhy0FTjO0B7pyhR5ZLD/8wXae235SUFv3F6z555FGSH6r26zYIQxFqTJyoUudk myTJvqoYFJKSSWJocKNCdUSjWhrPSZ1OZvbVC+tWBeNJoECXWe3ZNX5sdHkvD9uZ85UP djOJzagGCWKhIkopGbqosJKa53bfb5zOb0DVXTtCXNHu0kkA+ncEsXAGlVpRHXJmuzPH QFWaGV8pb/SzwYB9ThO4FGnxuxRG/UKXgieWY7RkmY0dVWMyeBn3scFN4Xy2BhnkCBnq bU2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=LD/HoXawwSiJkE0tqPWy8TxRHVZpMFV44E98okcn0uQ=; fh=BKbi13RQ+C6hAfVPw4KpfDBTWLhGY2XvhU65/x65fFM=; b=a4nwf8nmpHbeJ39ch4TV2e0nQjkncjlEix8YUK4ox4cjaAmYt71PvC2iakxVijNjex y3BboJgFexPbm5DozuX+COi+Bb0qmJm10cchmcsQO0kDKi8tA6XV/9rojSRctTDFE5W/ rEMR1gWH53qSGN0udoZwv43hzdpmvcn6Z+6Epuc0wCZeeI0sAuGwuMi0N+jPOBLVVGB/ 12JkpIK6WwRyCjzTKgoyHhqhsUb5NyFWwe7cFWeqIX+5ZltmqVCumMeKHHMN0H3fDGLh oTfKwLVC5VR734zNJpg0fsFAzK/fwU3Gidn/I2F8/iTVOL01XoBkBLk1oy0qJIusQdYI TgcQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783697558; x=1784302358; darn=vger.kernel.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LD/HoXawwSiJkE0tqPWy8TxRHVZpMFV44E98okcn0uQ=; b=gBjhuiao85kliPAtWQRZSCYeQP/QIcQCfg74Ce5nA+jM8MI+iAw4QWWHj6PCwBoF01 +lJu4uWa/pdnqC93qyB/5GEbYX16Mi2QsIQ90xt6WyWyCqT4Un5yK8lQZXXplXOnnsV0 X1QmrJ1RWHY5UwzASYmfFBSU2XN6gZ0TXRT0aM7VWBW3/ivwRBpXU+i4OiRyLXCFVk9B qwk7Lmez1FEdADtTNGJSZWb7HPuPHYqes8tmRHXvUAtkm9mHzQeLXZMbNm6bJRJN6BoX OBdUFoonxtbs8VPMDjoKZav2Oajmhaw7i1xqBS0Np6+EfFE0kja/PMkjY13F0mePoFKV D/Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783697558; x=1784302358; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=LD/HoXawwSiJkE0tqPWy8TxRHVZpMFV44E98okcn0uQ=; b=PraCtSpeMHibQ1iMFs4uVmw2panA0OynT18RiVfyyy+Rojyvpzi6F/UUzEXUa2XqMO RPG7rdIpQUNJcwE5Rdy6xI8iVqmIlZznTpkso/o/0oof1HSgNbzq7lBpWzearBDg/BJs zxoxGZuBC7j/rgp3Av+7HF4hTedqSk3LfSyUqdNxZ5np8/tLHOKJqDpyor0/S/pJ8wBd RxlAntj3tzlS2uHSNlfd93UGv63jlweNG+QGdVHVTUR4nV9izBE3EJONUyCwPj4fjePo Bih9y1LS4ckGBznqrF5kpZ6ft02Bgn/lDI6JxS5AzyDZYoiTjI/EcQcjDZVjpgsFDCZi QY6Q== X-Forwarded-Encrypted: i=1; AHgh+Rr4rMeparO54rdInmxS36FfwUOTUqZVF46jM1VsxRT1MfquLSNUWnWbXobQWhUNPlWPb0UtGf5R1XI9d54=@vger.kernel.org X-Gm-Message-State: AOJu0YxwSCe9+DQfz/fEsX6oLIeTwDc3G37Ymhz6GQRrFB5fw88wVMUe naYNotuDeiZ0UA/nszFDbn0YX5Q03xpsOrbm4PAYFxJIEWMZR3PJnoGifU1W09l3Tx9ZjlmA5r6 0bo3/e2A95SDHyMSppiyZo222zdvg8yM= X-Gm-Gg: AfdE7cnsHSrzkhS+Tg1mZavAndI2NCtov8Yxir0NQaGSghy5l2BWLrgfGIot8tBcNPf 0V+BJ8zN4SaxpJbAlINSLliNfSCiMdv+Ge4TW+9WHPlk1sdMXAlr7FKY4g3IuuuUPQTyI5PkqvL l8AB9nWpftyZ4TwXvLRFBSxiYZoBXacTvgbdKDie0Zn2WfbKKpbVmKJSGxrLpA848MJ66XO6QC+ BTWeB7vyUyIcNGIE4ff9sPmsWXVYRUXVxDlOSB17icbZrBlpKQW1477KFZ1Abn9LCfssf7DVQAu YbDGgiqMfdzyKuPLRRFfG5ju2n87YjZoiU6BruYBWsGPQZ4If/iie4nt0ouV X-Received: by 2002:a17:90b:2ccd:b0:37f:9ce0:af31 with SMTP id 98e67ed59e1d1-38941ad2a55mr12198944a91.28.1783697558119; Fri, 10 Jul 2026 08:32:38 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260707014525.1015-1-kimjinseob88@gmail.com> <20260707014525.1015-6-kimjinseob88@gmail.com> <20260708022006.4276fc99@jic23-huawei> In-Reply-To: <20260708022006.4276fc99@jic23-huawei> From: Kim Jinseob Date: Sat, 11 Jul 2026 00:32:25 +0900 X-Gm-Features: AUfX_myFYIBykcPPdf8s5JAjoOTFSzN_9Jogzi0T4pIoiCbRwRR3MlGuA2VyJNw Message-ID: Subject: Re: [PATCH v7 5/5] iio: osf: add UART IIO driver To: Jonathan Cameron Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Lechner , Nuno Sa , Andy Shevchenko , Andy Shevchenko , Jonathan Corbet , Shuah Khan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" > This is only defined in this patch but is used in patch 4. Make sure your > code builds after each patch so as to avoid breaking code bisection. I changed patch 4 in my local next revision so that the stream parser no longer depends on osf_core.h or osf_core_receive_frame(). The stream parser now accepts a typed frame handler and an opaque context. Patch 5 provides the wrapper that calls osf_core_receive_frame(). I compiled the sources introduced by patches 3 and 4 separately using temporary uncommitted Kbuild harnesses, and built and linked the complete module after patch 5. > This feels like going too far to deduplicate just this. Put a copy inline > in each of the other macros where it is used and drop this one. I removed OSF_SCAN_TYPE_S32 and placed the scan_type initializer directly in both channel macros. > Looking at this again, why do we care about holding the device > in buffered mode for this? Races should be safe without that > big hammer. A simple check on iio_buffer_enabled() should ensure > data is only pushed when it is enabled, or just after it is disabled > (which should always be safe). I replaced the buffer-mode claim and release with an iio_buffer_enabled() check. The one-axis and three-axis cases now return directly from iio_push_to_buffers_with_ts(), and the default case directly returns -EPROTO. The zero-initialized scan structures and aligned timestamps are unchanged. Thanks, Jinseob