From: Pravin Shedge <pravin.shedge4linux@gmail.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] lib: cleanup dead code from rbtree_test.c
Date: Tue, 19 Dec 2017 23:21:58 +0530 [thread overview]
Message-ID: <CALSsfOCeHZiqosd22GhFRBDRYdbNbvxCw0+GkvDLo1DT1PHLLw@mail.gmail.com> (raw)
In-Reply-To: <20171217155540.rscp7boal3wx6x5g@linux-n805>
On Sun, Dec 17, 2017 at 9:25 PM, Davidlohr Bueso <dave@stgolabs.net> wrote:
> On Sun, 17 Dec 2017, Pravin Shedge wrote:
>
>> lib/rbtree_test.c code allows to compile either as a loadable modules or
>> builtin into the kernel.
>>
>> Current code returns -EAGAIN on successful termination from module_init.
>> Such a fail will directly unload the module and hence there is no scope
>> to execute rbtree_test_exit on module_exit.
>>
>> This patch will cleanup dead code from rbtree_test.c
>
>
> Being completely harmless I'd rather leave this as is. If removed, the
> module breaks generic layout.
>
Right this code is not harmless but at the same time I am not sure
How other modules [from lib/test_sort.c] added in kernel ?
Little curious, Just for my knowledge
how it breaks generic layout ? and what will be the impact ?
> Thanks,
> Davidlohr
>
>
>>
>> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
>> ---
>> lib/rbtree_test.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/lib/rbtree_test.c b/lib/rbtree_test.c
>> index 7d36c1e..5cd2f26 100644
>> --- a/lib/rbtree_test.c
>> +++ b/lib/rbtree_test.c
>> @@ -397,13 +397,7 @@ static int __init rbtree_test_init(void)
>> return -EAGAIN; /* Fail will directly unload the module */
>> }
>>
>> -static void __exit rbtree_test_exit(void)
>> -{
>> - printk(KERN_ALERT "test exit\n");
>> -}
>> -
>> module_init(rbtree_test_init)
>> -module_exit(rbtree_test_exit)
>>
>> MODULE_LICENSE("GPL");
>> MODULE_AUTHOR("Michel Lespinasse");
>> --
>> 2.7.4
>>
>
prev parent reply other threads:[~2017-12-19 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 10:22 Pravin Shedge
2017-12-17 15:55 ` Davidlohr Bueso
2017-12-19 17:51 ` Pravin Shedge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALSsfOCeHZiqosd22GhFRBDRYdbNbvxCw0+GkvDLo1DT1PHLLw@mail.gmail.com \
--to=pravin.shedge4linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®