From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161179AbcGZTOU (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Jul 2016 15:14:20 -0400
Received: from mail.kernel.org ([198.145.29.136]:42088 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757699AbcGZTOR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Jul 2016 15:14:17 -0400
MIME-Version: 1.0
In-Reply-To: <20160726185030.GA1787@octofox.metropolis>
References: <20160726180132.12764-1-robh@kernel.org> <20160726185030.GA1787@octofox.metropolis>
From: Rob Herring <robh@kernel.org>
Date: Tue, 26 Jul 2016 14:13:52 -0500
X-Gmail-Original-Message-ID: <CAL_Jsq+322J+=KN4iM0hJC32iWmvaVKVXeRdSWXWsJSqpT7ZBQ@mail.gmail.com>
Message-ID: <CAL_Jsq+322J+=KN4iM0hJC32iWmvaVKVXeRdSWXWsJSqpT7ZBQ@mail.gmail.com>
Subject: Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary
 of_platform_populate with default match table"
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Chris Zankel <chris@zankel.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-xtensa@linux-xtensa.org,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Guenter Roeck <linux@roeck-us.net>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 26, 2016 at 1:50 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote:
>> This partially reverts commit 69d99e6c0d62 keeping only the main
>> purpose of the original commit which is the removal of
>> of_platform_populate() call. The moving of of_clk_init() caused changes
>> in the initialization order breaking booting.
>>
>> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table")
>> Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Max Filippov <jcmvbkbc@gmail.com>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> This is on top of Guenter's build fix. Please test and I'll apply. I
>
> Tested-by: Max Filippov <jcmvbkbc@gmail.com>

Thanks.

>> tried briefly running under QEMU, but didn't have success. If anyone has
>> up to date instructions that would be helpful as using these[1] didn't
>> seem to work.
>
> I think they're up to date. Another thing that need to be done right is
> the toolchain: it must match the configured CPU core. Please refer to
>   http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File
> for more details.

I don't build toolchains...

Rob