From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198AbeFAO30 (ORCPT ); Fri, 1 Jun 2018 10:29:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:51272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbeFAO3Y (ORCPT ); Fri, 1 Jun 2018 10:29:24 -0400 X-Google-Smtp-Source: ADUXVKJ/js5HIuwnc0CN5wPZp+XemHd8axsvu2r8pKqCWrKpV63CWo8ORk5UBFfVbjG0eXVGuP2ggXEZSNr/CQRh4Io= MIME-Version: 1.0 In-Reply-To: References: <1527486084-4636-1-git-send-email-srinath.mannam@broadcom.com> <1527486084-4636-2-git-send-email-srinath.mannam@broadcom.com> <20180531164820.GA23074@rob-hp-laptop> From: Rob Herring Date: Fri, 1 Jun 2018 09:29:02 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for SR thermal To: Srinath Mannam Cc: Zhang Rui , Eduardo Valentin , Mark Rutland , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , BCM Kernel Feedback , Pramod Kumar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 1, 2018 at 3:51 AM, Srinath Mannam wrote: > Hi Rob Herring, > > Thank you for the review. > Please find my answers inline.. > > On Thu, May 31, 2018 at 10:18 PM, Rob Herring wrote: >> On Mon, May 28, 2018 at 11:11:22AM +0530, Srinath Mannam wrote: >>> From: Pramod Kumar >>> >>> Add binding document for supported thermal implementation >>> in Stingray. >>> >>> Signed-off-by: Pramod Kumar >>> Reviewed-by: Ray Jui >>> Reviewed-by: Scott Branden >>> Reviewed-by: Srinath Mannam >>> --- >>> .../bindings/thermal/brcm,sr-thermal.txt | 45 ++++++++++++++++++++++ >>> 1 file changed, 45 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>> >>> diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>> new file mode 100644 >>> index 0000000..33f9e11 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>> @@ -0,0 +1,45 @@ >>> +* Broadcom Stingray Thermal >>> + >>> +This binding describes thermal sensors that is part of Stingray SoCs. >>> + >>> +Required properties: >>> +- compatible : Must be "brcm,sr-thermal" >>> +- reg : memory where tmon data will be available. >> >> What type of memory is this? > This is shared memory(cache-able) which is shared between two micro controllers. What else is in this shared memory? You should probably be representing that as a whole somewhere in DT. > One micro controller update temperature of all thermal zones in this > shared memory. > thermal driver running on another micro controller monitors > temperature data of all thermal zones. >> >>> + >>> +Example: >>> + tmons { >>> + compatible = "simple-bus"; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges; >>> + >>> + tmon_ihost0: thermal@8f100000 { >>> + compatible = "brcm,sr-thermal"; >>> + reg = <0x8f100000 0x4>; >>> + }; >> >> Convince me that you need a node per register. This can all be >> accomplished with a single node and either a single reg entry or a >> series of reg entries. >> > In our system we have 6 different thermal zones. each node belongs to > one thermal zone. > thermal driver detects each node as separate thermal zone and monitors > separately. > register entry is only 4byte memory which contains the temperature > value of respective thermal zone. > Based on requirement we can increase or decrease the number thermal > zones need to monitor. Still, all this can be accomplished with a single node. Having a node per register in DT doesn't scale. Rob