From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753410AbcEBMgF (ORCPT ); Mon, 2 May 2016 08:36:05 -0400 Received: from mail.kernel.org ([198.145.29.136]:48509 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753922AbcEBMfv (ORCPT ); Mon, 2 May 2016 08:35:51 -0400 MIME-Version: 1.0 In-Reply-To: <1462079316-27771-13-git-send-email-ysato@users.sourceforge.jp> References: <1462079316-27771-1-git-send-email-ysato@users.sourceforge.jp> <1462079316-27771-13-git-send-email-ysato@users.sourceforge.jp> From: Rob Herring Date: Mon, 2 May 2016 07:35:28 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RESEND 12/12] of: Add sh support To: Yoshinori Sato Cc: "devicetree@vger.kernel.org" , SH-Linux , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 1, 2016 at 12:08 AM, Yoshinori Sato wrote: > sh fdt access in VA. But memory reservation use PA. > So sh need convert to PA. > > Signed-off-by: Yoshinori Sato > --- > drivers/of/fdt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index 3349d2a..fb357be 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -593,6 +593,9 @@ void __init early_init_fdt_scan_reserved_mem(void) > fdt_get_mem_rsv(initial_boot_params, n, &base, &size); > if (!size) > break; > +#ifdef CONFIG_SUPERH > + base = virt_to_phys(base); > +#endif > early_init_dt_reserve_memory_arch(base, size, 0); This is not right. base is already a physical address and early_init_dt_reserve_memory_arch takes a physical address. The default implementation using memblock also works on physical addresses. It is a weak function so you can override it if you need to do something special. But it seems something else is wrong here if you need this. Rob