From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CEE2C433F5 for ; Wed, 10 Nov 2021 13:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B8DA60FC3 for ; Wed, 10 Nov 2021 13:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232202AbhKJNvb (ORCPT ); Wed, 10 Nov 2021 08:51:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:32796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232265AbhKJNvS (ORCPT ); Wed, 10 Nov 2021 08:51:18 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id EC13061104; Wed, 10 Nov 2021 13:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636552110; bh=n3hxa2KRTFzO2Z6rzBE5JlC/VK0G26I+AACvyuQX1tI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GAkt7NZ1lAVaexsryGWFq4KodoTpRZItKNSfF1lAZAxiUIW52MyPWWNqDgy8y8RXx AMwKmmLCSq0gwTd85bxCKACprf4z6As8QA+xiXWAuy9NYgQcSM4iwpjgtO7lLRYTui xXyUtmw62v2rkTDYPWj//qzaEV+8NwNRdiAY+yHpq/CCMB9QaqQVdH+c4+uMMlwxKn AehmScshNJguS5EvYvHV6EEtMlLAhhioqAiSQdl4tA1S/xJCt+jKeNosVlBJ2SMC+P diBuobTD7pEV5aCmlu9YQ9EvOGzsYZoh0A5YiC+P3nBSJruqBCB4XfLugudK2Yyr/w oGHzRuOObuOeg== Received: by mail-ed1-f51.google.com with SMTP id f8so10856237edy.4; Wed, 10 Nov 2021 05:48:29 -0800 (PST) X-Gm-Message-State: AOAM532CxeTLussJ5Gnq/Kby7+67AyxbpSXQkkfdrYWS4yQqLlAKDtJS 3yvyrKep/bCBrycfgDkHgF/fmPc1mS7l3c6ezA== X-Google-Smtp-Source: ABdhPJwxpT7Wl3F8LvAc0g7wK1xAXWGs3tHsDiVrvImb73yTQQ8KfetU5/2u/qO7J3c8lJg1vLnKJkN2/Wp3icOuglw= X-Received: by 2002:a17:906:bccc:: with SMTP id lw12mr19843328ejb.128.1636552108263; Wed, 10 Nov 2021 05:48:28 -0800 (PST) MIME-Version: 1.0 References: <20211028130423.4025578-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Wed, 10 Nov 2021 07:48:16 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warnings To: Greg KH Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Stephen Rothwell , Frank Rowand Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 10, 2021 at 7:31 AM Greg KH wrote: > > On Thu, Oct 28, 2021 at 08:04:23AM -0500, Rob Herring wrote: > > The unittest dtbs have various intentional errors which cause warnings. > > With the latest dtc sync to v1.6.1-19-g0a3a9d3449c8, we need to disable > > some new checks: node_name_vs_property_name and interrupt_map warnings. > > These warnings are also generated for static_base_1.dtb, so add > > DTC_FLAGS for it. > > > > Note that the interrupt_map warnings only appear once interrupt_provider > > warning is re-enabled globally. > > > > drivers/of/unittest-data/tests-interrupts.dtsi:32.26-35.6: Warning (interrupt_map): /testcase-data/interrupts/intmap1: Missing '#address-cells' in interrupt-map provider > > > > Fixes: e76187b9792e ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8") > > Reported-by: Stephen Rothwell > > Cc: Frank Rowand > > Signed-off-by: Rob Herring > > --- > > drivers/of/unittest-data/Makefile | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile > > index a5d2d9254b2c..fbded24c608c 100644 > > --- a/drivers/of/unittest-data/Makefile > > +++ b/drivers/of/unittest-data/Makefile > > @@ -37,7 +37,9 @@ DTC_FLAGS_overlay_base += -@ > > DTC_FLAGS_testcases += -@ > > > > # suppress warnings about intentional errors > > -DTC_FLAGS_testcases += -Wno-interrupts_property > > +DTC_FLAGS_testcases += -Wno-interrupts_property \ > > + -Wno-node_name_vs_property_name \ > > + -Wno-interrupt_map > > > > # Apply overlays statically with fdtoverlay. This is a build time test that > > # the overlays can be applied successfully by fdtoverlay. This does not > > @@ -82,6 +84,10 @@ apply_static_overlay_1 := overlay_0.dtbo \ > > > > apply_static_overlay_2 := overlay.dtbo > > > > +DTC_FLAGS_static_base_1 += -Wno-interrupts_property \ > > + -Wno-node_name_vs_property_name \ > > + -Wno-interrupt_map > > + > > static_test_1-dtbs := static_base_1.dtb $(apply_static_overlay_1) > > static_test_2-dtbs := static_base_2.dtb $(apply_static_overlay_2) > > > > -- > > 2.32.0 > > > > Note this commit in Linus's tree breaks clang-based systems with the > following build errors: > FATAL ERROR: Unrecognized check name "interrupt_map" > FATAL ERROR: Unrecognized check name "node_name_vs_property_name" > > Any thoughts about what to do? I don't think it has anything to do with clang. These messages come from dtc and there's not any 'test the options are supported' mechanism for new options. It looks like the dtc update referenced in Fixes is missing or dtc is stale. There's no error in kernelci[1]. Rob [1] https://storage.kernelci.org/mainline/master/v5.15-11863-gcb690f5238d7/arm64/allmodconfig/clang-10/logs/kernel.log