From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8468A32C957 for ; Fri, 22 May 2026 05:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.221.53 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779426425; cv=pass; b=LgWF0j07ZX7JS9HKyloiFQdTex1pWPYXKoIoW0Iay+WPw1s5eqQSCRDjkRaZXHo7rKUJMeKGi9zSRHBGTFQ9h7eJle9OlTpM45gByL81V23I8KyiuA/WB/WfpJk403DMZX0U+xRi9tQpRhUEfvzs0RA0YecBdckd6NgF9XezaIo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779426425; c=relaxed/simple; bh=f36aZbnvgPmL2vM8iZzVmwmZg5YWhnIWhqX5OZSKntY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=lzyuPN66nILOIfh+FXimQqRhB58RtUEEPD7q46IMN/4Q4L7x8TJdXSkMCF2LzssE8+Rj+Pft+mhGoqgKOdFnjjDReV6uO+GNBo+3RYzLlD63M0ouHS4H8dVFMH1e4HpiRn4BWfczh8VJJtG//PUBYwrA28ofcohP94JQxj5XZ5A= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ryTgEXyU; arc=pass smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ryTgEXyU" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-44b330c5cc6so5138900f8f.1 for ; Thu, 21 May 2026 22:07:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779426423; cv=none; d=google.com; s=arc-20240605; b=FXQWxuJwdcjIlAL3rSg2Z0UC69hFoPQrACN9c4mypkCt+tw6BnUyLf79boXCg5w+KU EkcYZH23xNzCaFSimQmBwz6N3kW7L0HB31OTKZa3jNhtLOsZTGDsBDu6/gYkcDMk9J6w 2HDXyLOb+La/9kove0ycxtTtOrcrrw8tKMCuzNIl5Qu2f2N/gSJkkITJIgCnALXffyja wCX5LuAlfqGnVF+27kUvEW2Fvz2bqJoGfacvyo2oyayZb6hlJxvyO4kFfS8mFt1Sl1Ox sFCQP1CzCpnMYuwHYmasePvAlreT9a5AQFmGFyaoKBlU/eNpvYTIeolwCB1ABiLt06Eg JXIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=KHYK72KemxikmVxyF9kSlfVf0TXTgQLqDFo4QsuQZug=; fh=j1Gb+kVa4a7D3IIjVBZC95lFe67a+S8yL3jW6GBa8oE=; b=UZ04QaaqhRsYyriRKpUVv5OrJnMTP7kUXCMvLpfdjPZn1VMSBMt9uObgkGu9aCuzS7 WhlWBfondvW5wjn6os2KspDbos+H6syaSFR8zylE7ELiIP53RQuSGeCNucS2WzDi1bir +r63JongSWyYHrvJChmzLXCQIVxDCPjwcJ89N7QbIPo0/HexyaTllP0rJ2HB2qrK7Arn pwGaGQHLbai8D6Sb5YRA47TT5op2MYoOWrnGYfPaMP1WTFKUbUbwWkw6tfjWpm7LDjtW K8xWIUBks9OkL22bE2XIGxVbXV28YJ+tc6ULehgvAnKDvyQenvaWhWWnEFvAgO3Z421a iTZw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779426423; x=1780031223; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KHYK72KemxikmVxyF9kSlfVf0TXTgQLqDFo4QsuQZug=; b=ryTgEXyUuVb4SPRnhAAsP/Bmj2KMGKxWQdA5wJgh/AcgjO3ApXeTh3ZeoHCjp4ji+l 2emCaROFSzib9F3jCjST1o61GUc5ndwx6JHy0wEKnqI6d2mSXwmLoP0DJ9jaaXX80lyH CrhLXgWF0bLAItfcFQkwkFnHGOJuZZ8IZusGRd5jy5tS98FJ549HAZHN8+W8TrbgqeKa 4NmtoEk+UIfy7vmKZK4xy48HRFaAjqecUiSKBaW8dNd4Urxpg7wb3SRqzn4rpFtYTtpC y4Ylhm3Q2e79aL7DCkPOz7QOM3L/hs86aiwvSvIvlLst4qDd8/nZi8NLMbxsJRCJ5KCr 9efg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779426423; x=1780031223; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KHYK72KemxikmVxyF9kSlfVf0TXTgQLqDFo4QsuQZug=; b=mO8+4kboDOJVmC5Uo9IkcpX0B3aFjyP/B11AnpTHPdYyC9qz4jYuGzFL5uywhBpKsD SMIoYdkCLgxJjYpatSbQnIosDqSoowxyEWTKnru+xDyiol3sDBzfKSpK9bnXYy2dFlHu izG9fCS6YsqHA7VNTitqIzj4+kvM84maS5k2rtfDjd2L9aBLmFz4eXxzMb6iAPdDXve7 BmgwwzRCCNMB/5y1LhJMqVUBGCIypfT9rODrTsZ8C9LhDPHzgCtIn2J44jtu3z5j4uWy sbN99moyecduR8jS7pXpA83pm5xU8EBjW/oFv0LQL4d82R25fak3aol+CwBSpXtTjpn9 WNJw== X-Forwarded-Encrypted: i=1; AFNElJ/+cfLAKe2evoSx3yFiEOON6z6XLVun5rE3Hzoq93enljeD2I5P1pqJKQZujYGBJE3YLVCoq7y+Dw7PSa8=@vger.kernel.org X-Gm-Message-State: AOJu0YyoHGwtaJQBngAJ+kKA/XsxZpxo2g88NX6sQy0MZfiQgW4g75bF D+N4KWVbC/wEPPZ2ki3g7YG7vUHZj51gFhZdgBX+UpvJ+8qNVcSxNaQl9JtFMZs84L/NvPKvkrJ XDhEmZJvphUVmJ1VS+tPt28kazlKmt9Ziqw== X-Gm-Gg: Acq92OHBhJHqpSplNVBpETNuJ29/m2tl/ddAH4xw1d4KHGE9TVyauf8Jt3JLAtPkq9D 702mcHFzh1VUb5Orp07gPRtQVkLVNWH6yf59htVr7AhMS6+ZSMASLMaTDXizXfUmIlqP+8uS3ua XP7TreAmOFIVqq9WFrz6kh7ldWIDbueI/1fIHs6DeV0Fdz2Kb5/JIp/PSftw+TFgIMMuUWjKUzl mpXLQ7CZNKcfmCdgJwmQaqfugoUW3PKsZpfxCDL1eY3nugvP35Mjx4gOPgdjZNZUD+vE2CdRhV3 nb1wrn8wWCG4btlmQvBwbG1GxD8OslBxTRWKrXGq4M9bWqqRop3NbfV/ubUL66uEquelBjTS5XQ h8WLSEGf5ew2br0EswGFnukYIIY9EZJVRheTUnDhR6zTScHkPk2mWDwCCC0oiX8MaDvZw9ovnmV 3O1TflSXBFfCU8ELcsnel/kn+2Ly2F5i+adDeCNB4m+RaDiqxV X-Received: by 2002:a05:6000:1446:b0:45e:7415:8c4c with SMTP id ffacd0b85a97d-45eb38e0657mr2286888f8f.43.1779426422716; Thu, 21 May 2026 22:07:02 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260521-opt3001-cleanup-v3-0-820169dec8c3@gmail.com> <20260521-opt3001-cleanup-v3-5-820169dec8c3@gmail.com> In-Reply-To: From: Joshua Crofts Date: Fri, 22 May 2026 07:06:51 +0200 X-Gm-Features: AVHnY4J1iNlvvG2sYd-8jSWb_LGpQ-OgzL2g3QSx2RGfw5Kr2KMijONhTE4NhSc Message-ID: Subject: Re: [PATCH v3 5/7] iio: light: opt3001: prefer dev_err_probe() To: Maxwell Doose Cc: Jonathan Cameron , David Lechner , =?UTF-8?B?TnVubyBTw6E=?= , Andy Shevchenko , Alexander Koch , Michael Hornung , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Fri, 22 May 2026 at 03:49, Maxwell Doose wrote: > Ah, but all of the above don't seem like _probe() functions. I'm not > an expert on dev_err_probe() but I'm pretty sure it's only for use (or > at least, designed for use) in _probe() functions. Only function where > I know it's 100% fine in is the one below. Hi Max, Actually if you have any functions that are *only* called in _probe(), then it is okay to move them to dev_err_probe(), you just have to ensure you're not calling dev_err_probe() twice - once in the function and once at the call site. -- Kind regards CJD