From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 691CC317173 for ; Wed, 29 Apr 2026 15:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.221.49 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777474910; cv=pass; b=cRiUIFnVEOehtWjoXOOQiT5r0CXsFx5Cg8H4669x4bpY+dqZxRlMSihoFVa4Lg7ZUyhH0FfEffbVePXA5/Jajijdh3pvjzLcz9FcYrTYdClLBSCCSkPe6iYO98bIBZ2Uzjz/J2rhe/qTyzu51SKnAuEY53UzJcLMtJU2j6yp5jc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777474910; c=relaxed/simple; bh=Cw8HiYeGhGVNri5kNkphNtuXLygtN1Ukwi72xdQF/qs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=L5tm12vDSE/qbkUuLjXfDo9ia35BmVbvhx8ArnoGdbw5+JP+yR8kVQ1tERbVzB2JMVpsneL/r8TLzh2cBXQ/owFjUqt01ZKE5w9CC/5rQi6MM0Ckkrk59Hej3B+S215fzm++1sH7Aw3veIspRmdFUFuwcFDD8Pa8irPholp4oh8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ws7TRwju; arc=pass smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ws7TRwju" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43d73422431so11789003f8f.2 for ; Wed, 29 Apr 2026 08:01:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777474908; cv=none; d=google.com; s=arc-20240605; b=Tus0Q8Bk/MRvI6C6PN+eSYDPRM6hVeijGeGBVna+/haVdh06xgUhvGWSQfKimcQCTo OnAN+w57HqlkD/rYx2QAbuOUXVvA0j4XlPniQNcYQXdS+XfOfQz22eID1IG6eicVRU92 05xBpiIvdBHRVXj6PWnU5eUnHL+Fbu5J4pnMohN9v1IW+EcenOpcW09nXxkyu7aR2sYz ITH/SXMtCBnVotDKeP1kEwkxqiARnLNAPnALgP5M4kGRbf+cDCf3bKXsTQ7PlUeWjExD dItQeQwvk0Uzn7bng+jhPtiuWSbwzJDgD3SYs0gKfixfSotsprDcd6PUc4wHqBMe+5Qm TcRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=6Gzidrx1HikqS9ICFconcGCYd85JKEM9NohQlAuXWSE=; fh=tJKM3jZUNiRQtCEUJPoxqOSPoM93n8Z15/2wn0/Y5do=; b=EFIAJqnScFqtbKKgDDhtPlvB1uXnomdma5qZIUBUhyuiuNitEpOhY8hsmV49QEJrSm YpE5NSk/1aV5fX07rc6l8qM+kuKW0DDNkdGdHp/BecO/L4PESmV5Y1t4c1cAUwtToEQD dqzjdNfUqEvQDlauRioBCAhlBtUEQexxvd9urt03OQQvQfHtFwbGWEAMxz739JgBvpIX 6uC+wIrmkWohqU4jj6FUmsdwn0UtM3PEoqSyQAB3rBL+j/HcyVeY3WDlvBErOy7OmXbX 0q+qBJEHH7wo6dB503h//KYTz9yoiKE7Dvab4xBnUrsng8m5BWbRh8oVmjCtCAEBpD71 qQIQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777474908; x=1778079708; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6Gzidrx1HikqS9ICFconcGCYd85JKEM9NohQlAuXWSE=; b=Ws7TRwjuZtt4ej1b2dFnKfzi9YBdDEoWTlZdk/FRfESdb//alr1ceNA6q35ZiY4MK9 +pEA2Um1EsxEEBQzmOxKguNGmxDm6HJr29Dxg4WqtxM8xY1nVXVqDRRMOPnVF8P1wUAC JvU9/tLYGy6t06smEtIRKAaFqJC5FcXbSAumxtq+hEyQS2wUcuzFvekPY4ZbXHjQ03Dt alG7Ky3cE7l2N1KHjjZ0J/t+L7intEYHrkh0pJIzyzmrZHFR8hVTKk5Dpdl7+1IkuPOv ii8W1hIFU5euB8m01f1CF8U0FVKuxbYLaDS5byw3azQxXJcjFRVJ6mIKSRsIiiCscoGb G4CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777474908; x=1778079708; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6Gzidrx1HikqS9ICFconcGCYd85JKEM9NohQlAuXWSE=; b=fj+/La+qIuIG/EzKJfNplXPBkLEbSGxfR662scjsGwMAJUgm/tporzJJpYqLKbjFxj 6w4BH+MRJOMArfcb84giFfoED6OUHSxK9vpHbA7wv8EVAP9cAgUZizRNrlR6tkDMOBcx aNT9zn5dq9M1rBu46lG/aXaWBwJgKKCjOZ/Dtb+YrKSDd5R1eWDU1JGndTlemPodn4hj jY9OWYTogjj9XsNYFv05whlw5xVukC7bNhqCQwGVUw6q5grPGfScsVBNCIcAEapG3bf1 FqQg4BDSsjotRR5vbxsQt31dK6MxJKkL79JsWaPadw/DTa0NW/cACuPoxOW9okVAVJb1 xCvg== X-Forwarded-Encrypted: i=1; AFNElJ8AV9fbG40ivmGOPNnWVt/NtKKkbMdvz4I+IafuNuwNbIE1aB0vbPd0i3D/z437F/FhtknSY1fyRz3rp1M=@vger.kernel.org X-Gm-Message-State: AOJu0YydCwYC7K0x8EU6iTwrzXTXkvDbLDyEV4caTfQMg3USeCSGQKGE EFNeVVRfSdEOo1rxSloVmGK3njG8DOQyjm/L/+FnqZHYPV/SG+kSK3n91lvbo9Eyn3xiKbMs4Cy B8VdvUg7lS6hT0ZuFevNgK//Z/AbPcWA= X-Gm-Gg: AeBDieteGNiUz1MFM/6AJfoeW0LCh6P9K4QIYG+9k65aL3J9HMK/mHBzjhifQvD9a3I wA5ER+fFKSKV2Or6aL3eMCNPjgzerQfyy1ql1jvGfLlMVtwHFyje3TTXOjrKz4cGBgaE3kbG6BO Xq4722ThJN0M1aEgkqGBrlxcVDhGA5Qn912jF2wJlnAWzQ6PCi30myZXNvawJDeqW+ueZLUG9eZ LiMVnh3TjbOXcD4MzpseHa4sa5ve9X+e2vfpT81mXDMlhhdY58EM6FINPb4hA7PEixPiG3C7+za VxxjsMr0khNY8WaUIW8qhU9paN1zDVSloWPxndNsr+ALtaQjHYMohRqCH0I0UBLQsAbzaqUimgY OltLuFERPEvd9MBVq/PJLlf+ikhsCV/q5gr8AtJkNUWEE1kREXHZs0eHp7wQEauqeT6aZ3ElDbQ GRkkGRBHezOo4nFmu/ X-Received: by 2002:a05:6000:2681:b0:441:1e41:19c with SMTP id ffacd0b85a97d-44790472ecdmr7562583f8f.20.1777474907562; Wed, 29 Apr 2026 08:01:47 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260429054544.123862-1-piyushpatle228@gmail.com> <20260429054544.123862-9-piyushpatle228@gmail.com> In-Reply-To: <20260429054544.123862-9-piyushpatle228@gmail.com> From: Joshua Crofts Date: Wed, 29 Apr 2026 17:01:35 +0200 X-Gm-Features: AVHnY4JJydvG7p92mpdR9A8O6By1uWju88h8TjAOdC0jPpocQj3mzZPgv4o9lS8 Message-ID: Subject: Re: [PATCH v5 08/11] iio: adc: hx711: localize loop iterators in hx711_read To: Piyush Patle Cc: ak@it-klinger.de, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, 29 Apr 2026 at 07:48, Piyush Patle wrote: > - for (i = 0; i < 24; i++) { > + for (unsigned int i = 0; i < 24; i++) { Might be a nitpick, but wouldn't it be better to have a macro or a local variable for the 24? > value <<= 1; > ret = hx711_cycle(hx711_data); > if (ret) > @@ -174,7 +174,7 @@ static int hx711_read(struct hx711_data *hx711_data, int trailing_pulses) > > value ^= 0x800000; > > - for (i = 0; i < trailing_pulses; i++) > + for (unsigned int i = 0; i < trailing_pulses; i++) Why is the index unsigned when trailing_pulses is signed (this goes for the for loop above as well)? -- Kind regards CJD