From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 190AF25B663 for ; Sun, 26 Apr 2026 18:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.222.181 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777228728; cv=pass; b=S/lslP78npcSyV0AMHThIGJxdEW4strI+Rqwm3SL4MJ3NDpDIg1wgcReoZuSVgO6F4rRuxyLq068Hs8tpc3Wj+RxysOVjzDALWP1c8tlgThcpjcNu4Z9KQmF7uB2eGJJX3ti9S1w++UXUEX00CZG9Gm6d7t60u6OyvCCqqdqVpg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777228728; c=relaxed/simple; bh=Gx8SauWUSCO6c2K3A5iLYLdD+56BUYgITQcSo9zHWEU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Qm8L1VRyptqbNU3wKcIi7p20OunsGZvuZf1rcj+7wrctrkQ9MGfuMAqIxDPoEzu5Bc4mkeBEYiwgG7ft2DeQR/XGe7836O6aKGbdRYKazOOmpC8IZiJ+wzjZMC04VaYX/6bDbtLJloKrdGYUzK1zkpoKcr55WSGWWx4iyj7N+9k= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qE0PbhGy; arc=pass smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qE0PbhGy" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-8cbb6d5f780so861994385a.1 for ; Sun, 26 Apr 2026 11:38:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777228726; cv=none; d=google.com; s=arc-20240605; b=gVzukmzkVwYYodCV6MX3oflLYIszgUlY84Z8uFRankVF4hLkRkpkQwcIwT0dTvV80H BdKd5A6wGlwrpw34kvGT5EZ5mTrsAmvl+4kRklBVxy6ZB0t7iHEJGEX64zY2xSYD13x3 lw5ggAk3UiU97QVFODGvYhELpYMAviC3fS0fR+R4nm9rIGj8U1wOLcj6h7b4M6+nToyf SL2SNrYBtXr82H7WQrzm9dzsts2WWXQ5mfeXxQucZl/9kb38TaS6SCgJ8Uij3ONMd03W 0iTCaj0EQUxRo7AU8Xv/MCP7g5quHUOFMCRsxDFbLI9+5AcQTHARmCEL9MNNWOkuQzTh QWLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Gx8SauWUSCO6c2K3A5iLYLdD+56BUYgITQcSo9zHWEU=; fh=mj27G4XvBkBBNZAwGXd7Ns/EblOs/yHA0go9JKi4rtw=; b=QBK6U1YltX0SR5B5UrJqOJ8B/QFNvI7hqV6xQMEIFe5+VfnxgABz8k8uugC0gxbn5k RD/KMYseBUdR+nb+DyxSPG5nKWLvvyxmKADhysWI2BED3OrzHqGWGb8hdcYGYpEJ1MRe xPkdrACSYL0IHy41wkQWq9oqvciNy609gVr7rJZrryMUYhnHtg3xmiz7tQsbwZg0fYdd XAR78DuQwYXyItcIleP3Kewz3YsQp+bjvDtmX8nqAExoioy78AjcpiEQnmjE2MgflZyT W+22kBx8Ll10uAlBUh/0YTJxgNEey37MR2/MENBKFjcfM72odnCioZYvwXI4x/tI2Rpq QwLw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777228726; x=1777833526; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Gx8SauWUSCO6c2K3A5iLYLdD+56BUYgITQcSo9zHWEU=; b=qE0PbhGyjUOxk991Ycnc4XWBt7dlwM5G+3+Hb41F88hStusf9LK24ysAq7G34pyBaB CI99pfXYhFv0rPTiGwJIYBTnhb0ncw19d/eZ68hDKtu9sLYft9LluKHRg7Vzr1ebVjLg 4BZXi7Kjdz9lB7k3MJpm5XTw+T4svZy7tmt+RIbV7YV7hdk7wJkEBJjdKm8JU4J1yq4o uFNITa5nAEz7phIhd/L5iLh6YDwlZuJNoLwNYpMGAQvBYCcQcew89pSNQEXRWPYzBoMx RHANUDZiWBJqoPDgHuSxuj650GXelPi6gTRBEJHvzEKrfLXA/gpLd8zm09FsM43v41O2 hl8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777228726; x=1777833526; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gx8SauWUSCO6c2K3A5iLYLdD+56BUYgITQcSo9zHWEU=; b=ZOzzhtXFWMX0vykP61n3aJ4nxSrm3Fi2K1EdQYZerJqO3rVtUoKA9o4jEbS+bP53+S EPjzrGUJxlX9T+ZaSNTjp1mP09g21FUbHMjoBejdPF6ssgZhvGrMwxOL9gaO/vFvtWSZ hTP9R/h1/3oq5Vz3GKleOR7Tm9VRX7TWgOXQ9szXsEa/O/WcIBU3GFHpCHOCqqw7a2/t QIP2LDMVHBqxL5/u6GvXx9BL18+/T8qKiD4MW4/Pcj0nUzujivJunpay1yikIxEXA2vq 0hk0xn2gWfBq4yVyr5glTFzq/0tbBmaz9aUtBmquuXoTKsnklz4hk8HZtk8oDPsdUdcW 6XwQ== X-Forwarded-Encrypted: i=1; AFNElJ8uaTK1bAy2nQJM4J1cQfv7cMdgIl5nfaf9r80FhALdue++F7Y7h4oH1ev3Nf1xvOIBuuIMn3e7eQZKXSk=@vger.kernel.org X-Gm-Message-State: AOJu0YynZtLAm4SE+x24AGG030z3ahcF2kS0AsImdqGLz277iwJKISVE rf5/4o3W8kqyPT4RpuYhd0Ii6FUEnbLla2U9cqOGwPgTXqD3nudKf6mLyMg9ZectGBSAh14X5iL +5RSwcooPp+5v9bnXvHHmTnUZH9RqsWU= X-Gm-Gg: AeBDiesqJ7eSrRTJ7zWuC3XeTmIUVIf1IExyoxWYOobbPJ9mgskzsFjK/U6GcvZPyyD DRIUy3z0TyxXcXIOfdIHL6Xr/PvDdp23sVG2XSTNwRtKamC1JfT5IQKzkRBbT/oNTWL0EK9g61o 3VNqp6G0Biimj8CUzV48uYg9H3ckzXVGDdBKdF4I3zgqaHUQ3UNgXkvtV+e5Ypac2xMX2S9NjLo qgbcrQaepx9SxhhD1XeGMyBtOrcqNhY8DfgqsbRfWYXPf2B87YxnTKflN0JiCrzML4veDWTsnZv Ew73l3UEaIKLIgkb1kM= X-Received: by 2002:a05:622a:1303:b0:50d:a8f5:d515 with SMTP id d75a77b69052e-50e36e93acfmr625479191cf.51.1777228725975; Sun, 26 Apr 2026 11:38:45 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <673b66893c16ca31b403e7e7cba32e9b71a7515a.camel@rong.moe> <20260426174332.9981-1-cd345al@gmail.com> In-Reply-To: From: no name Date: Mon, 27 Apr 2026 02:38:35 +0800 X-Gm-Features: AQROBzB0HtrbCxdgg67bFB7RwuiYLwiL3SOmZPEgvGSr4n4WqSDBGH18_gZjVz4 Message-ID: Subject: Re: [PATCH v2] platform/x86: lenovo: wmi-other: Fix uninitialized To: "Derek J. Clark" , mpearson-lenovo@squebb.ca, i@rong.moe Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Derek, Thanks for your reply! On Mon, Apr 27, 2026 at 2:22=E2=80=AFAM Derek J. Clark wrote: > Hi Yufei, > > This bug is already addressed in a patch series that has been submitted a= nd is awaiting review from the subsystem maintainers. > Which bug do you mean specifically? The args.arg1 uninitialized bug, or the original uninitialized 'raw' variable, or the inappropriate encapsulation? > >I may do some refactor recently, and I'm happy to hear your suggestions. > > Rong has a large refactor series queued up to simplify much of the driver= already, pending the acceptance of the previously mentioned series. It wou= ld be best to avoid doing any additional large refactoring until that serie= s has landed. > OK, that sounds good. I'll wait until the refactor is done. I hope my suggestions can be adopted or we can discuss further about the appropriate architecture. I'm happy to hear your suggestions. Thanks, Yufei