From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbdCCQiD (ORCPT ); Fri, 3 Mar 2017 11:38:03 -0500 Received: from mail-lf0-f44.google.com ([209.85.215.44]:34026 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbdCCQht (ORCPT ); Fri, 3 Mar 2017 11:37:49 -0500 MIME-Version: 1.0 In-Reply-To: References: <1488540925-16898-1-git-send-email-singhalsimran0@gmail.com> <1488556204.2179.32.camel@perches.com> From: SIMRAN SINGHAL Date: Fri, 3 Mar 2017 22:07:13 +0530 Message-ID: Subject: Re: [Outreachy kernel] Re: [PATCH v3 0/5] Fixed compilation error To: Julia Lawall Cc: Joe Perches , Larry.Finger@lwfinger.net, Florian Schilhabel , Greg KH , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, oleg.drokin@intel.com, marvin24@gmx.de, outreachy-kernel@googlegroups.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v23GcSJ6006290 On Fri, Mar 3, 2017 at 9:45 PM, Julia Lawall wrote: > > > On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote: > >> On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches wrote: >> > On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote: >> >> Fixed compilation warning in lustre/lustre/llite/range_lock.c >> > >> > Really? What compilation warning was removed? >> >> CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o >> drivers/staging/lustre/lustre/mgc/mgc_request.c: In function >> ‘mgc_set_info_async’: >> drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning: >> format ‘%s’ expects argument of type ‘char *’, but argument 3 has type >> ‘void *’ [-Wformat=] >> >> I was getting this warning because of changing (char *)val to val >> where val is a pointer to void. >> So I fixed this by reverting this change. > > Someone pointed out recently that when you make the cover letter for vn+1, > the subject should not change. It doesn't describe what is new in the > version. You put that in the message. > I will resend the complete patch series with changed subject of cover-patch. > julia > >> >> Simran >> >> > >> >> simran singhal (5): >> >> staging: nvec: Remove unnecessary cast on void pointer >> >> staging: lustre: Remove unnecessary cast on void pointer >> >> staging: lustre: lustre: Remove unnecessary cast on void pointer >> >> staging: rts5208: Remove unnecessary cast on void pointer >> >> staging: rtl8712: Remove unnecessary cast on void pointer >> > >> > What compiler warns about unnecessary casts? >> > >> >> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +- >> >> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++-- >> >> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- >> >> drivers/staging/nvec/nvec_kbd.c | 2 +- >> >> drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------ >> >> drivers/staging/rts5208/rtsx_transport.c | 3 +-- >> >> 6 files changed, 11 insertions(+), 13 deletions(-) >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. >> To post to this group, send email to outreachy-kernel@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyMKJvhQMAdjtLWWKTtxOP%2BicRZ6bctB0bTtzA8gJi%2BwNA%40mail.gmail.com. >> For more options, visit https://groups.google.com/d/optout. >>