From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64AEE3B14B8 for ; Wed, 17 Jun 2026 22:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.82.49 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781734063; cv=pass; b=unQOnBsmuSE6vIwXBNmsgUbRWjd7BTru52v+dbxyYevvRUHvC4AY89UQaqfD1HxNHamy0nRJhXIsrltvAbUUTSkvuuNYPg5cIHI4C1ugzH+1LKQjFEilsM4jngtiOnGdA4J+VYu/FvDPCB6uK5kow4bl156iNUEZSlwXqemVy1o= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781734063; c=relaxed/simple; bh=dpAk0VAQdmltDmwyDqcpJc1YZ9ddSOslmAa2U6BjQvY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=j2I/3UIkOvIDbf4FRw8C5RDYyIHIJhmHgiFpg4jfzIh869XTUlzCGnETR9eCeUUm3xyrNWgCzChZ5twvHizZ469q7D3tU931AjWegMTwbSJOG5WxGWRI2hP0u2OY/brU6eC21QFWNO3ZuoAHultVMoE9Kgtsbhx3xKp4mLkFB5U= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=p47Xbk2q; arc=pass smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="p47Xbk2q" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-1390f75d8bbso685653c88.0 for ; Wed, 17 Jun 2026 15:07:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1781734061; cv=none; d=google.com; s=arc-20240605; b=NQvHFtOUX7R9knya35kA0K07Yvlmvk6pTrwiN2l7WV5MBeQPudGzmKKE8jb8x/K7hY /SZwV6a2l8wk3hV4f+oq/iYB4O4pAqYh6BK0Q5WI+FKP/mmAdr1GfhqEHfbXRGbk/Qu0 XGSROqCsBHxnBy5MxyOsweOXUVYf7B9u3SkRn06R6JtkUlnlWEeimeiDdasRqsar1PLe 0ajrRS6W4zeJLO83PtCrQk5JYAMKsjgPr+T2aBLVAW1g8bKB9uEGXKQUGz1HuZ9ykoIx xraK87GKDJaKfZKTBaEi7wTZ2gF6FJCmFvBW8dJFJaTh+fjoEGQpa+F7HfQQZy2MZ6Iw 9Qxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=dxvS3kwOW4bWC0xsZqNZINpijY+mWNOP8Io4oLdd84w=; fh=ShnMk0y3A6BB2SF8XQ8JBNpuAm+6hAPKiALDo7CAys8=; b=YfWxOZca+E3an+ZU/hjxxOG0dPP8WGvtPxZK3WxsWyEteOq1Ogt2+qspG0Y4I3Rfor HDDv9k4HrO9+zsQPcQCu+83LISEYYI9Y2sqk2HclDpVVTr3lyU9ACfiZkxE/q5ZhZzBU N44sMXByqIhY7N+4XI8XPPpyeTJdi3D5iBHYP8aRegoFGVNiuNulh+6d10B1l3zzQ/rz 9jXJ8DyFmY5xtgYhNjPtfPHT0lIqjM0vwHqK39GKkKCL/ed2coQKnBY2M/Pt30rSg5di gblxz5TvPcRYeGdWvEn6GbKL+trhau2PtEGvlLGq9dPzwpUcdzSF1/ZU4zsErrdX/Ska S+ew==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781734061; x=1782338861; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dxvS3kwOW4bWC0xsZqNZINpijY+mWNOP8Io4oLdd84w=; b=p47Xbk2qdEKP71XwL0AY+6LOQv9sWWMUSls9YNgeRkjHSjBa+v/g3QuF8NXjt2Lzc/ VHNErdQLsBfOeznG7geRMkQma6OhvGGLF1pamPgBe+DsENdnZgDV95ycFiL/Ymm/CiUs Bqph4+Th0BZbydlVJ5laBjYkSDC5aCJxXPYtLYlUL4osq+RysnLVdV98Q0ZMRoJ9Ns5C js4V02JxSIXeItYEUABSJNtQTOQ2KXtU6wQhaEXxIeiUr+zyefSPfg7AZTRSjtH4ETCW XMxka1O87DCUSu+qJY9ZU5lgdhowAh8SJ15gDt01BhRa7k5h7yYyx4Ta8v1nNDND1Gyd BE+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781734061; x=1782338861; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dxvS3kwOW4bWC0xsZqNZINpijY+mWNOP8Io4oLdd84w=; b=KmgjQeyvkz3PBMYy9+lWjm6FpI1S5cQaYIRMSC5wDmmVj2vQMez9efax692VciaQP7 /cmCveZsl5IbLIDheFAAgK60IFM2rcfzFS+lbEZSB57Z6tUW9OTM26yp2CYQZmwW5N5S 1y4de06KtV9G0JOPTBwmNpa4eguws06fM+TCwCnMGc9xqsh0bLZf0cIdCjrEGDPKGGIc bl2C151sQ1FaCoEQ+PSo+Q5nlGIfPJDFwxbzK8a5pJYMDc+mpxC6QUIZlGkAtDkFJ6vw c1FUe7BX7Pm62Ny1GAT6lz8yP3Yz4xFXisKnGJL/APkh+6BNWg/1RcmPP7cF7tyoQ588 +y0A== X-Forwarded-Encrypted: i=1; AFNElJ/lZkt33T6FpTS3AkjxCCsx8b8XaOIvYpOHmzKeOfC/XWR4S/2AA2Dsw/OHgYe4rw4L0pYNxOFQduOHWg0=@vger.kernel.org X-Gm-Message-State: AOJu0YzleMsY0jDjGsZspVCavTzBkfC/zEOgHCTrh8PafvElbFRS7ZzO dqvDFzIXBY5k1On6SxuWZCg2TgLAsoo/67oQAV3Zheg4u7Myu06o/IwgWJzE3TU7SOPSfiTh6Jx e+8eB8+xgzC5NbYqm8l+sU+zTPOGa7cT11ShlhM6k X-Gm-Gg: Acq92OE+uP/aMmOBhsG5irkpt7Ta/BTO+7DV2+yabI2DFsoEJO0R1v0p7MGzHpObWZ6 sQe3z/wOPj14xYNY4PNBehp/i+Jk5EL2uKucAB4qZVDFMSdP4/bLpItJ4WiyPWuDIO5gjB8rWi4 A4gMd8dHH/yn5W/IN3CP7L5zhW268rMKcVcoQs90Fr/4/uosHIfvnt7yaWL60IQUT2ELJTN9s7R KZ34Jl7/WXFRaXT6KX8GUIiTxrCOFLso5BUwxlp7c+46+PyCK0wMHfqNQfWHCrgTYk5CwhZ50z+ ORnLTrI= X-Received: by 2002:a05:7022:68a2:b0:130:6c8f:5a87 with SMTP id a92af1059eb24-1398f676be1mr2746710c88.13.1781734060068; Wed, 17 Jun 2026 15:07:40 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260522202410.3104264-1-dmatlack@google.com> <20260522202410.3104264-4-dmatlack@google.com> <178144432039.1257322.9644414453415904478.b4-review@b4> In-Reply-To: From: David Matlack Date: Wed, 17 Jun 2026 15:07:13 -0700 X-Gm-Features: AVVi8CfIvfIjd2Q6o3VPNKmTcz60wFd9tOmavE8DEafzVsI6S2ukw3P-Cv2hKdA Message-ID: Subject: Re: [PATCH v6 03/12] PCI: liveupdate: Track incoming preserved PCI devices To: Pasha Tatashin Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Adithya Jayachandran , Alexander Graf , Alex Williamson , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Leon Romanovsky , Lukas Wunner , Mike Rapoport , Parav Pandit , Pranjal Shrivastava , Pratyush Yadav , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Vipin Sharma , William Tu , Yi Liu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jun 15, 2026 at 1:29=E2=80=AFPM David Matlack = wrote: > On 2026-06-14 01:38 PM, Pasha Tatashin wrote: > > On Fri, 22 May 2026 20:24:01 +0000, David Matlack = wrote: > > > +static struct pci_flb_incoming *pci_liveupdate_flb_get_incoming(void= ) > > > +{ > > > + struct pci_flb_incoming *incoming =3D NULL; > > > + int ret; > > > > Maybe make the error return static, and avoid another search through co= mpatible > > FLBs if it failed before? > > Good idea, will do. Actually I'm not so sure this should be handled her. I would have to create a statically allocated variable to cache the result, like you said, and I would also have to invalidate it during FLB finish to avoid use-after-free. That defeats one of the main benefits of FLB which is that we don't have to manage global variables. Can this be handled by LUO instead?