From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759261AbcGKOo0 (ORCPT ); Mon, 11 Jul 2016 10:44:26 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:36663 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759191AbcGKOoW (ORCPT ); Mon, 11 Jul 2016 10:44:22 -0400 MIME-Version: 1.0 In-Reply-To: <577E32E5.4010902@samsung.com> References: <1467750561-13957-1-git-send-email-a.kesavan@samsung.com> <1467750561-13957-2-git-send-email-a.kesavan@samsung.com> <577E32E5.4010902@samsung.com> From: Abhilash Kesavan Date: Mon, 11 Jul 2016 16:44:21 +0200 Message-ID: Subject: Re: [PATCH v3 1/2] clk: samsung: cpu: Prepare for addition for Exynos7 CPU clocks To: Sylwester Nawrocki Cc: Tomasz Figa , Kukjin Kim , =?UTF-8?Q?Krzysztof_Koz=C5=82owski?= , Bartlomiej Zolnierkiewicz , Michael Turquette , Stephen Boyd , linux-samsung-soc , linux-clk@vger.kernel.org, linux-arm-kernel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sylwester, On Thu, Jul 7, 2016 at 12:45 PM, Sylwester Nawrocki wrote: > On 07/05/2016 10:29 PM, Abhilash Kesavan wrote: >> Exynos7 has the same CPU clock registers layout as that present >> in Exynos5433 except for the bits in the MUX_STAT* registers. >> Add a new CLK_CPU_HAS_MODIFIED_MUX_STAT flag to handle this change. > >> --- a/drivers/clk/samsung/clk-cpu.h >> +++ b/drivers/clk/samsung/clk-cpu.h >> @@ -63,6 +63,8 @@ struct exynos_cpuclk { >> /* The CPU clock registers have Exynos5433-compatible layout */ >> #define CLK_CPU_HAS_E5433_REGS_LAYOUT (1 << 2) > >> +/* Exynos5433-compatible layout with different MUX_STAT register bits */ >> +#define CLK_CPU_HAS_MODIFIED_MUX_STAT (1 << 3) > > It's getting a bit messy, what if there comes another SoC version > which has some other modification of exynos5433 registers structure? > We would need another variant of HAS_MODIFIED_MUX_STAT flag and we > could easily get lost while trying to determine which modification > is which. How about indicating explicitly it's an exynos7 bits > layout and renaming the flag to something like > > #define CLK_CPU_HAS_E7_MUX_STAT (1 << 16) ? Will rename the flag to make it SoC specific as per your suggestion. Regards, Abhilash