From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3687AC4741F for ; Fri, 25 Sep 2020 13:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D382A2086A for ; Fri, 25 Sep 2020 13:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601041509; bh=sbFocIhAQZjpAENHw364o+aMVOdGovkNbpBVkmudxP4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=o2zQJn3m20EM7b6XIupokkPLl9YcDCjDoAWCdwWwehLlQeAR+TuvdwvamCLWa5rKe oTQeX+p4U6n1vzG83uRbJ7BPITJmCAaEap7pu5aOF52eAhiGuvzrihDEQJduurmAEB Fc2XkKZf4EJ67wukXq7VupIV4al6bSW5kybvbo8k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728925AbgIYNpH (ORCPT ); Fri, 25 Sep 2020 09:45:07 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45170 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728878AbgIYNpG (ORCPT ); Fri, 25 Sep 2020 09:45:06 -0400 Received: by mail-wr1-f66.google.com with SMTP id x14so3629066wrl.12 for ; Fri, 25 Sep 2020 06:45:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NlhR3B1xTrFJPN7Yr45TLDcNvoWGlkYDRnyFJmu7snU=; b=FGUMSa4TdWu9DxstvjiaD50mwiA1BQsfBA+I3zXt+gZECukzdXpFDYCUrivQh/ygOd wt/jV1Ndfj1+En0+R1+WUE2WZkXGmqr52VcqOicsf+9Dyxpfm6ucTxPPSLVlmIa2o1sT EnKEhrZd8lU4H131xGHS6yK4XD5MVPL9geortpGLjmAGiWVxZnvCLxS00djImjYaCp4b s4V3TXeedKG3lwaFysLffjVnkH6qW2BmI3kv0khSxajhm7GpF/lcKEjQdTUXQBJuoNIl D2V26cDf0G2CfHko6goPxBAnqn3BFaRWrtWZntdpmoY0MvtUEXSk6+W/4D1giBucnSe1 eZlA== X-Gm-Message-State: AOAM530uh+dUPOuP9z/w+FSRpoMwXdKb5bSgV2MnoNChv8OomFGs9Xqs 1/VegbAbQPK9Xmvvy6/Y6iX7M3FaramVi0yy2pc= X-Google-Smtp-Source: ABdhPJyBN/va2EdeB5OsIq/sfsn5RsbVsveEfASKFe3flCATXtrdZgun9ebgeD0yMuKB1E/2zjvKHBnKG7WP4lwXGlE= X-Received: by 2002:adf:f2d0:: with SMTP id d16mr4437142wrp.332.1601041505066; Fri, 25 Sep 2020 06:45:05 -0700 (PDT) MIME-Version: 1.0 References: <20200924124455.336326-1-namhyung@kernel.org> <20200924124455.336326-4-namhyung@kernel.org> <20200925132636.GB3273770@krava> In-Reply-To: <20200925132636.GB3273770@krava> From: Namhyung Kim Date: Fri, 25 Sep 2020 22:44:53 +0900 Message-ID: Subject: Re: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Mark Rutland , Alexander Shishkin , LKML , Stephane Eranian , Andi Kleen , Ian Rogers , John Garry , Kajol Jain , kernel test robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 10:26 PM Jiri Olsa wrote: > > On Thu, Sep 24, 2020 at 09:44:53PM +0900, Namhyung Kim wrote: > > SNIP > > > > > + if (metric_events) { > > + orig_metric_events = *metric_events; > > + rblist__init(metric_events); > > + } else { > > + rblist__init(&orig_metric_events); > > + } > > + > > for (;;) { > > p = strchr(str, ','); > > e = p ? p : eos; > > @@ -255,6 +267,14 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str) > > cgroup__put(cgrp); > > nr_cgroups++; > > > > + if (metric_events) { > > + perf_stat__collect_metric_expr(tmp_list); > > + if (metricgroup__copy_metric_events(tmp_list, cgrp, > > + metric_events, > > + &orig_metric_events) < 0) > > + break; > > + } > > looks good, do you plan to actualy add support for record? No actually, I still think perf record should use --all-cgroups. > my ack from last version stays Thanks! But I didn't see your ack for this patch set. (I've only seen it for the perf inject patchset..) Thanks Namhyung