From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08526C433F5 for ; Thu, 28 Apr 2022 23:50:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353442AbiD1Xxj (ORCPT ); Thu, 28 Apr 2022 19:53:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353427AbiD1Xxg (ORCPT ); Thu, 28 Apr 2022 19:53:36 -0400 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 839062F3BF for ; Thu, 28 Apr 2022 16:50:20 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id v4so8609238ljd.10 for ; Thu, 28 Apr 2022 16:50:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kUjBUCzeqZKhIWOyMkHvOLbfBtVZqVfOxb5rIGsiSW8=; b=t8mLtVv0eOz5KcTUcsrdktjYH1bdgNWWyUARNzYbqQp505GEYbYALaDe8VJqSKd6hu w1cUcG194OKKbbKk8dtji6PHWkr5ffGoF4qDh1AAfGICyZ2GwnJr1T37SpUzQW1dfDVb IETK3t7PWFZ0D3JJ8HQHapN0EaH8HmvQ87XZWXskVBCbrZc2BsMWjBN4Dl9G2jd0z1hv +Mh9LvpGKkQWb+BoHaomOwhLHiC3RSU5LXwJnAdoEs66RdYA3zsriLNHDhW6ziJ48/yU nJ68m1qRTt3QtwNa1Lio4Aio52/ZVljtXxhHSjWfobc/opkkfxuXb7rBPy1TO7/FvD0k To9Q== X-Gm-Message-State: AOAM531QAB1BoP2UHfdc/bzX4jwTreuYxpgGzd+3z4uAD8N01IOyYnLE XS9d7h8JtFtZL/HNPqpxcnOX6gqb6w1VRY3SEYF9vMvp X-Google-Smtp-Source: ABdhPJydsD6t3NSfOwuXfCnF9DIF6qIXUSN49rbNOkoz39MmXNMyt7R2R2niDMzc154F22NGB1e5CHQPTwgSRa8lkjM= X-Received: by 2002:a2e:1613:0:b0:24f:2ee0:351a with SMTP id w19-20020a2e1613000000b0024f2ee0351amr4859409ljd.180.1651189818699; Thu, 28 Apr 2022 16:50:18 -0700 (PDT) MIME-Version: 1.0 References: <20220422162402.147958-1-adrian.hunter@intel.com> <20220422162402.147958-3-adrian.hunter@intel.com> <7a8447da-9a3f-da37-93de-dacab5b79211@intel.com> In-Reply-To: <7a8447da-9a3f-da37-93de-dacab5b79211@intel.com> From: Namhyung Kim Date: Thu, 28 Apr 2022 16:50:07 -0700 Message-ID: Subject: Re: [PATCH RFC 02/21] libperf evsel: Add perf_evsel__enable_thread() To: Adrian Hunter Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Ian Rogers , Alexey Bayduraev , Leo Yan , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2022 at 9:15 PM Adrian Hunter wrote: > > On 28/04/22 00:48, Namhyung Kim wrote: > > Hi Adrian, > > > > On Fri, Apr 22, 2022 at 9:24 AM Adrian Hunter wrote: > >> > >> Add perf_evsel__enable_thread() as a counterpart to > >> perf_evsel__enable_cpu(), to enable all events for a thread. > >> > >> Signed-off-by: Adrian Hunter > >> --- > >> tools/lib/perf/evsel.c | 10 ++++++++++ > >> tools/lib/perf/include/perf/evsel.h | 1 + > >> 2 files changed, 11 insertions(+) > >> > >> diff --git a/tools/lib/perf/evsel.c b/tools/lib/perf/evsel.c > >> index 20ae9f5f8b30..2a1f07f877be 100644 > >> --- a/tools/lib/perf/evsel.c > >> +++ b/tools/lib/perf/evsel.c > >> @@ -360,6 +360,16 @@ int perf_evsel__enable_cpu(struct perf_evsel *evsel, int cpu_map_idx) > >> return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_ENABLE, NULL, cpu_map_idx); > >> } > >> > >> +int perf_evsel__enable_thread(struct perf_evsel *evsel, int thread) > >> +{ > >> + int err = 0; > >> + int i; > >> + > >> + for (i = 0; i < xyarray__max_x(evsel->fd) && !err; i++) > >> + err = perf_evsel__ioctl(evsel, PERF_EVENT_IOC_ENABLE, NULL, i, thread); > > > > You might want to break the loop when it fails. > > Thanks for looking at this. It should break because of " && !err". Oh, I missed that part, sorry! Thanks, Namhyung