mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Pereira <danielmaraboo@gmail.com>
To: sashal@kernel.org, corbet@lwn.net
Cc: skhan@linuxfoundation.org, rdunlap@infradead.org,
	 workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	 linux-kernel@vger.kernel.org, brads@mainlining.org,
	 gregkh@linuxfoundation.org, linux@leemhuis.info, mst@redhat.com,
	 error27@gmail.com
Subject: Re: [PATCH v4] docs: submitting-patches: say which commit a Fixes tag names
Date: Sun, 25 Oct 2026 11:21:21 -0300	[thread overview]
Message-ID: <CAMAsx6ch8bztwO2w+gA1xc2H8JEM-7haUd05dmyODN_=VWJ74A@mail.gmail.com> (raw)
In-Reply-To: <20261020142534.3533478-1-sashal@kernel.org>

On Tue, Oct 20, 2026, Sasha Levin wrote:
> +Name the commit that introduced the bug. When using ``git blame`` to find it,
> +do not settle on a commit that only moved the code. If a later commit exposed
> +an older bug, add a Fixes: tag for that commit too. If the same bug was
> +introduced separately by more than one commit, add a Fixes: tag for each.

Hi Sasha,

I went through v4 against the tree (docs-next at f857ff5bf):

- the new paragraph sits between the description of the Fixes: tag and
the existing "Note:" about the stable rules, and reads well there;
- handling-regressions.rst does ask for this ("Add a "Fixes:" tag to
specify the commit causing the regression"), so the reference in the
changelog is accurate;
- I built the process documentation with the patch applied and it adds
no new warnings.

One thing for information only: checkpatch --strict reports the
"Assisted-by: LLM" trailer ("Non-standard signature" and "Unrecognized
email address: 'LLM'"), because Documentation/process/ in docs-next does
not describe that tag. If it is defined in the agents series or in
another tree, please ignore this.

Reviewed-by: Daniel Pereira <danielmaraboo@gmail.com>

Thanks,
Daniel

  reply	other threads:[~2026-10-25 14:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 14:25 Sasha Levin
2026-10-25 14:21 ` Daniel Pereira [this message]
2026-11-02 16:24 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMAsx6ch8bztwO2w+gA1xc2H8JEM-7haUd05dmyODN_=VWJ74A@mail.gmail.com' \
    --to=danielmaraboo@gmail.com \
    --cc=brads@mainlining.org \
    --cc=corbet@lwn.net \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=mst@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=sashal@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®