From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FF633714C for ; Thu, 8 Feb 2024 19:48:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707421723; cv=none; b=MpckdFnbylUKZh0r4ZffbE0or0OUuTvzEce362atVC6bB4zegtJl5asaNGaDypILuw0TGZ7LU562TN6SEPO8lMBAB4ZNYgxx+ASlyRDGujxCL+/sfP/XQ4Q/hZ4RiDBjnE+1SDwak8DFBnVWSbF7Hcmu0vQMwxAYFDd3R1LvvZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707421723; c=relaxed/simple; bh=QRHcsfNL5CodrBloEE4Fot31u6FMaHiMM28bKZysteY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=JdXdfwVJwL5xXZYPYRFcMn58RksK0tgZ9G9fGzugR9nhAXkXnKGd940e+xrdRFjTW9LPzOIL7SVhWk63hbvKDtQQw3gMw7xKmnMolDIxgMlzU6ti+O0GW4vjq+0cSJ0DTFWEYC0U1RUt2P/n/bjZj41Usaq+IpqU7vQq0C1R9mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WmFpBefF; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WmFpBefF" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-40ef9382752so103665e9.0 for ; Thu, 08 Feb 2024 11:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707421720; x=1708026520; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0o3ZX+cYKVcvLxzGSXiG/iTbM06IS54gjI2VxBYvRQQ=; b=WmFpBefFfkZZ9ZjvABNEvdDOkxlO1c87CBrbzhYQnkbeQbfG7Lo8jusUCajauY2Mtz B/xgIgVce59JHg1b6MZA76IHWs5IgAviUlc3VfTdKoRm8s0q8y9xH0Hl9stg0lnMkPOz +vXSOkLblssh5RCkhAsuZGEWuJeXvARk5IwgndcavQjxyVKAO3zOQ/UyTmWBIflR4quT MLiCXRjVa2b4vOq3WzcjifG4oe9cdOi7g0acXQdQfsgbnGyDswV16nuP/Pqy7WrYDIPH llrPYqgzsw0MnbRR9g/zMozvQjHbmm7mohBTdMKPkr8SnZIW6he3gFd5CWC/fzot9dRx R5gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707421720; x=1708026520; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0o3ZX+cYKVcvLxzGSXiG/iTbM06IS54gjI2VxBYvRQQ=; b=sDlh/3iSULSvvY/0APlUygw7czIKcIfe1DtCnpgVRnPGIOfV4D+E61dywgUWPzdjh9 MBAoAd07tXls3Y3IgPrL0WwEw0w9bofjnn8QubaJvZWDy941vEfLQYP0ZAYx3Pir2X4O qqClb+PlvhzUcz0EH+U5TprfpABOlUyiqcC4M3Lik+4vNcHsE4h21PPONCpBdj3kap2k oJquHahlf2fQpkipn+SEAvgMdT7CYNvddaUYuXfuirXRZ9U5jcyk83QDALjPMeku7bVm m2nIrbs/eT9B9UP/cTXYI+DRSq6ZEk3qL5v83EAb/PBDzf7LG4C4w4ZozjGJr0wAX2+Z KQrA== X-Forwarded-Encrypted: i=1; AJvYcCWatBGb4Cr5tdIfo+kXbp9CASyscGnOq4GbOtO26QAy4cp6+dD0nGfKXfaoqfM6EbzVs8b32+5kB7BCjaubYLvrkYx5vNq9BQltQJDu X-Gm-Message-State: AOJu0YzL0l0SD+cDmg+YWyYRXqxlztfhZZFq0YZh0fQMNr6ceK3PPeq5 WhxvHe5ImXV+mqFMZUW22NE5sV4dO6ADL3srzX8LZpqGVeu0uLrKKBCCMa6e4tarhduzu/LAE1q M1+jtbgnOk1I4em9KhTUTJOTwc5Mw2p4mgU1g X-Google-Smtp-Source: AGHT+IEXamVgx0wZWlhAd5Fj3QmrOnuWMtU8C9KH0ASLbQMIPjYokiSlmVY0iMyuos0B8k3rP6Ck4ssoLiC5dnkJmi8= X-Received: by 2002:a05:600c:1e08:b0:410:2267:47c7 with SMTP id ay8-20020a05600c1e0800b00410226747c7mr25521wmb.3.1707421720329; Thu, 08 Feb 2024 11:48:40 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240125004456.575891-1-abhishekpandit@google.com> <20240124164443.v2.2.I3d909e3c9a200621e3034686f068a3307945fd87@changeid> In-Reply-To: <20240124164443.v2.2.I3d909e3c9a200621e3034686f068a3307945fd87@changeid> From: Jameson Thies Date: Thu, 8 Feb 2024 11:48:28 -0800 Message-ID: Subject: Re: [PATCH v2 2/3] usb: typec: ucsi: Update connector cap and status To: Abhishek Pandit-Subedi Cc: Heikki Krogerus , linux-usb@vger.kernel.org, pmalani@chromium.org, Abhishek Pandit-Subedi , Dmitry Baryshkov , Greg Kroah-Hartman , Neil Armstrong , Rajaram Regupathy , Saranya Gopal , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Abhishek, > +#define UCSI_CONCAP_FLAG_PARTNER_PD_MAJOR_REV_AS_BCD(_f_) \ > + (UCSI_CONCAP_FLAG_PARTNER_PD_MAJOR_REV(_f_) << 8) Can you replace this with a common HEADER_REV_AS_BCD macro that can be used for both GET_CONNECTOR_CAPABILTY and GET_CABLE_PROPERTY? Also, the USB PD major revision value in the message header is one less than the revision (PD Spec section 6.2.1.1.5). So, we need to add 1 before shifting. Thanks, Jameson