From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406AbeBVAAO (ORCPT ); Wed, 21 Feb 2018 19:00:14 -0500 Received: from mail-yw0-f193.google.com ([209.85.161.193]:33197 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbeBVAAM (ORCPT ); Wed, 21 Feb 2018 19:00:12 -0500 X-Google-Smtp-Source: AH8x227C+hP47bV1XeD7jckJ7/jzNGc+Hv0TBu5qEqV/DV6vWNG81pZdjKHwXmeMELlbgc+DYJxFRYEu5+F+JolfREU= MIME-Version: 1.0 In-Reply-To: <20180221170748.27505-2-enric.balletbo@collabora.com> References: <20180221170748.27505-1-enric.balletbo@collabora.com> <20180221170748.27505-2-enric.balletbo@collabora.com> From: Gwendal Grignou Date: Wed, 21 Feb 2018 15:59:51 -0800 X-Google-Sender-Auth: hHUIULmQFwdKB1yFnIuVqejn2po Message-ID: Subject: Re: [PATCH v2 1/6] platform/chrome: cros_ec_sysfs: Modify error handling To: Enric Balletbo i Serra Cc: Lee Jones , Benson Leung , Linux Kernel , kernel@collabora.com, Guenter Roeck , Gwendal Grignou , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 21, 2018 at 9:07 AM, Enric Balletbo i Serra wrote: > From: Gwendal Grignou > > When accessing a sysfs attribute, if the EC command fails, -EPROTO is > now returned instead of an error message as it is unlikely an app is > parsing the error message to do something meaningful. > Also, this patch makes use of cros_ec_cmd_xfer_status() instead of > cros_ec_cmd_xfer() so an error message is printed in the syslog. > > Signed-off-by: Gwendal Grignou > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Gwendal Grignou > --- > Changes since v1: > - None > > drivers/platform/chrome/cros_ec_sysfs.c | 25 ++++--------------------- > 1 file changed, 4 insertions(+), 21 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c > index da0a719d32f7..c03621e523a3 100644 > --- a/drivers/platform/chrome/cros_ec_sysfs.c > +++ b/drivers/platform/chrome/cros_ec_sysfs.c > @@ -114,15 +114,9 @@ static ssize_t store_ec_reboot(struct device *dev, > msg->command = EC_CMD_REBOOT_EC + ec->cmd_offset; > msg->outsize = sizeof(*param); > msg->insize = 0; > - ret = cros_ec_cmd_xfer(ec->ec_dev, msg); > - if (ret < 0) { > + ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg); > + if (ret < 0) > count = ret; > - goto exit; > - } > - if (msg->result != EC_RES_SUCCESS) { > - dev_dbg(ec->dev, "EC result %d\n", msg->result); > - count = -EINVAL; > - } > exit: > kfree(msg); > return count; > @@ -150,17 +144,11 @@ static ssize_t show_ec_version(struct device *dev, > msg->command = EC_CMD_GET_VERSION + ec->cmd_offset; > msg->insize = sizeof(*r_ver); > msg->outsize = 0; > - ret = cros_ec_cmd_xfer(ec->ec_dev, msg); > + ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg); > if (ret < 0) { > count = ret; > goto exit; > } > - if (msg->result != EC_RES_SUCCESS) { > - count = scnprintf(buf, PAGE_SIZE, > - "ERROR: EC returned %d\n", msg->result); > - goto exit; > - } > - > r_ver = (struct ec_response_get_version *)msg->data; > /* Strings should be null-terminated, but let's be sure. */ > r_ver->version_string_ro[sizeof(r_ver->version_string_ro) - 1] = '\0'; > @@ -255,14 +243,9 @@ static ssize_t show_ec_flashinfo(struct device *dev, > msg->command = EC_CMD_FLASH_INFO + ec->cmd_offset; > msg->insize = sizeof(*resp); > msg->outsize = 0; > - ret = cros_ec_cmd_xfer(ec->ec_dev, msg); > + ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg); > if (ret < 0) > goto exit; > - if (msg->result != EC_RES_SUCCESS) { > - ret = scnprintf(buf, PAGE_SIZE, > - "ERROR: EC returned %d\n", msg->result); > - goto exit; > - } > > resp = (struct ec_response_flash_info *)msg->data; > > -- > 2.16.1 >