From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2CD51A9FAF for ; Thu, 2 Jul 2026 00:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.224.50 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782953246; cv=pass; b=fz3/QX859nEx0wz17auKKwmpsFPHYHTXqxSSU4a9J9HaJmF0lZOkpLERQ0lLb+ROkm8oCWPPOlRTOyX5HX6IKswX5I+xpt8rqAhyOJVW1/Wi3lBf4yWc+8R81Yw1CEtadQ8k2uVOZ7in5t1lvld6ZKJ85CHoJ+nWxaWkp1VbxvQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782953246; c=relaxed/simple; bh=el5EsMRYWMvqhrLthyzhD5MTMKT3hUlrX8yq7m0op5U=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=q75xnH1WmLALwSn6mIRMKzqy9ss3G8kYctYiX+jOd7U1fnhxHvDsnka6URi5a+293CADy+GgMlqG9KfVINrpvF9ZypJKKEdd6DDwZblXVnwWVShH48G9Ee85lLc3chjNPvwdQRM6ZfknjG6LrdELMK1ukeCvzSxmRpaHL2w/oAE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lBpZpMnr; arc=pass smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lBpZpMnr" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-664d78637f8so1691422d50.3 for ; Wed, 01 Jul 2026 17:47:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782953245; cv=none; d=google.com; s=arc-20260327; b=bA8PMFLB3DIq7oh/qpMVoJGf+DzjP3VAVlrfoCp2MzNdVMCC/xKMASQOvXtfRpUu74 EXPVGbcVCm5moyP6nTRxl8syRoW69hiI0fKId4hMCrwurJ/c211sN8pZwUFCcBL9vNW0 WidEyNTK8EFlypC7Au6bSwbWqd/sZ29N1ZIQ39z+4k0SlbTzB7IgXeOHM9R5UAJXa+hX HGxH0Q52HBMKgzsAhIRvlF74jgefKTczoNTB0y367BQWCypXZCtU8B/2t+2X/PuKNgY+ 4OrVeUI0TQTBMXgBJPL9SZxbazCJDOkY2jxnbac5bjOLZxrEOmGhgDedU0pkHP9JjfIw UfLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=vCPFPx+PcZzcNHSg9tBDkwND2L6CeBxw+Ct/uPJnB/0=; fh=XRV+IDa5kAu+1Q+4F9OTn+KQklRoJlGnqVydpy4WjC4=; b=shh4aiuwflUXyrhltBXyGO75zqjsfjemEB1oMhFG4RO2euwiszy6C2ZzcNv4siMeCP eTnSbyBwD/XZ+OOvSiyBDMrnTRpDDFDzExTlEA/w4bbNQM/pFvUl2LozaQSj6wny1ASb CC4Ghx4PCdEfcoN8uO+zxwV7Nb/kpXZRDfeai/9ogFUTDMIJwUwCuPKuJiIGp8oD9loZ Q8rVP7N3jzpW5QQr23slOmOIAjbaoKS5qikWAmwgxr+Hoy5UPfa3E5zqHJUmbZR+drtF +zt/zoKwqYU1ZIJIwASzxgXHeUKIjC7AqweW2r2MMkU9IqhQ5jTIFFSxB2lD+rao788F 8q/Q==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782953245; x=1783558045; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vCPFPx+PcZzcNHSg9tBDkwND2L6CeBxw+Ct/uPJnB/0=; b=lBpZpMnr2Me2D7FRHCm2EGLx4h/AQfGnPdff+m/hei2R3O+F4Aamrb3zDw73cX+Ej7 nloimyD3XFR0YoUozpdyAhKyMreTP0BsjNk4Bc+wDhGblMJiXunRseIm1/9+CiLHvc/t ajGhrmd+EA7WLRkLRjo9sR/sdUgpdx4MoDDVMIIWs7PlBmRPbGFUqCt5cZ11j3yvdfp7 bnIc3BpJOEhZSTi7fFvl8caZdF9EgTrZ2zdcxe9NknmzQZJAM5fnAI26BusqVlaXy7kI OiscJog3CBPmkYY6jSQ7I54RMnq1AIVpWYFcz+W9AZMhhsFrQUiiKzQonqUMbsmchc2F PTkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782953245; x=1783558045; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vCPFPx+PcZzcNHSg9tBDkwND2L6CeBxw+Ct/uPJnB/0=; b=UULNcef1NrGcb8mkzbvubx2a7ScfPaKiw06/4rCv4E9lVZG0me/uoGEBudn6d9hfBT FtTfKujcM1VZMNiWQDREqF3v47Hg3G54SLNmq/h7WLwUAt8Iv5eEIVr4R3CVOcXq4utn 3S1TlOAq7OJw87CjS8kvnLMpAnfV+mZwcRLEIDZUM9iwEGVX8goefxPkqfM40lNFmNP6 nCcMfmb9wNsV1ttJzDhrFDZqhCQhVFA2viB/f2+4lfOjQh9Sm2mobZKzHA4JBZUsE+29 XbmlKf7UGUqDbs/TSmi4k51RI89wn1WLxNWnaBuds/DhfTXE7TmyMu8F2ySRsjRxESKk u+6g== X-Forwarded-Encrypted: i=1; AHgh+Ro5jHfYMh/T7fgwIEqMjtM6Bfb2548hBiZnk5afmguTLC2aeeXMh2oM7Pj6Lqt+WCkSQNW843n5Y2mpZ8A=@vger.kernel.org X-Gm-Message-State: AOJu0Yw962r1IW9G1zPffKfsObqR24MdpIFFjG+DVrCiN0EWfuioat5X BbaRQwbLnStuLmFAeOw2J/+XF06q/JMUeOy9iOPSaKU5oWhfhi3JNGkwH5GmOO2ZoMlmg6JIy8k wluusPhR3UJlF2t6HNV+YCp3gGq+ij8I= X-Gm-Gg: AfdE7cn0eHfiIEtUUAuoS6z1zv/OMmtLzhSj+jeJ545Qr5aojuN+yztxL/zJhUAiJef b5lggxLnYsFOEDxyI4GooYNguV3i1mz6kMQfLPvKK7PPd0exwc6yYPOR1V4mXi99KlCawLo9F+2 gMGULt/qHGG4XEsp6xidiUxyiuJnPVT8ucoleJrDLl/EzkyXT9a48GS0xDm0x65ElMsKX0sPhfi pBfaY2LFNsLj2AGH6PBHJrB+UNLesixkRWExOaoxLQAms8ysuddyeOIezd4KII1UxZZt5gsmamB etxwHyGNt9NWh9l8DGaxvjomWAUvLQlc/RsVlnIFwlQOd9g3qm9RrRJjvkA= X-Received: by 2002:a05:690e:1685:b0:664:e8ac:21cd with SMTP id 956f58d0204a3-66521a9939fmr3721690d50.25.1782953244651; Wed, 01 Jul 2026 17:47:24 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260701122246.2451-1-mhun512@gmail.com> In-Reply-To: <20260701122246.2451-1-mhun512@gmail.com> From: Alex Henrie Date: Wed, 1 Jul 2026 18:46:00 -0600 X-Gm-Features: AVVi8CdfCP7TKSk1Ku8iKCpyX5RUTT9yUb-rTvsI1071-8rips69S_lX9CQHxt4 Message-ID: Subject: Re: [PATCH] USB: misc: uss720: unregister parport on probe failure To: Myeonghun Pak Cc: Greg Kroah-Hartman , Oliver Neukum , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ijae Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 1, 2026 at 6:23=E2=80=AFAM Myeonghun Pak wr= ote: > > uss720_probe() registers a parport before reading the 1284 register used > to detect unsupported Belkin F5U002 adapters. If get_1284_register() > fails, the error path drops the driver private data and the USB device > reference, but leaves the parport device registered. > probe_abort: > + if (pp) { > + priv->pp =3D NULL; > + parport_del_port(pp); > + } > kill_all_async_requests_priv(priv); > kref_put(&priv->ref_count, destroy_priv); > return -ENODEV; I think it would make more sense to set priv->pp to NULL and call parport_del_port(pp) right before the second `goto probe_abort` instead of calling parport_del_port in probe_abort. That would avoid the need for checking whether pp is null before cleaning it up. Is this just a memory leak, or is there some visible negative consequence to not cleaning up the struct parport on failure? -Alex