mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	 Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	Linus Walleij <linusw@kernel.org>,
	 linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 3/3] gpio: shared: allow sharing a reset-gpios pin between reset-gpio and gpiolib
Date: Tue, 6 Jan 2026 13:25:29 +0100	[thread overview]
Message-ID: <CAMRc=MdVs4Lu11XuDTassdGrdM+RLSAN=9tjO2ZLHZsT3fGY-Q@mail.gmail.com> (raw)
In-Reply-To: <9948f635-b753-44cf-8977-7fee4cfb6e3d@sirena.org.uk>

On Tue, Jan 6, 2026 at 1:21 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Jan 05, 2026 at 12:50:22PM +0100, Marek Szyprowski wrote:
> > On 22.12.2025 11:01, Bartosz Golaszewski wrote:
> > > We currently support sharing GPIOs between multiple devices whose drivers
> > > use either the GPIOLIB API *OR* the reset control API but not both at
> > > the same time.
>
> > This patch landed in linux-next as commit 49416483a953 ("gpio: shared:
> > allow sharing a reset-gpios pin between reset-gpio and gpiolib"). In my
> > tests I found that it breaks booting and triggers warnings on some of my
> > test boards. Reverting it on top of next-20260105 fixes those issues.
> > Let me know if I can help debugging this issue.
>
> Not sure if it's this specific patch (one of the bisects identified it,
> but I'm seeing others going to the merge commit for the gpio fixes
> branch) but I'm also seeing issues with gpios.  pwrseq is affected on
> several platforms after backtraces that look a lot like the one that
> Marek is seeing on Raspberry Pi 3B+ (which I also see).  This breaks at
> least the WiFi:
>
> [   13.475670] platform wifi-pwrseq: deferred probe pending: pwrseq_simple: reset control not ready
>
> Raspberry Pi 4:
>
>    https://lava.sirena.org.uk/scheduler/job/2335022#L1200
>
> Toradax Mallow (TI K3):
>
>    https://lava.sirena.org.uk/scheduler/job/2335415#L1457

Hi! These two should be fixed by the following series:

https://lore.kernel.org/all/20260106-gpio-shared-fixes-v2-0-c7091d2f7581@oss.qualcomm.com/

Could you please give it a try and possibly add your T-b?

Bart

  reply	other threads:[~2026-01-06 12:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-22 10:01 [PATCH 0/3] gpio: shared: close remaining gaps Bartosz Golaszewski
2025-12-22 10:01 ` [PATCH 1/3] gpiolib: allow multiple lookup tables per consumer Bartosz Golaszewski
2025-12-22 10:01 ` [PATCH 2/3] gpio: shared: verify con_id when adding proxy lookup Bartosz Golaszewski
2025-12-22 10:01 ` [PATCH 3/3] gpio: shared: allow sharing a reset-gpios pin between reset-gpio and gpiolib Bartosz Golaszewski
     [not found]   ` <CGME20260105115023eucas1p1af1f8e80041f94843beb664966894fb9@eucas1p1.samsung.com>
2026-01-05 11:50     ` Marek Szyprowski
2026-01-05 12:28       ` Bartosz Golaszewski
2026-01-05 17:26         ` Marek Szyprowski
2026-01-05 18:16           ` Marek Szyprowski
2026-01-06 10:55             ` Bartosz Golaszewski
2026-01-05 15:53       ` Bartosz Golaszewski
2026-01-06 12:21       ` Mark Brown
2026-01-06 12:25         ` Bartosz Golaszewski [this message]
2026-01-08 15:46   ` Mark Brown
2026-01-08 15:52     ` Bartosz Golaszewski
2026-01-08 16:29       ` Mark Brown
2026-01-08 18:04         ` Bartosz Golaszewski
2026-01-02  9:34 ` [PATCH 0/3] gpio: shared: close remaining gaps Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMRc=MdVs4Lu11XuDTassdGrdM+RLSAN=9tjO2ZLHZsT3fGY-Q@mail.gmail.com' \
    --to=brgl@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=broonie@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®