From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3531207A3B for ; Tue, 3 Dec 2024 20:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733259352; cv=none; b=WorwUp6YfJWPPx660f/9KgfQjf3ioNuDT49TcU3Y8WOw1Oio2LsOdHFwY2Jj0xOnvR+Tno73SPx00dzz6s2RYGF/PqYd5v6QpdK8k4x1tgDatro+CglxkSfErJYz9y63lzK3NLB3T2IiD4YsHqZ/4hYXCA/vK/hATIzSYNBU9qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733259352; c=relaxed/simple; bh=eLcYDxcnynl1D64i+3DMguwY4XPCJg81k3dnaDdJIbc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=jB/0esxYvnfMejJQ2/oG8iq8HuDx6jDpA4pn1jHGy26LTD2eF3auCE4vbjaS4QeeSmmdhNlHwJE++pliZAhQFHH/uMvtMDTPC26Jq7GC6MLJ8ZtyWpngqQ9TpkDR97aemvbHMy5j9S8rukvcmNJP0dRp8AZGUWC4S7Y+6pNbVVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=LAy3oHOW; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="LAy3oHOW" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2ffdbc0c103so85739211fa.3 for ; Tue, 03 Dec 2024 12:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1733259349; x=1733864149; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=itGnniQM+p/vJK3/mgQYD2qiAW1SyPNKjRN6TdQ/bi4=; b=LAy3oHOW7689Xu8hkfLCcn/zdcmseTsoMEnlCZ55MSsgTS7beqYRu9VZKYxsFKtIjj FozwZoBjThDrIw0DMmLViENMn34PLHJZ7FG4MaPOFBQgyzLoQthiRq2AHWqfGri4Qrwt NIQdwjswkT+lLmXOLWsbXiqpaTavzzp7uWpkbrvCCYsNc6pdwrrBTBn8eXCmGuqUs6uY f7IO756gTnoHWjbL6JttF0Kah6WP1hgIN30nZPCqZBkF+FHU52CuTrb02Jj+tTdCiYoV 3gig1jSpXZgdmASm/jh9nv6YuoGIB051fVOFwq2R1nGu2res8qWcKFtehClksOvU8umq 1ULg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733259349; x=1733864149; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=itGnniQM+p/vJK3/mgQYD2qiAW1SyPNKjRN6TdQ/bi4=; b=MnvFYw5Wi+SfhOkpnyC340W8FTasIPD6yZTA8HEv6SoFqJIY0b387YO30ZJenNk1Lj Kq4PlvBaVKCyPmh7k+e5cpAJSlpC+too3MnbKSA3awu+oKHQzKlDJuc5tN0mOwZLFIYw A2//6iXPGkEr3r6Req39Lc3lRlXjpy+olGg3wKiOaVDZZIoffZHlkSaK+oMpirodw0Hn DFR3tPcOjTGyVKk4apnjJewjorcA7Yj8pQJBmOfflIsdVlGPiw+7JaYtQe8CxWiPhfea BV36SucxuPfR+buFiJHWSm+bnPIRBtDHV/sZZVJZPYjoCNDClz+3JVWF3I7PMEsTZFSc JP4g== X-Forwarded-Encrypted: i=1; AJvYcCUMEzIdrdsB9xLfvpv+N15oLYR8pvaFa5u2AR1N3w7E3gHKAtgTdkXZuUgxA6ls95NyQONPS5dM2bAUGJs=@vger.kernel.org X-Gm-Message-State: AOJu0YxL5NA0ynEu9V4nOeJ/QZlzbHV546qXc/j3wxOYR43/B5xRhx6A 4OpxXOEGkkxJCXLbXfY8vyroAWOM+FnmDrnBkJVzASh5rOHq9ML4bo26fZqLkVGp8KrFYsgCWu5 KmvbqLp1h4m0rlrZSthhea4CUGBGwK4FokPdLKg== X-Gm-Gg: ASbGncu98brxcROKn8aQ2+hlmuLgcg+o6On2kM4o+81HIyt61HxDOeByIaS0OHg8LOD CVz1Uv0U1JeiuDiFo/t+RtRSFAY15qqs= X-Google-Smtp-Source: AGHT+IG067Jk4LL3da1h5lHM6wFo0Vn15+FnIBImO91v0eGyNeKMO06aLWq6wdCh9MkvyOn+7a+4HaMe26FA43Y2k1A= X-Received: by 2002:a05:651c:19ac:b0:2ff:c8a1:c4c9 with SMTP id 38308e7fff4ca-30009c46233mr36458081fa.1.1733259348900; Tue, 03 Dec 2024 12:55:48 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241203-crypto-qce-refactor-v1-0-c5901d2dd45c@linaro.org> <20241203173503.GA1510@sol.localdomain> In-Reply-To: <20241203173503.GA1510@sol.localdomain> From: Bartosz Golaszewski Date: Tue, 3 Dec 2024 21:55:37 +0100 Message-ID: Subject: Re: [PATCH 0/9] crypto: qce - refactor the driver To: Eric Biggers Cc: Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov , linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 3, 2024 at 6:35=E2=80=AFPM Eric Biggers w= rote: > > On Tue, Dec 03, 2024 at 10:19:28AM +0100, Bartosz Golaszewski wrote: > > This driver will soon be getting more features so show it some > > refactoring love in the meantime. Switching to using a workqueue and > > sleeping locks improves cryptsetup benchmark results for AES encryption= . > > What is motivating this work? I thought this driver is useless because A= RMv8 CE > is an order of magnitude faster. > We'll be extending support for this IP with some additional features soon like using device unique keys etc. This is just some refreshment of this module. Bartosz