mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yong-Xuan Wang <yongxuan.wang@sifive.com>
To: Conor Dooley <conor@kernel.org>
Cc: Paul Walmsley <pjw@kernel.org>,
	Samuel Holland <samuel.holland@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Alexandre Ghiti <alex@ghiti.fr>,
	linux-riscv@lists.infradead.org,  linux-kernel@vger.kernel.org,
	greentime.hu@sifive.com,  vincent.chen@sifive.com,
	zong.li@sifive.com
Subject: Re: [PATCH] riscv/sifive: remove warning in errata
Date: Wed, 29 Apr 2026 22:56:43 +0800	[thread overview]
Message-ID: <CAMWQL2gvV6+zTmDw2pizCVfQUcJrtQc7RWDpbeP8ErVmU8m6CA@mail.gmail.com> (raw)
In-Reply-To: <20260427-landside-bush-45bf90908635@spud>

Hi Conor,

On Mon, Apr 27, 2026 at 11:12 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Sun, Apr 26, 2026 at 07:53:46PM -0700, Yong-Xuan Wang wrote:
> > The patch_id of the availability checking for SiFive vendor extensions
> > will always larger than ERRATA_SIFIVE_NUMBER. Remove this unnecessary
> > warning.
>
> I'm sorry, I don't quite understand this commit message. Where is the
> other warning that makes this one unneeded?
> I think the commit message needs to point out where that is.
>

Sorry it's my fault. I will update the commit message in the next version.

Regards,
Yong-Xuan

> Cheers,
> Conor.
>
> >
> > Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com>
> > ---
> >  arch/riscv/errata/sifive/errata.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/riscv/errata/sifive/errata.c b/arch/riscv/errata/sifive/errata.c
> > index d0c61f86cba3..98edd9143321 100644
> > --- a/arch/riscv/errata/sifive/errata.c
> > +++ b/arch/riscv/errata/sifive/errata.c
> > @@ -94,7 +94,6 @@ void sifive_errata_patch_func(struct alt_entry *begin, struct alt_entry *end,
> >               if (alt->vendor_id != SIFIVE_VENDOR_ID)
> >                       continue;
> >               if (alt->patch_id >= ERRATA_SIFIVE_NUMBER) {
> > -                     WARN(1, "This errata id:%d is not in kernel errata list", alt->patch_id);
> >                       continue;
> >               }
> >
> >
> > ---
> > base-commit: ddbf9c76c4020bf63a0799b00faad40caa3de6c2
> > change-id: 20260426-vendor-4b4427e0b670
> >

      reply	other threads:[~2026-04-29 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27  2:53 Yong-Xuan Wang
2026-04-27 15:12 ` Conor Dooley
2026-04-29 14:56   ` Yong-Xuan Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMWQL2gvV6+zTmDw2pizCVfQUcJrtQc7RWDpbeP8ErVmU8m6CA@mail.gmail.com \
    --to=yongxuan.wang@sifive.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor@kernel.org \
    --cc=greentime.hu@sifive.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=vincent.chen@sifive.com \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®