mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Yury Norov <yury.norov@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Tom Rix <trix@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] linux/find: ignore -Wtype-limits to reduce W=2 warnings by 34% tree-wide
Date: Wed, 27 Apr 2022 11:32:53 +0900	[thread overview]
Message-ID: <CAMZ6RqKdSET45pXLu9pTY4Weqxdpqmio5ca5M8f33uYPe+NPHA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a2ZUfpWiHh6yeAy3fFP8k5BcE8crkis7Savxhdym1e-FQ@mail.gmail.com>

On Wed. 27 Apr 2022 at 03:56, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Apr 26, 2022 at 6:16 PM Vincent Mailhol
> <mailhol.vincent@wanadoo.fr> wrote:
>
> > +__diag_push();
> > +__diag_ignore(GCC, 8, "-Wtype-limits",
> > +             "GENMASK(size - 1, 0) yields 'comparison of unsigned expression in < 0 is always false' which is OK");
> > +
>
> Are you sure gcc-8 is the correct version to check for?
> If older versions had this
> already, you may have to add the magic bits in the compiler-gcc.h header.

Right, I used GCC-8 because this is what is available off the
shelf in compiler-gcc.h (and I CC'd you on purpose because I
though you might have relevant comments).

-Wtype-limits was introduced in GCC 4.3. Need to check if this
specific check existed back then, but I strongly expect the older
version to also trigger the warning.  It might take me a bit of
time to set up an environment with an old GCC (nothing hard, just
need to get access to the good machine). So do not worry if I
stay silent on this subject for the next couple of days.

Yours sincerely,
Vincent Mailhol

  reply	other threads:[~2022-04-27  2:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 16:16 Vincent Mailhol
2022-04-26 18:56 ` Arnd Bergmann
2022-04-27  2:32   ` Vincent MAILHOL [this message]
2022-04-26 20:42 ` Yury Norov
2022-04-27  2:58   ` Vincent MAILHOL
2022-04-27 13:21     ` Alexander Lobakin
2022-04-27 14:04     ` Yury Norov
2022-04-28  6:06       ` Vincent MAILHOL
2022-05-08  9:12     ` Vincent MAILHOL

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMZ6RqKdSET45pXLu9pTY4Weqxdpqmio5ca5M8f33uYPe+NPHA@mail.gmail.com \
    --to=mailhol.vincent@wanadoo.fr \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=trix@redhat.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®