mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: "Tudor, Laurentiu" <Laurentiu.Tudor1@dell.com>,
	 "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	 Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 dmitry.baryshkov@oss.qualcomm.com,
	 Stephan Gerhold <stephan.gerhold@linaro.org>
Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: x1e80100-dell-xps-9345: Add WiFi/BT pwrseq
Date: Mon, 31 Mar 2025 18:51:03 +0200	[thread overview]
Message-ID: <CAMcHhXqO2Ej3UAej9QodX1NNCHAk956++=oakPxx-MkpOucJ2Q@mail.gmail.com> (raw)
In-Reply-To: <Z-p1uADNVAM9NcAW@hovoldconsulting.com>

On Mon, 31 Mar 2025 at 13:00, Johan Hovold <johan@kernel.org> wrote:
>
> On Mon, Mar 31, 2025 at 11:38:25AM +0200, Aleksandrs Vinarskis wrote:
> > On Mon, 31 Mar 2025 at 10:09, Johan Hovold <johan@kernel.org> wrote:
> > >
> > > [ +CC: Stephan ]
> > >
> > > On Mon, Mar 31, 2025 at 08:33:47AM +0100, Aleksandrs Vinarskis wrote:
> > > > Add the WiFi/BT nodes for XPS and describe the regulators for the WCN7850
> > > > combo chip using the new power sequencing bindings. All voltages are
> > > > derived from chained fixed regulators controlled using a single GPIO.
> > > >
> > > > Based on the commit d09ab685a8f5 ("arm64: dts: qcom: x1e80100-qcp: Add
> > > > WiFi/BT pwrseq").
> > >
> > > Are you sure this is correct and that you don't need to worry about the
> > > "how do we model the supplies to an M.2 card" issue?
> > >
> > > See
> > >
> > >         https://lore.kernel.org/lkml/Z-KuG0aOwEnxuhp9@linaro.org/
> >
> > Dell XPS 9345 does not have an M.2 card, WLAN package is soldered
> > directly onboard, hence I am quite sure this is similar to QCP.
> > To be certain, perhaps @Tudor, Laurentiu or @Bryan O'Donoghue (if  you
> > have it?) could confirm from schematics?
>
> I checked now, it seems you are correct.\

Ah perfect, thanks.

>
> Highly annoying that we need all this guess-work boiler plate (about
> chip internal details) for what is effectively just two supplies.
>
> Hopefully we can drop that again going forward, but that's a separate
> discussion.
>
> > > > With that fixed commit f5b788d0e8cd ("arm64: dts: qcom: Add support for
> > > > X1-based Dell XPS 13 9345")
> > >
> > > Not sure what happened here.
> >
> > Bluetooth and WLAN definitions were missing, as at the time I only
> > knew the UART port being used for bluetooth, and was missing
> > everything else to describe it.
>
> Ah, ok. The above sentence looked like some left-over copy paste. I
> guess you don't need to mention it at all since this does not seem to
> warrant a proper Fixes tag.

It was a suggestion from Dmitry in v1. Though indeed it does not
warrant a proper Fixed tag, as it is something  that was left out from
the initial series, I think it's fine to keep it like this, if it's
okay with you?

Regards,
Alex

>
> Johan

  reply	other threads:[~2025-03-31 16:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31  7:33 [PATCH v2 0/1] " Aleksandrs Vinarskis
2025-03-31  7:33 ` [PATCH v2 1/1] " Aleksandrs Vinarskis
2025-03-31  8:09   ` Johan Hovold
2025-03-31  9:38     ` Aleksandrs Vinarskis
2025-03-31 11:00       ` Johan Hovold
2025-03-31 16:51         ` Aleksandrs Vinarskis [this message]
2025-03-31 19:06           ` Johan Hovold
2025-03-31 20:15             ` Dmitry Baryshkov
2025-03-31 20:27               ` Aleksandrs Vinarskis
2025-03-31  8:33   ` Bryan O'Donoghue
2025-03-31  9:40     ` Aleksandrs Vinarskis
2025-03-31 13:22   ` Tudor, Laurentiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMcHhXqO2Ej3UAej9QodX1NNCHAk956++=oakPxx-MkpOucJ2Q@mail.gmail.com' \
    --to=alex.vinarskis@gmail.com \
    --cc=Laurentiu.Tudor1@dell.com \
    --cc=andersson@kernel.org \
    --cc=bjorn.andersson@oss.qualcomm.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=johan@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=stephan.gerhold@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®