From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Stanislaw Gruszka <stf_xl@wp.pl>, Rosen Penev <rosenp@gmail.com>,
Johannes Berg <johannes.berg@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: wireless: rt2x00: fix CRC_CCITT dependency
Date: Tue, 5 Aug 2025 08:59:05 +0200 [thread overview]
Message-ID: <CAMhs-H8zVcDtbeXQ32aw2gO2D8tkykwTOfoqxxK7PVwM_QPLiA@mail.gmail.com> (raw)
In-Reply-To: <20250731075837.1969136-1-arnd@kernel.org>
On Thu, Jul 31, 2025 at 9:58 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing this driver on Arm platforms shows a link failure
> when the CRC functions are not part of the kernel:
>
> x86_64-linux-ld: drivers/net/wireless/ralink/rt2x00/rt2800lib.o: in function `rt2800_check_firmware':
> rt2800lib.c:(.text+0x20e5): undefined reference to `crc_ccitt'
>
> Move the select statement to the correct Kconfig symbol to match
> the call site.
>
> Fixes: 311b05e235cf ("wifi: rt2x00: add COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/wireless/ralink/rt2x00/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
prev parent reply other threads:[~2025-08-05 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 7:58 Arnd Bergmann
2025-08-01 10:43 ` Stanislaw Gruszka
2025-08-05 6:59 ` Sergio Paracuellos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMhs-H8zVcDtbeXQ32aw2gO2D8tkykwTOfoqxxK7PVwM_QPLiA@mail.gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®