mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Jia He <justin.he@arm.com>, "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Huacai Chen <chenhuacai@kernel.org>,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexandru Elisei <alexandru.elisei@arm.com>
Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Date: Tue, 31 Jan 2023 08:18:49 +0100	[thread overview]
Message-ID: <CAMj1kXFTUXgaENBSYh+cGCS3wFCFunf+auk3nKwHVJWiZ7crig@mail.gmail.com> (raw)
In-Reply-To: <20230131040355.3116-1-justin.he@arm.com>

(cc Jason for awareness)

On Tue, 31 Jan 2023 at 05:04, Jia He <justin.he@arm.com> wrote:
>
> I met a hung task warning and then kernel was hung forever with latest
> kernel on an Ampere Emag server.
>
> The root cause is kernel was hung  when invoking an efi rts call to set
> the RandomSeed variable during the booting stage. The arch_efi_call_virt
> call (set_variable) was never returned and then caused the hung task error.
>

Given that EFI variables work on this platform (as far as I know), the
problem may be that we are calling SetVariable() too early.

Could you double check whether setting variables works as expected?
You can use efibootmgr -t 10 as root (for example) to set the boot
timeout, and check whether the new value is retained after a reboot
(efibootmgr will print the current value for you)

Could you also please share the kernel log up until the point where it hangs?


> On the Emag server, efi_rt_services_supported(EFI_RT_SUPPORTED_SET_VARIABLE)
> is returned with "true"
>

This is as expected: if the firmware does not expose the RT properties
table, all runtime services are assumed to be available.

> Fix it by introducing the efi_get_supported_rt_services() and then determine
> to set or clear the runtime services bit of efi.flags.
>
> Jia He (2):
>   efi: libstub: Fix the retriving of supported rutime services
>   efi: Introduce efi_get_supported_rt_services() to get the runtime
>     services mask
>
>  drivers/firmware/efi/arm-runtime.c      |  5 ++++-
>  drivers/firmware/efi/efi.c              | 28 +++++++++++++++++--------
>  drivers/firmware/efi/libstub/efi-stub.c |  2 ++
>  include/linux/efi.h                     |  1 +
>  4 files changed, 26 insertions(+), 10 deletions(-)
>
> --
> 2.25.1
>

  parent reply	other threads:[~2023-01-31  7:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31  4:03 Jia He
2023-01-31  4:03 ` [PATCH 1/2] efi: libstub: Fix the retriving of supported rutime services Jia He
2023-01-31  7:04   ` Ard Biesheuvel
2023-01-31  4:03 ` [PATCH 2/2] efi: Introduce efi_get_supported_rt_services() to get the runtime services mask Jia He
2023-01-31  7:06   ` Ard Biesheuvel
2023-01-31  7:18 ` Ard Biesheuvel [this message]
2023-01-31 15:21   ` [PATCH 0/2] Fix boot hang issue on Ampere Emag server Justin He
2023-01-31 15:31     ` Justin He
2023-01-31 18:23     ` Jason A. Donenfeld
2023-02-02 10:50       ` Justin He
2023-02-07  3:21         ` Justin He
2023-02-07  8:44           ` Ard Biesheuvel
2023-02-07  8:49             ` Justin He
2023-02-07  8:54               ` Ard Biesheuvel
2023-02-07  9:02                 ` Justin He
2023-02-07  9:03                   ` Ard Biesheuvel
2023-02-07  9:08                     ` Justin He
2023-02-07  9:09                       ` Ard Biesheuvel
2023-02-08  3:10                         ` Justin He
2023-01-31 18:03   ` Jason A. Donenfeld
2023-01-31 18:13     ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXFTUXgaENBSYh+cGCS3wFCFunf+auk3nKwHVJWiZ7crig@mail.gmail.com \
    --to=ardb@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=alexandru.elisei@arm.com \
    --cc=chenhuacai@kernel.org \
    --cc=justin.he@arm.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®