From: Ard Biesheuvel <ardb@kernel.org>
To: Jonathan Marek <jonathan@marek.ca>
Cc: linux-efi@vger.kernel.org, Aditya Garg <gargaditya08@live.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
Ingo Molnar <mingo@kernel.org>, Kees Cook <kees@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
Nikolay Borisov <nik.borisov@suse.com>
Subject: Re: [PATCH v2 0/2] efi/libstub: fix efi_parse_options() ignoring the default command line
Date: Mon, 14 Oct 2024 11:55:11 +0200 [thread overview]
Message-ID: <CAMj1kXGbuZnM8GoHasWNxs2YOnUDL-JViRmvGdVc91WHkMbdqA@mail.gmail.com> (raw)
In-Reply-To: <b13dc40b-cb72-02f6-0379-358499696eb2@marek.ca>
On Sun, 13 Oct 2024 at 21:25, Jonathan Marek <jonathan@marek.ca> wrote:
>
> On 10/13/24 1:30 PM, Ard Biesheuvel wrote:
> > On Sun, 13 Oct 2024 at 07:16, Jonathan Marek <jonathan@marek.ca> wrote:
> >>
> >> v2:
> >> - changed to check for NUL character instead of size==1
> >> - reworked cleanup patch to remove cmd_line_len
> >> - moved 3rd commit out of this series
> >>
> >> Jonathan Marek (2):
> >> efi/libstub: fix efi_parse_options() ignoring the default command line
> >> efi/libstub: remove unnecessary cmd_line_len from
> >> efi_convert_cmdline()
> >>
> >
> > Thanks. I'm inclined to fold these together and just merge them as a
> > single patch. Any objections?
> >
>
> No objections (its not important to me, but if you want to get the fix
> into stable I think the separate commits makes that easier?)
Yeah good point. I am not going to send these out as fixes anyway,
given that they affect boot behavior, and there are some other things
to fix.
prev parent reply other threads:[~2024-10-14 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-13 5:11 Jonathan Marek
2024-10-13 5:11 ` [PATCH v2 1/2] " Jonathan Marek
2024-10-13 5:11 ` [PATCH v2 2/2] efi/libstub: remove unnecessary cmd_line_len from efi_convert_cmdline() Jonathan Marek
2024-10-13 17:30 ` [PATCH v2 0/2] efi/libstub: fix efi_parse_options() ignoring the default command line Ard Biesheuvel
2024-10-13 19:22 ` Jonathan Marek
2024-10-14 9:55 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXGbuZnM8GoHasWNxs2YOnUDL-JViRmvGdVc91WHkMbdqA@mail.gmail.com \
--to=ardb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=gargaditya08@live.com \
--cc=jonathan@marek.ca \
--cc=kees@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nik.borisov@suse.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®