From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F5FC14F70; Tue, 7 Jan 2025 07:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736235414; cv=none; b=YCmqHKRszzT5ZaW5Te9TPZFVrHbq+cMsgfFNT/0ufPjE5mv34VT7O2msDvoES00sd/yaLnBptHmr94jZq5+r6YSLNdOIfY6otqkCpjYSULlVzqBGpUUU8BWWPgjPjdV4qZzU7XRYSji4bvSRHFFVAy/61CBhJWLc2i/zmzqqqX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736235414; c=relaxed/simple; bh=450lMuau3ge71dUQh/4nnXDvWTEzOSz2lqm5heD5NXU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=kQHoFyqdqdrXszqovjrCehwKRLgbof/INZnhyGcm0D6XErzmx7rZK+x4pUL89rOYa/YVDPR2MMz5OZqbY5UX/Lm0fxbjGllFqDy0aGmr/eKYoDTEcKBvLVfRECobYozGyLMFmMdl6f348yDJ3HqR0FTT/8UMXUeJt052WJ3FnJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qXFDF/JI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qXFDF/JI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7AE7C4CEE0; Tue, 7 Jan 2025 07:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736235413; bh=450lMuau3ge71dUQh/4nnXDvWTEzOSz2lqm5heD5NXU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qXFDF/JIz2XSgZeT3m2q4hKxvacYMW8Rb+rqakeaKD+QTSPp+ZPVOF+1NCWw4H/p2 5o4/p/aL3F+YEdLgYBrmXUjlbbLhJOiTup8x6fojrZRnRQMPTF6eBO89uhxx/H7sLu b6Rq8ibhc6pfIoR2/OIY0H39JX7SLZC0olqne5haEiXxwuv/VAZCfN2NfOHzu+Y/Oh 5j/WHN+sv9L23Ut8vK+EIB8ZQeqhTtD3k/ZXMG2NKth+g1jtocEwctXageXQX5mKCd 21xmNV9nb09xZzIFKPYG14YjomLCuHvYny4qZSUS3AJWGXqTeLj7HfgyKZ8MQ873Qi HZ+huqFzrLGbg== Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5401bd6ccadso15127024e87.2; Mon, 06 Jan 2025 23:36:53 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUpc4LCXH+PFvx2r+R5mDkJuf9W38OObphlPRgjURzn9pRq+NL0B1JQCgsleu+1AjeDkkMEtOi7vH4=@vger.kernel.org, AJvYcCWez2sxeC3VXkXzO7tU4YJ0sANUZ88yYbzTDJSGs5XFPcdS74BUDLmAYXexLYkacsjo/I3YeTHyRbuRrXS4@vger.kernel.org X-Gm-Message-State: AOJu0YzdWmIMDNy9ou/Uttljz6ZpCtpGzEohtWI/LfNAhf8wGTRZhRwK nmS2i/ZPcW+p6/FrjgO7FFQVadL2GuEZDxjb8dRK3fgNiuyLHDnWEjqCMTrbLSz87SF07OkiPLv /2gKoOOOUmsThOl/OiVZpWu60feA= X-Google-Smtp-Source: AGHT+IGPUosH6afU/CZKDhPOuZ+SIz9KInC8qNvf/oURLrED3KVV2AgUAPTeAHmJBvVuNOaVOZp7aHHY5/DxTMlRZzk= X-Received: by 2002:a05:6512:3a90:b0:542:249c:2156 with SMTP id 2adb3069b0e04-54229530077mr19659517e87.15.1736235412131; Mon, 06 Jan 2025 23:36:52 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241209182041.60286-1-hamzamahfooz@linux.microsoft.com> In-Reply-To: From: Ard Biesheuvel Date: Tue, 7 Jan 2025 08:36:40 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AbW1kvbpRcLM9TDPqiwYiln6YAzNs7ZWzSMO1Ma3fWdYJ7IGa-8KF30Lm4psnRY Message-ID: Subject: Re: [PATCH] efi: bump up EFI_MMAP_NR_SLACK_SLOTS to 32 To: =?UTF-8?Q?V=C3=ADctor_Gonzalo?= Cc: Hamza Mahfooz , linux-efi@vger.kernel.org, stable@kernel.org, Allen Pais , Tyler Hicks , Kuppuswamy Sathyanarayanan , "Kirill A. Shutemov" , Andrew Morton , Jonathan Marek , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 31 Dec 2024 at 12:12, V=C3=ADctor Gonzalo wrote: > > El jue, 19 dic 2024 a las 12:27, Ard Biesheuvel () escri= bi=C3=B3: > > > > On Tue, 10 Dec 2024 at 10:59, Ard Biesheuvel wrote: > > > > > > On Mon, 9 Dec 2024 at 19:20, Hamza Mahfooz > > > wrote: > > > > > > > > Recent platforms require more slack slots than the current value of > > > > EFI_MMAP_NR_SLACK_SLOTS, otherwise they fail to boot. The current > > > > workaround is to append `efi=3Ddisable_early_pci_dma` to the kernel= 's > > > > cmdline. So, bump up EFI_MMAP_NR_SLACK_SLOTS to 32 to allow those > > > > platforms to boot with the aforementioned workaround. > > > > > > > > Cc: stable@kernel.org > > > > Cc: Ard Biesheuvel > > > > Cc: Allen Pais > > > > Cc: Tyler Hicks > > > > Signed-off-by: Hamza Mahfooz > > > > --- > > > > drivers/firmware/efi/libstub/efistub.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/firmware/efi/libstub/efistub.h b/drivers/firmw= are/efi/libstub/efistub.h > > > > index 76e44c185f29..e95ce6ae5c26 100644 > > > > --- a/drivers/firmware/efi/libstub/efistub.h > > > > +++ b/drivers/firmware/efi/libstub/efistub.h > > > > @@ -171,7 +171,7 @@ void efi_set_u64_split(u64 data, u32 *lo, u32 *= hi) > > > > * the EFI memory map. Other related structures, e.g. x86 e820ext,= need > > > > * to factor in this headroom requirement as well. > > > > */ > > > > -#define EFI_MMAP_NR_SLACK_SLOTS 8 > > > > +#define EFI_MMAP_NR_SLACK_SLOTS 32 > > > > > > > > typedef struct efi_generic_dev_path efi_device_path_protocol_t; > > > > > > > > > > Acked-by: Ard Biesheuvel > > > > I've queued this up for v6.14 now - once we are confident it does not > > cause any regressions, we can backport it to stable branches too. > > > > Hi. I had this issue three years ago, suggested the bump and then > missed the reply. > We bumped it to 16 and have not had any issue or side effects in three ye= ars. Thanks for the data point.