From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A484C77B7C for ; Mon, 1 May 2023 22:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232200AbjEAWCy (ORCPT ); Mon, 1 May 2023 18:02:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbjEAWCv (ORCPT ); Mon, 1 May 2023 18:02:51 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90970EB for ; Mon, 1 May 2023 15:02:49 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-3ef36d814a5so21391cf.0 for ; Mon, 01 May 2023 15:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682978568; x=1685570568; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uUoPyEclplnbQ5nsG5OgNwVF48A7g0Micb2U/fMXHNA=; b=S3AYc2AIegwzM337Nai49vEIytMZBsPs3Yrvsbb8mZULcD9O2VW51PF3j9yS1A7HSo IlqcrY7C+y6Kq38ke2szkFf2Y8u7VeR4dc2nIiwrKxJIKPcjT6TgB5qcoBNEgKJXRZ7R +YorsZjxiZemj2YzPi/yrHHuqZ+UIhEK+MSXclZaFNzcfYMv0yVSY+tnaRbBBtaNQCIW utYRShodnQaza8a6GNhfGxL5OqRlmEsRJCfGx/dQpvzqU+uqq63IeoBjrmrmuxj5jBTx bVafRuqwBCY82Zqna0Ez00l66KSNjysu8FrC/neMwZv23TBHDocD6EKWx2z/+f0dcK5O 14LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682978568; x=1685570568; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uUoPyEclplnbQ5nsG5OgNwVF48A7g0Micb2U/fMXHNA=; b=gqE3Lyog7fEHLLKRXaAJk7j333NDVvMMVhH8kDMjP9T2TmXw1fqKefGqE8GW8ARYcy 0EtKg+JAcsNPC4q2OEVTA7b8hOB6FMWSXsAoq6tmPLX1lf9woFsvZgnBeX81sj90GNHE 7CKgtpMZ2IDTfXuUZYNMPsRQZeNmV7g8CF2n9UXKMR7sJ5VC9Q8SVkc7keGm3uAG1jN6 g7FFZgJ8XeGDVEQwOodeLt/veEWx+O+jYO0phw4kYMzR8SNDZU9RbHew/k7gvtQJdQHQ JY+BbsW5WPRdAszNt94x9L8uOh4jUSKqna53QBm/RByDhDrUYpE7UDi+tw4K7p/R5yO/ /mYg== X-Gm-Message-State: AC+VfDz1tu66ULAB7WEJh5V7dCjpZbe5O4rJ6Xx/shqJqkqKYNGzSiQr wlOE9XM5KAq60qqm1IbQ+Z7yVh5V00xeERoEsssPnQ== X-Google-Smtp-Source: ACHHUZ5CuqN0ueoP6LXfs8ZQiH2iNDJ0f/JbMmFWBRGoqTLO5Al7z/X8HDiTurSelO2YjDTLfuq7qw0/Vdw1XZ8K+mA= X-Received: by 2002:ac8:7f47:0:b0:3ef:62f2:52df with SMTP id g7-20020ac87f47000000b003ef62f252dfmr21723qtk.9.1682978568636; Mon, 01 May 2023 15:02:48 -0700 (PDT) MIME-Version: 1.0 References: <20230215143306.2d563215@rorschach.local.home> In-Reply-To: From: Peter Collingbourne Date: Mon, 1 May 2023 15:02:37 -0700 Message-ID: Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints To: Steven Rostedt Cc: Marco Elver , andrey.konovalov@linux.dev, Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Nick Desaulniers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 23, 2023 at 10:45=E2=80=AFPM Peter Collingbourne wrote: > > On Wed, Feb 15, 2023 at 11:33 AM Steven Rostedt wro= te: > > > > On Wed, 15 Feb 2023 09:57:40 +0100 > > Marco Elver wrote: > > > > > Yes, you are right, and it's something I've wondered how to do better > > > as well. Let's try to consult tracing maintainers on what the right > > > approach is. > > > > I have to go and revisit the config options for CONFIG_FTRACE and > > CONFIG_TRACING, as they were added when this all started (back in > > 2008), and the naming was rather all misnomers back then. > > > > "ftrace" is really for just the function tracing, but CONFIG_FTRACE > > really should just be for the function tracing infrastructure, and > > perhaps not even include trace events :-/ But at the time it was > > created, it was for all the "tracers" (this was added before trace > > events). > > It would be great to see this cleaned up. I found this aspect of how > tracing works rather confusing. > > So do you think it makes sense for the KASAN tests to "select TRACING" > for now if the code depends on the trace event infrastructure? Any thoughts? It looks like someone else got tripped up by this: https://reviews.llvm.org/D144057 Peter