From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751850AbcGXApw (ORCPT ); Sat, 23 Jul 2016 20:45:52 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:33022 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbcGXApv convert rfc822-to-8bit (ORCPT ); Sat, 23 Jul 2016 20:45:51 -0400 MIME-Version: 1.0 In-Reply-To: <1469319895-17578-1-git-send-email-linux@roeck-us.net> References: <1469319895-17578-1-git-send-email-linux@roeck-us.net> From: Max Filippov Date: Sun, 24 Jul 2016 03:45:49 +0300 Message-ID: Subject: Re: [PATCH -next] xtensa: Fix build error due to missing include file To: Guenter Roeck Cc: Chris Zankel , "linux-xtensa@linux-xtensa.org" , LKML , Kefeng Wang , Rob Herring Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 24, 2016 at 3:24 AM, Guenter Roeck wrote: > Commit 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate > with default match table") dropped various include files from > arch/xtensa/kernel/setup.c. This results in the following build error. > > arch/xtensa/kernel/setup.c: In function ‘xtensa_dt_io_area’: > arch/xtensa/kernel/setup.c:213:2: error: > implicit declaration of function ‘of_read_ulong’ > > Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table") > Cc: Kefeng Wang > Cc: Rob Herring > Signed-off-by: Guenter Roeck > --- > I would suggest to merge this patch into the commit causing the problem > if possible. > > arch/xtensa/kernel/setup.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Max Filippov -- Thanks. -- Max